mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Andrea Righi <arighi@nvidia.com>
Cc: David Vernet <void@manifault.com>,
	Changwoo Min <changwoo@igalia.com>,
	sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH sched_ext/for-6.18] sched_ext: Add migration-disabled counter to error state dump
Date: Thu, 18 Sep 2025 05:49:20 -1000	[thread overview]
Message-ID: <aMwqAP76eVSIIIDn@slm.duckdns.org> (raw)
In-Reply-To: <20250918092928.402242-1-arighi@nvidia.com>

Hello,

On Thu, Sep 18, 2025 at 11:29:28AM +0200, Andrea Righi wrote:
> Include the task's migration-disabled counter when dumping task state
> during an error exit.
> 
> This can help diagnose cases where tasks can get stuck, because they're
> unable to migrate elsewhere.
> 
> Signed-off-by: Andrea Righi <arighi@nvidia.com>
> ---
>  kernel/sched/ext.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
> index 477eccf023388..e03bb51364661 100644
> --- a/kernel/sched/ext.c
> +++ b/kernel/sched/ext.c
> @@ -4167,7 +4167,8 @@ static void scx_dump_task(struct seq_buf *s, struct scx_dump_ctx *dctx,
>  		  p->scx.sticky_cpu, p->scx.holding_cpu, dsq_id_buf);
>  	dump_line(s, "      dsq_vtime=%llu slice=%llu weight=%u",
>  		  p->scx.dsq_vtime, p->scx.slice, p->scx.weight);
> -	dump_line(s, "      cpus=%*pb", cpumask_pr_args(p->cpus_ptr));
> +	dump_line(s, "      cpus=%*pb migration_disabled=%u", cpumask_pr_args(p->cpus_ptr),

Can you abbreviate this a bit? We have limited dump buffer size and real
estate. Wouldn't e.g. no_mig= achieve the same with a lot less space?

Thanks.

-- 
tejun

  reply	other threads:[~2025-09-18 15:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-18  9:29 Andrea Righi
2025-09-18 15:49 ` Tejun Heo [this message]
2025-09-18 16:00   ` Andrea Righi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aMwqAP76eVSIIIDn@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®