Re: [PATCH v1 1/2] perf test: Add an 'import perf' test shell script

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Wed, Oct 01, 2025 at 10:42:23AM -0300, Arnaldo Carvalho de Melo wrote:
> On Tue, Sep 30, 2025 at 01:02:55PM -0700, Ian Rogers wrote:
> > On Wed, Sep 3, 2025 at 11:42 AM Ian Rogers <irogers@google.com> wrote:
> > >
> > > The 'import perf' test needs to set up a path to the python module as
> > > well as to know the python command to invoke. These are hard coded at
> > > build time to be build a directory and the python used in the build,
> > > which is less than desirable. Avoid the hard coded values by reusing
> > > the existing shell script python setup and determine a potential built
> > > python module via the path of the perf executable.
> > >
> > > Signed-off-by: Ian Rogers <irogers@google.com>
> > 
> > Ping.
> 
> There is another patch in this area to make it work, right?
> 
> After applying this one I get a failure, only when I set PYTHONPATH it
> works:
> 
> ⬢ [acme@toolbx perf-tools-next]$ export PYTHONPATH=/tmp/build/perf-tools-next/python_ext_build/lib/
> ⬢ [acme@toolbx perf-tools-next]$ perf test -v pytho
> Couldn't bump rlimit(MEMLOCK), failures may take place when creating BPF maps, etc
>  88: 'import perf' in python                                         : Ok
> ⬢ [acme@toolbx perf-tools-next]$

⬢ [acme@toolbx perf-tools-next]$ b4 am -ctsl --cc-trailers 20250930231100.197258-1-collin.funk1@gmail.com
Grabbing thread from lore.kernel.org/all/20250930231100.197258-1-collin.funk1@gmail.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 5 messages in the thread
Analyzing 0 code-review messages
Checking attestation on all messages, may take a moment...
---
  ✗ [PATCH v1 1/2] perf test: Add an 'import perf' test shell script
    + Link: https://lore.kernel.org/r/20250903184248.695267-1-irogers@google.com
    + Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  ✗ [PATCH v1 2/2] perf test: Remove C python_use test
    + Link: https://lore.kernel.org/r/20250903184248.695267-2-irogers@google.com
    + Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  ---
  ✗ BADSIG: DKIM/google.com
---
Total patches: 2
---
 Link: https://lore.kernel.org/r/20250903184248.695267-1-irogers@google.com
 Base: not specified
       git am ./20250903_irogers_perf_test_add_an_import_perf_test_shell_script.mbx
⬢ [acme@toolbx perf-tools-next]$        git am ./20250903_irogers_perf_test_add_an_import_perf_test_shell_script.mbx
Applying: perf test: Add an 'import perf' test shell script
error: tools/perf/tests/shell/python-use.sh: already exists in index
Patch failed at 0001 perf test: Add an 'import perf' test shell script
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
⬢ [acme@toolbx perf-tools-next]$