From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52241296BA8 for ; Wed, 1 Oct 2025 23:37:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759361830; cv=none; b=QJr/Gqtgibs8oRUXzlTYs7Yy/MEo6MyQj9b+438YkUUtSE58nGDr1Z/To4eTQQKRqUehgm74c1iwjWK2+Dn5gLX9NPGM20gjhH63eAXaUv/6QJwrDCdzeexZbsU+5leJDj+k+RbstpcmL4qOONQiOIpPMbo1TIi+9VpZXcufeto= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759361830; c=relaxed/simple; bh=/5iicqHQjoGwUlM+9rOZ5LTZwwl6tmDWHqqXpweuOEE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BxBY02OYkVkQKm6kE7/5Zr4Q1xGSVZSZHvzyxVXicK8W3ua+ImcRR5VS4RgEr+S6ZqkN7UaoVY7hQCey673F+veyGTvJvovsa9CLjfLsZTs/ZF/A1AkuBX33Z1Htv7pXtdDWhoYM4Ocdwkpxp67Dkxdu9YdT//86SSkg3fMmDzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MzATrGwF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MzATrGwF" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 591Ic8kO019972 for ; Wed, 1 Oct 2025 23:37:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=kUhpV5L9OVSY0jP0UCvDdukq clE+5qyGR802XH0NEj0=; b=MzATrGwFoZwGj85rvlhUJAGeRvpuIBuJ1gw4quo6 eeAENKlTkHIoSvkMnAmdtv6gU8EvGkUNeA+Q1JmwuLfQEKa/63Dy+wlXj6AtI2IE FcrsyyPRTBzt4k0zfTDHGYe3Gey2jUQXlOA5QgiO8sh9GIGVxpCAYH+oG76jaK+w 5+NRyvV3cDcnb+/YiLnZFEFp9mwyelq6FRaJe+O734QdjPXF1Pm06P7dAVxLowFz KI0Swx/Aygd7llojuoqLvCVZLyf0csBAnWk/sejEPJaPlHCZ86iMyEerIr+0qi9y cffKt8abX5ZD7ddiWeF8L+SwRoyhu7nmHQNVaomHWx9oMw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49gyu1af56-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 01 Oct 2025 23:37:06 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-269a2b255aaso7141885ad.3 for ; Wed, 01 Oct 2025 16:37:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759361825; x=1759966625; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kUhpV5L9OVSY0jP0UCvDdukqclE+5qyGR802XH0NEj0=; b=bxMpPc564naLUVGKgnLXD5CuciXpFEAVipomzMu3P9YnO4IKRmv3maOV5eTslrSAAo 9QgLsQyGtFtaRNTFZyRmDtSPyaM8b8bPWH4a4XEsJWd4BfcPyF2hiS+32B/A28RA07N1 qf1dSAbS3remD/f/4LKv6OlShchHgiToSjGgic5da0ZeNR4XaduH6J4BK4xs+uviwUTj brx+/KcMSLKSRtHNcIaexxQedIm7a/Yp+1gl8zjPDen2XskUV/JHv3H45iky3jb+c+c8 yZ14XshsFrNOA409ae9td7caYPT0W5iOcWS/DpK/nIMDuCyRIwMcuI/XiljvhDNPPdRL T42A== X-Forwarded-Encrypted: i=1; AJvYcCWsF4WcuqxqFptCFXnyzFnHkbS5wr3vLGkvT3GZzf+Nt6UdV6ZVZOJ2wlY+/jTtL96rDUhT/PNaeyjzyW4=@vger.kernel.org X-Gm-Message-State: AOJu0YwDqoL8ovj6Z4keV7GmlDqf7JR9Qq6DQRHmaTFYlgeCb8nhdLF6 OqhIk0eGAeQaIp6LmT39kBj5qryN0GF1zMtK4xPF+/htH0XrNEEUs2Z+1jUBBbT8oxjptg8Eq01 z1kmZisw1JEe6KH4Q1UKARUMaGxg6oZjC9ZReD2ea4DK/iIGjATDKqtW0b5LePQcC/xM= X-Gm-Gg: ASbGncsdOGVb6+sjlWVyxfoWeA/8H/4jvyunTeqXZi6kpgGWPwpp7/F8mt9qmAN3JFE MhPFb9yOyu2XktCrZl+fSz0P6Jh6Xt+fXtk1/NzP+vIiKlVntjXKFrCu5AZiLptmimkvRvRNOxh NSN00Ti/EKN7+5AZJ/cJ9N2TsYMApZ+qXnshQAaU8vIzDDEbpkgbqLXhq/zLerGP4adEQeGwslJ hqfA9SY/90mvGmu/nbrlFPe9ZhLDruEWV4l5bhDSPGOs/QFlO9NFS+6BQcutoi/WZyPmo7v73Wg GAS15F1kVIjqGlTxdyOj1myBlDdareXbbOtGbEkvOs7XLtNHv37URVEns7y/qpgEVdYJQrFwbp2 yuRcUpSz6xo3WfBUItpHi6+HZrOXA X-Received: by 2002:a17:902:82c6:b0:269:a8a8:4029 with SMTP id d9443c01a7336-28e7f16792bmr52107415ad.5.1759361824790; Wed, 01 Oct 2025 16:37:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGhsy+qF/B38JhyqIfiaawE+CjEz1XsZfy+/GEYo2B04BMyD9Lk33BJRu/DQ31TIUc3DOq43A== X-Received: by 2002:a17:902:82c6:b0:269:a8a8:4029 with SMTP id d9443c01a7336-28e7f16792bmr52107025ad.5.1759361824293; Wed, 01 Oct 2025 16:37:04 -0700 (PDT) Received: from hu-bjorande-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-28e8d1280a1sm7543645ad.51.2025.10.01.16.37.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Oct 2025 16:37:03 -0700 (PDT) Date: Wed, 1 Oct 2025 16:37:01 -0700 From: Bjorn Andersson To: Krishna Chaitanya Chundru Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, quic_vbadigan@quicinc.com, quic_mrana@quicinc.com Subject: Re: [PATCH v3 2/3] arm64: dts: qcom: sm8750: Add PCIe PHY and controller node Message-ID: References: <20250826-pakala-v3-0-721627bd5bb0@oss.qualcomm.com> <20250826-pakala-v3-2-721627bd5bb0@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250826-pakala-v3-2-721627bd5bb0@oss.qualcomm.com> X-Authority-Analysis: v=2.4 cv=RfGdyltv c=1 sm=1 tr=0 ts=68ddbb22 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=x6icFKpwvdMA:10 a=EUspDBNiAAAA:8 a=yW6qr2ef8xeCN_ra_UgA:9 a=xF2dmcnjyTH3buFl:21 a=CjuIK1q_8ugA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: ezyxZ_ZNhPHT2UjcG3fjSicnfvY5r7IJ X-Proofpoint-GUID: ezyxZ_ZNhPHT2UjcG3fjSicnfvY5r7IJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDAxMDA1OCBTYWx0ZWRfXxxEsRkpF6dnH jI8glmGAr0ZnCCstL5cBsvCpFsKBSXpYGKnN52pI92+jIgdP6Iqi9Xr+T8Mp/uv1ELuFTfxqAH/ NQ7k3s04UqwW/z1YCGpp4DBNDC2VxQf3qlb5GxDyd6GnpguVj0od7QOGBCl3uM/sG7DZTQ29qfL V/4OuNEAg4v774fnsV5L7cC3oZzEosFAinvLIGnJfZJtEWLAa0LXA9wElRbb9FbzprfG4gaEzCY edqvCpepFKw5Nyv1uKMXtfzI48rhwCww79QHMX2r7CAxMYJ9M7TXScdWKgoqA6FAP/Z9P0WtWVH 6FhS1g/xP3ORdx3/sNh76K5p3Gl+SsUEe83nktnJksZDzAVBCVGxoxcvhLyikdn3ap0jaoSYr1P 1iRmN46EP0g1Eoxu2Qb9IUYxBKsCcw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-01_07,2025-09-29_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 priorityscore=1501 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2510010058 On Tue, Aug 26, 2025 at 04:32:54PM +0530, Krishna Chaitanya Chundru wrote: > Add PCIe controller and PHY nodes which supports data rates of 8GT/s > and x2 lane. > I tried to boot the upstream kernel (next-20250925 defconfig) on my Pakala MTP with latest LA1.0 META and unless I disable &pcie0 the device is crashing during boot as PCIe is being probed. Is this a known problem? Is there any workaround/changes in flight that I'm missing? Regards, Bjorn > Signed-off-by: Krishna Chaitanya Chundru > --- > arch/arm64/boot/dts/qcom/sm8750.dtsi | 180 ++++++++++++++++++++++++++++++++++- > 1 file changed, 179 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi > index 4643705021c6ca095a16d8d7cc3adac920b21e82..b47668a64bcead3e48f58eeb2e41c04660493cb7 100644 > --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi > @@ -631,7 +631,7 @@ gcc: clock-controller@100000 { > clocks = <&bi_tcxo_div2>, > <0>, > <&sleep_clk>, > - <0>, > + <&pcie0_phy>, > <0>, > <0>, > <0>, > @@ -3304,6 +3304,184 @@ gic_its: msi-controller@16040000 { > }; > }; > > + pcie0: pcie@1c00000 { > + device_type = "pci"; > + compatible = "qcom,pcie-sm8750", "qcom,pcie-sm8550"; > + reg = <0x0 0x01c00000 0x0 0x3000>, > + <0x0 0x40000000 0x0 0xf1d>, > + <0x0 0x40000f20 0x0 0xa8>, > + <0x0 0x40001000 0x0 0x1000>, > + <0x0 0x40100000 0x0 0x100000>, > + <0x0 0x01C03000 0x0 0x1000>; > + reg-names = "parf", > + "dbi", > + "elbi", > + "atu", > + "config", > + "mhi"; > + > + #address-cells = <3>; > + #size-cells = <2>; > + ranges = <0x01000000 0x0 0x00000000 0x0 0x40200000 0x0 0x100000>, > + <0x02000000 0x0 0x40300000 0x0 0x40300000 0x0 0x23d00000>, > + <0x03000000 0x4 0x00000000 0x4 0x00000000 0x3 0x00000000>; > + bus-range = <0x00 0xff>; > + > + dma-coherent; > + > + linux,pci-domain = <0>; > + > + msi-map = <0x0 &gic_its 0x1400 0x1>, > + <0x100 &gic_its 0x1401 0x1>; > + msi-map-mask = <0xff00>; > + > + num-lanes = <2>; > + > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + ; > + interrupt-names = "msi0", > + "msi1", > + "msi2", > + "msi3", > + "msi4", > + "msi5", > + "msi6", > + "msi7", > + "global"; > + > + #interrupt-cells = <1>; > + interrupt-map-mask = <0 0 0 0x7>; > + interrupt-map = <0 0 0 1 &intc 0 0 0 149 IRQ_TYPE_LEVEL_HIGH>, > + <0 0 0 2 &intc 0 0 0 150 IRQ_TYPE_LEVEL_HIGH>, > + <0 0 0 3 &intc 0 0 0 151 IRQ_TYPE_LEVEL_HIGH>, > + <0 0 0 4 &intc 0 0 0 152 IRQ_TYPE_LEVEL_HIGH>; > + > + clocks = <&gcc GCC_PCIE_0_AUX_CLK>, > + <&gcc GCC_PCIE_0_CFG_AHB_CLK>, > + <&gcc GCC_PCIE_0_MSTR_AXI_CLK>, > + <&gcc GCC_PCIE_0_SLV_AXI_CLK>, > + <&gcc GCC_PCIE_0_SLV_Q2A_AXI_CLK>, > + <&gcc GCC_DDRSS_PCIE_SF_QTB_CLK>, > + <&gcc GCC_AGGRE_NOC_PCIE_AXI_CLK>, > + <&gcc GCC_CNOC_PCIE_SF_AXI_CLK>; > + clock-names = "aux", > + "cfg", > + "bus_master", > + "bus_slave", > + "slave_q2a", > + "ddrss_sf_tbu", > + "noc_aggr", > + "cnoc_sf_axi"; > + > + interconnects = <&pcie_noc MASTER_PCIE_0 QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, > + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS > + &cnoc_main SLAVE_PCIE_0 QCOM_ICC_TAG_ALWAYS>; > + interconnect-names = "pcie-mem", > + "cpu-pcie"; > + > + iommu-map = <0x0 &apps_smmu 0x1400 0x1>, > + <0x100 &apps_smmu 0x1401 0x1>; > + > + resets = <&gcc GCC_PCIE_0_BCR>; > + reset-names = "pci"; > + > + power-domains = <&gcc GCC_PCIE_0_GDSC>; > + > + operating-points-v2 = <&pcie0_opp_table>; > + > + status = "disabled"; > + > + pcie0_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + /* GEN 1 x1 */ > + opp-2500000 { > + opp-hz = /bits/ 64 <2500000>; > + required-opps = <&rpmhpd_opp_low_svs>; > + opp-peak-kBps = <250000 1>; > + }; > + > + /* GEN 1 x2 and GEN 2 x1 */ > + opp-5000000 { > + opp-hz = /bits/ 64 <5000000>; > + required-opps = <&rpmhpd_opp_low_svs>; > + opp-peak-kBps = <500000 1>; > + }; > + > + /* GEN 2 x2 */ > + opp-10000000 { > + opp-hz = /bits/ 64 <10000000>; > + required-opps = <&rpmhpd_opp_low_svs>; > + opp-peak-kBps = <1000000 1>; > + }; > + > + /* GEN 3 x1 */ > + opp-8000000 { > + opp-hz = /bits/ 64 <8000000>; > + required-opps = <&rpmhpd_opp_nom>; > + opp-peak-kBps = <984500 1>; > + }; > + > + /* GEN 3 x2 */ > + opp-16000000 { > + opp-hz = /bits/ 64 <16000000>; > + required-opps = <&rpmhpd_opp_nom>; > + opp-peak-kBps = <1969000 1>; > + }; > + > + }; > + > + pcieport0: pcie@0 { > + device_type = "pci"; > + reg = <0x0 0x0 0x0 0x0 0x0>; > + bus-range = <0x01 0xff>; > + > + #address-cells = <3>; > + #size-cells = <2>; > + ranges; > + phys = <&pcie0_phy>; > + }; > + }; > + > + pcie0_phy: phy@1c06000 { > + compatible = "qcom,sm8750-qmp-gen3x2-pcie-phy"; > + reg = <0 0x01c06000 0 0x2000>; > + > + clocks = <&gcc GCC_PCIE_0_AUX_CLK>, > + <&gcc GCC_PCIE_0_CFG_AHB_CLK>, > + <&tcsrcc TCSR_PCIE_0_CLKREF_EN>, > + <&gcc GCC_PCIE_0_PHY_RCHNG_CLK>, > + <&gcc GCC_PCIE_0_PIPE_CLK>; > + clock-names = "aux", > + "cfg_ahb", > + "ref", > + "rchng", > + "pipe"; > + > + assigned-clocks = <&gcc GCC_PCIE_0_PHY_RCHNG_CLK>; > + assigned-clock-rates = <100000000>; > + > + resets = <&gcc GCC_PCIE_0_PHY_BCR>; > + reset-names = "phy"; > + > + power-domains = <&gcc GCC_PCIE_0_PHY_GDSC>; > + > + #clock-cells = <0>; > + clock-output-names = "pcie0_pipe_clk"; > + > + #phy-cells = <0>; > + > + status = "disabled"; > + }; > + > ufs_mem_phy: phy@1d80000 { > compatible = "qcom,sm8750-qmp-ufs-phy"; > reg = <0x0 0x01d80000 0x0 0x2000>; > > -- > 2.34.1 >