From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Konrad Dybcio <konradybcio@kernel.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Benson Leung <bleung@chromium.org>,
Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
Jameson Thies <jthies@google.com>,
Andrei Kuchynski <akuchynski@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
chrome-platform@lists.linux.dev,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH RFC] usb: typec: thunderbolt: Fix Thunderbolt adapter type bitfield values
Date: Thu, 2 Oct 2025 19:19:02 +0800 [thread overview]
Message-ID: <aN5fpicXs-JwKvQo@tzungbi-laptop> (raw)
In-Reply-To: <20250926-topic-tbt_header_bit_fix-v1-1-122238af5c82@oss.qualcomm.com>
On Fri, Sep 26, 2025 at 02:32:57PM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> The value has been amended with the release of the USB Type-C
> Specification v2.1, reportedly as an erratum.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> I bundled a change to the CrOS EC driver based on the assumption that
> it worked around the faulty definition. I see the Intel PMC mux driver
> also checks for this bit, but it seems like that driver assumes that
> the value is in-spec (i.e. it may be buggy as of right now).
>
> Adding the respective maintainers to make sure everyone can see this.
I have no context to review the patch. However, the prefix of patch title
should be "platform/chrome: cros_ec_typec:".
Hi CHROMEOS EC USB TYPE-C maintainers,
Does the patch make sense to you?
next prev parent reply other threads:[~2025-10-02 11:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 12:32 Konrad Dybcio
2025-10-02 11:19 ` Tzung-Bi Shih [this message]
2025-10-02 19:30 ` Jameson Thies
2025-10-08 10:41 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN5fpicXs-JwKvQo@tzungbi-laptop \
--to=tzungbi@kernel.org \
--cc=abhishekpandit@chromium.org \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jthies@google.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®