From: Mary Strodl <mstrodl@csh.rit.edu>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: oe-kbuild@lists.linux.dev, linux-kernel@vger.kernel.org,
lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linus.walleij@linaro.org, brgl@bgdev.pl,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 1/3] gpio: mpsse: use rcu to ensure worker is torn down
Date: Thu, 2 Oct 2025 10:36:33 -0400 [thread overview]
Message-ID: <aN6N8diBxVk1k9pi@ada.csh.rit.edu> (raw)
In-Reply-To: <aNpH7gfhJXIBbCQZ@stanley.mountain>
Hey Dan,
On Mon, Sep 29, 2025 at 11:48:46AM +0300, Dan Carpenter wrote:
> On Mon, Sep 29, 2025 at 11:46:24AM +0300, Dan Carpenter wrote:
> > a14b0c5e3b0741 Mary Strodl 2025-09-23 339 /* Make sure list consumers are finished before we tear down */
> > a14b0c5e3b0741 Mary Strodl 2025-09-23 340 synchronize_rcu();
> > a14b0c5e3b0741 Mary Strodl 2025-09-23 @341 list_for_each_entry(worker, &destructors, destroy)
> > a14b0c5e3b0741 Mary Strodl 2025-09-23 @342 gpio_mpsse_stop(worker);
> >
> > This needs to be list_for_each_entry_safe() because gpio_mpsse_stop()
> > frees the worker. Or kfree_rcu() inside an rcu lock or something.
Really good catch! The loop above this one has the same problem. Will be fixed next revision :)
Thank you!
next prev parent reply other threads:[~2025-10-02 14:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 13:33 [PATCH v2 0/3] gpio: mpsse: add support for bryx brik Mary Strodl
2025-09-23 13:33 ` [PATCH v2 1/3] gpio: mpsse: use rcu to ensure worker is torn down Mary Strodl
2025-09-29 8:46 ` Dan Carpenter
2025-09-29 8:48 ` Dan Carpenter
2025-10-02 14:36 ` Mary Strodl [this message]
2025-10-01 7:15 ` Linus Walleij
2025-10-01 15:07 ` Mary Strodl
2025-10-01 22:51 ` Linus Walleij
2025-10-02 14:03 ` Tzung-Bi Shih
2025-10-02 14:34 ` Mary Strodl
2025-10-02 14:02 ` Tzung-Bi Shih
2025-10-02 14:28 ` Mary Strodl
2025-09-23 13:33 ` [PATCH v2 2/3] gpio: mpsse: add quirk support Mary Strodl
2025-09-23 13:33 ` [PATCH v2 3/3] gpio: mpsse: support bryx radio interface kit Mary Strodl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN6N8diBxVk1k9pi@ada.csh.rit.edu \
--to=mstrodl@csh.rit.edu \
--cc=brgl@bgdev.pl \
--cc=dan.carpenter@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®