From: Simon Horman <horms@kernel.org>
To: Buday Csaba <buday.csaba@prolan.hu>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] net: mdio: reset PHY before attempting to access registers in fwnode_mdiobus_register_phy
Date: Wed, 15 Oct 2025 18:04:42 +0100 [thread overview]
Message-ID: <aO_UKlH-Zxl1tq3W@horms.kernel.org> (raw)
In-Reply-To: <20251015134503.107925-4-buday.csaba@prolan.hu>
On Wed, Oct 15, 2025 at 03:45:03PM +0200, Buday Csaba wrote:
...
> drivers/net/mdio/fwnode_mdio.c | 37 +++++++++++++++++++++++++++++++++-
> 1 file changed, 36 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c
> index ba7091518..6987b1a51 100644
> --- a/drivers/net/mdio/fwnode_mdio.c
> +++ b/drivers/net/mdio/fwnode_mdio.c
> @@ -114,6 +114,38 @@ int fwnode_mdiobus_phy_device_register(struct mii_bus *mdio,
> }
> EXPORT_SYMBOL(fwnode_mdiobus_phy_device_register);
>
> +/**
> + * fwnode_reset_phy() - Hard-reset a PHY before registration
Hi Buday,
This is not a full review. But as this is a Kernel doc (a comment in Kernel
doc format), it should also document:
1. The function arguments:
* @bus: ...
* @addr: ...
* @phy_node: ...
2. The return value:
* Returns: ...
Flagged by ./scripts/kernel-doc -none -Wall
Thanks!
> + */
> +static int fwnode_reset_phy(struct mii_bus *bus, u32 addr,
...
--
pw-bot: cr
next prev parent reply other threads:[~2025-10-15 17:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 13:45 [PATCH v2 1/4] net: mdio: common handling of phy reset properties Buday Csaba
2025-10-15 13:45 ` [PATCH v2 2/4] net: mdio: change property read from fwnode_property_read_u32() to device_property_read_u32() Buday Csaba
2025-10-15 13:45 ` [PATCH v2 3/4] dt-bindings: net: mdio: add phy-id-read-needs-reset property Buday Csaba
2025-10-21 20:10 ` Rob Herring
2025-10-22 6:43 ` Buday Csaba
2025-10-22 9:15 ` Buday Csaba
2025-10-15 13:45 ` [PATCH v2 4/4] net: mdio: reset PHY before attempting to access registers in fwnode_mdiobus_register_phy Buday Csaba
2025-10-15 17:04 ` Simon Horman [this message]
2025-10-16 5:20 ` kernel test robot
2025-10-17 7:33 ` Buday Csaba
2025-10-17 14:40 ` Andrew Lunn
2025-10-15 14:02 ` [PATCH v2 1/4] net: mdio: common handling of phy reset properties Buday Csaba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aO_UKlH-Zxl1tq3W@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=buday.csaba@prolan.hu \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®