From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8D2C31812E for ; Mon, 27 Oct 2025 17:55:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761587757; cv=none; b=ZQ8qT6N521o1Hafm4iN+yVTdu5aP0t5w+ZK5+FsXBMcCDlZc7BgXjLgZH9jV8MWNmeUDXwMSxoFj3khjAIFo61wysL6GmrsV8v71ZzCuuWH/UC7miAufmxxONHXjDgP4Noz9e/h//DPwytQAbxSs4zKIMjLV7idH8y2UkSJQvHA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761587757; c=relaxed/simple; bh=s0NTkuxgo9nTW1wwUPyDTmWbVEsjdGmA1omaFkoHwoA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ku+MvvZkpDBPEy9fsqR15aQV0QIOUTRsRshY/BblcvULhFVTHhPcz0URXYUSbRVWk9VdVRAhSXuOFg/ZRkgSgPgoXYfbx12ORlgsGKhP4aXhRGKuGzk0eBgQFjbXRwjOo3fIVfgAxHuajz95nZ9f8pkERDR2HuTSEzhNpyvwNJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NNv7Tnmo; arc=none smtp.client-ip=209.85.128.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NNv7Tnmo" Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-7861978aca2so1072437b3.1 for ; Mon, 27 Oct 2025 10:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761587754; x=1762192554; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=t90v++bIrJi1Md65JkXT8gm2ApX72FdJn0ubPYfRRrY=; b=NNv7Tnmo+Azwrh0iUS0X2c0KZzVe6HOnkbfCcP3tFCY4MGEDOpb3X4nL4ifDr45dA0 EUcN5oQ6VdOxfOzZLS54nVnP7eXTd1Jl7oUrQiNbUlz+b/vF5XilYSc2ERfpX/LW4dNa d9XEAbxlFydDrVh9Lps/H05SNJhrQxRcPXwmPu3Pgy8CAJlv18lbjo6Tfsb8O13GSxEP 6D4zYfFjd3xfcWtsB8QzTFIWhXKR74WsX6ZB9NNWoCHvGdf8QqJ6014YOcZ99tSrLIZu rfdOBSw9WQyV+L9HTcgBnzvs33YsBCtPg2Tt6crbteGRjvBwwpTbAoObyHN/kkBOPcbT /GFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761587754; x=1762192554; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t90v++bIrJi1Md65JkXT8gm2ApX72FdJn0ubPYfRRrY=; b=hC8G1sjrvNCdte0zLR0vuv2e3+OSvftjPoOtWQWjD53EqcLaobxRn/vRVeW/RFGHeB F6YYOi3vDXj093HF5ISEVbZRjP9mJBPTVO/PzIXrGLqncMBNxBs/8gXejpgUyZkrcswi X25cjduo3bL5s4dT472QYusfsdmHePA4NEM81rmcJp+TyxHFlA9wZbbTpzvmmKiJl+CU ceqOYpiFDpPnNi3MdICNEs5Wn1MewlW48ss224zlmJg3WiSc8x1ENmyYQsUklh0UkO3f AHd5adaTBSgrlz8hiXkLghHOT3qIDPdi+wbTsdsoabi/ZaCawb1BclChx9sHXFHaXvcp O4ug== X-Forwarded-Encrypted: i=1; AJvYcCWcDRiBr44rlUzWvukxOBlr9k8Kf1o2+F11x2dI7C+tfkVmSX/ildJnsyS7+OyEqzc5Hqi4el3IpmBeTVo=@vger.kernel.org X-Gm-Message-State: AOJu0YyPxdroGeDPIboqloBe4q1Zq2x7lmzLjGRYxb0xsX++srRQGNjT /uv0jhWjNAkR4fy6Z+sWCywRWGZCbhvIgRjRRFdPTMz2fZ2Y4ESb8d3j X-Gm-Gg: ASbGncsLFdWRs45ZiP31d0Dz52/Y1wWYgeGu1EZB2QyHghdl0bBJLJeRmZZASyYmk6v O0HhXEzynTMAUFqSI0Y6k8Sbi8Biz6EMnENapKtP1JRst8Qobc13BMd1myWQ7C5aa7QC63Y+PDH PzPXLfNslBHsywQWVCWFfLdLs3QM2gZVtnvf73nRqsb0QoDN5YhIspxmSid8ADprDhl5kHWF5E9 z+sY5oX20oNVHdggaJ+CxG2Ooy4JNUnrQtW5XWG8Du/0rOPEaaBkamH02tx54jI0r2apSF43Jnk cnrrSi2aomLzEZa2sKJ1ozIRKMpp9BLGZK/L9YemsePAWOLWtdSIhr/o7KnoNGAUmmdSkNS/Z92 D/CuVusKH0CVLUREk6GBMycYh0UPZonQx3b4LlRT82HmoZFkU0xHaUcvUXVkm46hrB7TuoCerBy guOuqnR5A7twMQhvkn44mDwxuTyf3qVXzfPB9SEkaQQf5G7jU= X-Google-Smtp-Source: AGHT+IEnq7T6tW6sESfh2/pS/VtVB6j5wsUZrO0cK7EA3RoMmtv5EedE7kUOtkxVYgtnLyJeX69FZg== X-Received: by 2002:a05:690c:3510:b0:781:64f:2b74 with SMTP id 00721157ae682-786191bda08mr3102477b3.29.1761587754496; Mon, 27 Oct 2025 10:55:54 -0700 (PDT) Received: from devvm11784.nha0.facebook.com ([2a03:2880:25ff:59::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-785ed1f2457sm20784977b3.58.2025.10.27.10.55.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 10:55:54 -0700 (PDT) Date: Mon, 27 Oct 2025 10:55:52 -0700 From: Bobby Eshleman To: Simon Horman Cc: Stefano Garzarella , Shuah Khan , Jakub Kicinski , virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Bobby Eshleman Subject: Re: [PATCH net-next 02/12] selftests/vsock: make wait_for_listener() work even if pipefail is on Message-ID: References: <20251022-vsock-selftests-fixes-and-improvements-v1-0-edeb179d6463@meta.com> <20251022-vsock-selftests-fixes-and-improvements-v1-2-edeb179d6463@meta.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Oct 27, 2025 at 04:48:28PM +0000, Simon Horman wrote: > On Wed, Oct 22, 2025 at 06:00:06PM -0700, Bobby Eshleman wrote: > > From: Bobby Eshleman > > > > Save/restore pipefail to not mistakenly trip the if-condition > > in wait_for_listener(). > > > > awk doesn't gracefully handle SIGPIPE with a non-zero exit code, so grep > > exiting upon finding a match causes false-positives when the pipefail > > option is used. This will enable pipefail usage, so that we can losing > > failures when piping test output into log() functions. > > > > Fixes: a4a65c6fe08b ("selftests/vsock: add initial vmtest.sh for vsock") > > Signed-off-by: Bobby Eshleman > > --- > > tools/testing/selftests/vsock/vmtest.sh | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/tools/testing/selftests/vsock/vmtest.sh b/tools/testing/selftests/vsock/vmtest.sh > > index 561600814bef..ec3ff443f49a 100755 > > --- a/tools/testing/selftests/vsock/vmtest.sh > > +++ b/tools/testing/selftests/vsock/vmtest.sh > > @@ -243,6 +243,7 @@ wait_for_listener() > > local port=$1 > > local interval=$2 > > local max_intervals=$3 > > + local old_pipefail > > local protocol=tcp > > local pattern > > local i > > @@ -251,6 +252,13 @@ wait_for_listener() > > > > # for tcp protocol additionally check the socket state > > [ "${protocol}" = "tcp" ] && pattern="${pattern}0A" > > + > > + # 'grep -q' exits on match, sending SIGPIPE to 'awk', which exits with > > + # an error, causing the if-condition to fail when pipefail is set. > > + # Instead, temporarily disable pipefail and restore it later. > > + old_pipefail=$(set -o | awk '/^pipefail[[:space:]]+(on|off)$/{print $2}') > > + set +o pipefail > > + > > for i in $(seq "${max_intervals}"); do > > if awk '{print $2" "$4}' /proc/net/"${protocol}"* | \ > > grep -q "${pattern}"; then > > Hi Bobby, > > I agree this is a problem. But I'm wondering if you considered > moving the pattern matching into the awk script. I'm no awk expert. > But suspect that would lead to a more elegant solution. > I bet you are right. Playing around with awk, I find that this seems to work: $ pattern=":$(printf '%04X' ${port}) 0A" $ awk -v pattern="${pattern}" 'BEGIN {rc=1} $2" "$4 ~ pattern {rc=0} END {exit rc}' /proc/net/tcp && echo FOUND I think it beats doing the save/restore on pipefail? Best, Bobby