From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 887652D238A for ; Mon, 27 Oct 2025 18:01:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761588101; cv=none; b=nRL7MjPZ/jeRtDEwQezHz03AdiBwyqxr3yqS22JMhuZNzXDkXVkK70Vw2AwL6qO9kahfp+Nkgf2D/QmcIW9Jr+w7csIzVS0jph6BOezBQRWyzdaDhF6ro8+jLMiPX+LjxN0a1uqnS8Xqi+sWvZAO/tvi0+7SG0U7o+U85XBy1oA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761588101; c=relaxed/simple; bh=F+dHEiFLnh8A5KzJ58bksVScGa0jeuzf/tPIICsdU6E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DuT5ydU0u8Apuy6q7x9kxIBZszgn2NgtbuVQyWdsQgKUVQ5qGM7Gk4pYhmp2BgJrbBuMiVW4TC7tPFUDE53EpzO55tAQVqWSMYuj63sKD0XREnis/Uf+4qPT+fgEskQ3V/wP6PTM6CuH3Iy8KyvxxKJkeHdcFY39hc0BHyQudXo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O6Cx6GGS; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O6Cx6GGS" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-784807fa38dso56957887b3.2 for ; Mon, 27 Oct 2025 11:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761588098; x=1762192898; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BiovYXP3PtaA9Kfj7XU3nz29JiqSsYJIIOo4G6t3ivA=; b=O6Cx6GGSJIbiI2nx+yk+XY+6BIUZ60igmRyRnixex/8rG+NRQXEQ7mt9+dHbkKPida BMChyTjviwcfxMxqNp+wP4i7iO2D7FWRgC6MaZR7/GqQ6KYGC37nvhB/MRCmY58teC8w sztrkM+/oQORh7mDIDZ1gFI823xwKucQ4cdAyazgCqwWGNXR1nI9HJ5PqYY3tZ9p1yNz 5cZEOeQLJ8Rz2CZ+7avlKRQFpW2Wax5/oJElUYrPpxAeVuEg6YqGBi5nanESCKYoYqGw b9ZITqXUzv0m+7aQ269qHr7ppIWhhRoNPZHlMjBDPwfnqyI5mQLDUBiXVcLb/hg4Nn9D mDOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761588098; x=1762192898; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BiovYXP3PtaA9Kfj7XU3nz29JiqSsYJIIOo4G6t3ivA=; b=gSE1D09S9NDCGeWQO7UKX+lSiqnc3s81WuwtkDnaxDqL/RB5wojgC9Env4iHD0t0zT FMLPppDZXUWSrliQw8SSVo7xV8cGJZZNtDIMWIgdtlT2anRAj2LIYRRwLPc+FGvk879I frDVEMOC02qyhBO0nUoVWiv5l3A1aUgH11Y5bNCn+igDTAGTkSQIaMIGP0cRVQqag5qo 2/zln6lD1sn4j3gC1y2vSsFBfWKs3JDplYw4yAAnHuV/r2vg1AdqLN/8kTk0weOsymPW s7pHlStwVulPfYx8CTVvgyLwFuKrFjAKczNS16UOSmrXiyjeRKMn1EHJAx+ioIjyAhfk rHtw== X-Forwarded-Encrypted: i=1; AJvYcCVkLWRiHEdJ2zgyoDORG+AuqFJbxHdtTIaBTpDVWT7CWKeQfcP0FMrcbMv3b6LxSZXrOPV4+efstmOtjiA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx52vqiufzwNm1uGFSgh9PXi89TEcf6kdON3bpEO8apN6mAj5+2 +Z9X9m+3riURQ0gzRQev98IJPxvbuDY7CoebAg/RIRDlASguhJfa2VGD6mX8ItIC X-Gm-Gg: ASbGnctKWffYNOXRmCQzfflH6Bby/ZuxyBD2m2e/JJrNGk3wnXHYl103/B7CUzoCBAd Ti8AoT1+blEePcirtwIEXDuaekwsfDvVotMybpCOU1tK7Dw4NJ4JoDWwSvRGQWvsLs8Kb0f5MfW 2JNPnPNmfuxmg8+vjJbTYNNSDZ9iHAju6uG3CsumuF9lI5pymiMx3CqqsNQGEEZ0lxNpva6HmMQ ezKs9Go7PTcLgI2DiSEBcYrJvmozuxpwUHc2QWNYQ8KSkd+CJl2csF+wZaX037vxlS4nnl2AfLH s8FybJu/q5Q5qPwuvYPhs8fGvqUYqSDP/JJgL3ojwinri+6wFykZrL9f1fpktEVdVub/CIpNX8E qua7SZWpoiq3PymGFj7S5j6gNaXxRR0QCgfPjk4XnKkZ3s+X1gYYbauJ7kWXHF2/ZKR4xo714TA zpo5cHyVF9e72Mx7e8SUS9BAvTeQEyt0SSaqQ3 X-Google-Smtp-Source: AGHT+IGY7m5xCBIjhFzMJJMeIr2LMm+2g2vwUGpyuiJ3FoHQ+eVB5BYIwqC2NkP1JlPdGSmbLHfPDg== X-Received: by 2002:a05:690c:ec9:b0:785:bfd8:c4c0 with SMTP id 00721157ae682-78617e03ba5mr7395497b3.4.1761588098317; Mon, 27 Oct 2025 11:01:38 -0700 (PDT) Received: from devvm11784.nha0.facebook.com ([2a03:2880:25ff:70::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-785ed1c875bsm20767397b3.46.2025.10.27.11.01.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 11:01:37 -0700 (PDT) Date: Mon, 27 Oct 2025 11:01:36 -0700 From: Bobby Eshleman To: Simon Horman Cc: Stefano Garzarella , Shuah Khan , Jakub Kicinski , virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Bobby Eshleman Subject: Re: [PATCH net-next 03/12] selftests/vsock: reuse logic for vsock_test through wrapper functions Message-ID: References: <20251022-vsock-selftests-fixes-and-improvements-v1-0-edeb179d6463@meta.com> <20251022-vsock-selftests-fixes-and-improvements-v1-3-edeb179d6463@meta.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Oct 27, 2025 at 04:58:02PM +0000, Simon Horman wrote: > On Wed, Oct 22, 2025 at 06:00:07PM -0700, Bobby Eshleman wrote: > > From: Bobby Eshleman > > > > Add wrapper functions vm_vsock_test() and host_vsock_test() to invoke > > the vsock_test binary. This encapsulates several items of repeat logic, > > such as waiting for the server to reach listening state and > > enabling/disabling the bash option pipefail to avoid pipe-style logging > > from hiding failures. > > > > Signed-off-by: Bobby Eshleman > > shellcheck has some (new) things to say about this patch too. > Could you take a look over them? > > ... No problem, will do. Thanks for the reviews! Best, Bobby