From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 747141F91E3 for ; Wed, 15 Oct 2025 23:58:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760572688; cv=none; b=jZbqkcQ8GM4crpvkXor86YSv0WMIGoFE2e7/mMlksf2b8zmLAPkQA0xlBpW4Bpac1Z3iB4nwRxImt3zWRLze0FEOAuWh2Gr+LYQVSp9RVWEwmV5a9PVTWct1OexjW5Sf3Y2tZyAY+iqp3zl9D1MQytZAL/AVaibzkfqmc5hMDj8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760572688; c=relaxed/simple; bh=u8uiznWCVqnREUf+CXO4AJ4aXCu7jmn3pb4tv4zAwj4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P97tX5UPE1YXKbOp9kkf+54UOSrSWohRRito6OrOfweyp+A9kgEMM9iCN9GzqO60pGrJ636QmYu8L3naJcxScVt2rF8aTVXgmgwOSvAGtqEhiZUWbeAtjNsUTrfvWyGGfeCj0so9X0ys6gfQ/z2Hjh3fpsiwhhCQ/hejn/Z8ftY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XjtI9mlx; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XjtI9mlx" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-27c369f898fso2125535ad.3 for ; Wed, 15 Oct 2025 16:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760572687; x=1761177487; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kTdhM5dq4qUOwln9YvvCvYcbtpAId+tRa1KojSh33Ug=; b=XjtI9mlxHcxfCYAc0v8bH736hWP8PgdY1EZQq2al1cPk9XQ8MTB2V6afD+ezD8CaAL Yhkrw1XX7R9eRwFND/FhXAShDN0cKezz/19NYe/kbMOhuSvJt4eFoLrlwltqpxCguVtP US6GSDeCehweMYJd4FO4Wq0aJv6vpHjR5lZemf4pYkTHGZNn4kUS8MzLnVAvZ/4SPBLZ OTrCkbGCpDp7MINdf8hDPD4IfrmSnpEWbqur+rB0a+xwUo1fPC570Mw4qfZnxKCL8SJ+ yP0+M8NlQKLc9Ik1sJkrl9QxnaY8qhTjm18/86ApZQ2GiqG+qMc7Y0AJke6e9gMAFa27 7z5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760572687; x=1761177487; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kTdhM5dq4qUOwln9YvvCvYcbtpAId+tRa1KojSh33Ug=; b=hh45l6/w/d9Etf/P2xlkocrj9aeGTKTOPosQ5De6gMOkUBIKNyQmbw4MB89T/sfcG0 IbGW2aGfhSJ1yorjh3vkTm67piTlMD2wQ23ShknCR4DrJL7TJMy8FmFgTUKqE2nvyA7K 46sNvEfrwqlDlNs8xQLMCuvjsYNBy61w5e0AU70jYDCbUsqRWq444J5goYTvuh7Y+gXX lNLUmmfecWy2ggHdQ+CQhLELy2bwBH99Cw/a+2i7Ags0RWMRK8piGZ1AhakAHL/Ef6L7 PjJ8inJED2m2sTzzFrxLbLjDhkg7OVwxFtYUacde+ntuhnIOnLe5STaUUhovmWhd1aJH TYqQ== X-Gm-Message-State: AOJu0YytjVvPKV5Jkm24Z4EV8LR6/l2vOWtJIf2Kx8QQXpKECzx8kbcy 8VCNsvK8Ti+PAdwQ3H6DtvYGqgeKPDwfOy3B9Fug75JAeXOoItMknWZJ X-Gm-Gg: ASbGncvpNWTTGNDEKq/yy6gObkWb1qsANkS2zvGPBj7xd2XVL/IrTAhdp5PwnGzFYPv 0kWiWThk9PwtyENFk/FckFvf8ju8u8QRDUJueRfyiYPjU4K1lNg5e5OKO30jMvtMYf5Xrp8Eqso ClxXnB2v18Kbjyt4Wuo/to4OkO449vMGZ2/LizIZ/ToGhKq7mAkQWOq6hjPspflK6FBMESaVEx/ u6fg0b+U6OOdplbWMWBw5N8bm03kYmR9WXmE5Pc+j+e8nR1YQ5jILjByJpAs02eF8ZQE8Xn9PdK Mth8D6VTT1GE04+NHjE2CxWGz6X9RucIKgWNrAtOGvUZELmfX6eyY/gViDwoPyPttwtzS/zd5fX 0p2khk3VQZzSrG1YHCVPfAN98GuyCEdumSK9XjpuJ3qaupiIpyDermod7EEBaB4TiAcTPvUHBX6 d9uj8= X-Google-Smtp-Source: AGHT+IHAUXKf9omA7q8TkGJJHfP4J+1Abke/cJs4eEJgCs6mDtovqt2QgeF6g2Mw5XNJRdEPCf3CUA== X-Received: by 2002:a17:902:fc4c:b0:276:bbd9:4593 with SMTP id d9443c01a7336-290272c1a4cmr361189585ad.33.1760572686460; Wed, 15 Oct 2025 16:58:06 -0700 (PDT) Received: from archie.me ([103.124.138.155]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-290ad0004e1sm48585ad.7.2025.10.15.16.58.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Oct 2025 16:58:05 -0700 (PDT) Received: by archie.me (Postfix, from userid 1000) id BDBD8420B701; Thu, 16 Oct 2025 06:57:59 +0700 (WIB) Date: Thu, 16 Oct 2025 06:57:59 +0700 From: Bagas Sanjaya To: Simon Horman Cc: Linux Kernel Mailing List , Linux Documentation , Linux Networking , Subash Abhinov Kasiviswanathan , Sean Tranchetti , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Sharath Chandra Vurukala Subject: Re: [PATCH net] net: rmnet: Fix checksum offload header v5 and aggregation packet formatting Message-ID: References: <20251015092540.32282-2-bagasdotme@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZHKkadDGbrovTJ8O" Content-Disposition: inline In-Reply-To: --ZHKkadDGbrovTJ8O Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 15, 2025 at 05:31:53PM +0100, Simon Horman wrote: > I would like to add the following, which I noticed during review, for your > consideration. >=20 > diff --git a/Documentation/networking/device_drivers/cellular/qualcomm/rm= net.rst b/Documentation/networking/device_drivers/cellular/qualcomm/rmnet.r= st > index 6877a3260582..b532128ee709 100644 > --- a/Documentation/networking/device_drivers/cellular/qualcomm/rmnet.rst > +++ b/Documentation/networking/device_drivers/cellular/qualcomm/rmnet.rst > @@ -27,7 +27,8 @@ these MAP frames and send them to appropriate PDN's. > 2. Packet format > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > -a. MAP packet v1 (data / control) > +A. MAP packet v1 (data / control) > +--------------------------------- >=20 > MAP header fields are in big endian format. >=20 > @@ -53,7 +54,8 @@ Multiplexer ID is to indicate the PDN on which data has= to be sent. > Payload length includes the padding length but does not include MAP head= er > length. >=20 > -b. Map packet v4 (data / control) > +B. Map packet v4 (data / control) > +--------------------------------- >=20 > MAP header fields are in big endian format. >=20 > @@ -80,7 +82,7 @@ Payload length includes the padding length but does not= include MAP header > length. >=20 > Checksum offload header, has the information about the checksum processi= ng done > -by the hardware.Checksum offload header fields are in big endian format. > +by the hardware. Checksum offload header fields are in big endian format. >=20 > Packet format:: >=20 > @@ -106,7 +108,8 @@ over which checksum is computed. >=20 > Checksum value, indicates the checksum computed. >=20 > -c. MAP packet v5 (data / control) > +C. MAP packet v5 (data / control) > +--------------------------------- >=20 > MAP header fields are in big endian format. >=20 > @@ -133,7 +136,8 @@ Multiplexer ID is to indicate the PDN on which data h= as to be sent. > Payload length includes the padding length but does not include MAP head= er > length. >=20 > -d. Checksum offload header v5 > +D. Checksum offload header v5 > +----------------------------- >=20 > Checksum offload header fields are in big endian format. >=20 > @@ -158,7 +162,10 @@ indicates that the calculated packet checksum is inv= alid. >=20 > Reserved bits must be zero when sent and ignored when received. >=20 > -e. MAP packet v1/v5 (command specific):: > +E. MAP packet v1/v5 (command specific) > +-------------------------------------- > + > +Packet format:: >=20 > Bit 0 1 2-7 8 - 15 16= - 31 > Function Command Reserved Pad Multiplexer ID Payl= oad length > @@ -169,7 +176,7 @@ e. MAP packet v1/v5 (command specific):: > Bit 96 - 127 > Function Command data >=20 > -Command 1 indicates disabling flow while 2 is enabling flow > +Command 1 indicates disabling flow while 2 enables flow. >=20 > Command types >=20 > @@ -180,7 +187,8 @@ Command types > 3 is for error during processing of commands > =3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > -f. Aggregation > +F. Aggregation > +-------------- >=20 > Aggregation is multiple MAP packets (can be data or command) delivered to > rmnet in a single linear skb. rmnet will process the individual >=20 I think that can go on separate net-next patch. Thanks. --=20 An old man doll... just what I always wanted! - Clara --ZHKkadDGbrovTJ8O Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCaPA1BwAKCRD2uYlJVVFO o5njAP9fbcZqLKiQ5Y2DAGi8x1JQMAtVAV+fbBnd60BnvnMaxQD+L7adTKlkQ7JC fKo24/DpTLZ80pQ7KyjMcqGuJELo/A0= =1UZq -----END PGP SIGNATURE----- --ZHKkadDGbrovTJ8O--