From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Ma Ke <make24@iscas.ac.cn>
Cc: bingbu.cao@intel.com, lixu.zhang@intel.com, mchehab@kernel.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH v6 RESEND] media: pci: intel: ivsc: improve device reference counting in mei_ace driver
Date: Wed, 22 Oct 2025 12:55:24 +0300 [thread overview]
Message-ID: <aPiqDLFcnOm4qu1Y@kekkonen.localdomain> (raw)
In-Reply-To: <20251022092545.4640-1-make24@iscas.ac.cn>
Hi Ma,
On Wed, Oct 22, 2025 at 05:25:45PM +0800, Ma Ke wrote:
> Put the reference to csi_dev acquired during driver probe in
> mei_ace_setup_dev_link() inside the same function, instead of during
> driver unbind in mei_ace_remove(). This can be done as
> device_link_add() already takes a reference to csi_dev.
>
> Found by code review.
>
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
> ---
> Changes in v6:
> - modified the commit message as suggestions;
> Changes in v5:
> - jumped to err instead of err_put to avoid calling put_device() again in err_put as reviewer's instructions;
> Changes in v4:
> - updated the subject as suggestions;
> Changes in v3:
> - deleted the tag of Fixes and CC, and moved put_device() to immediately after device_link_add() as suggestions;
> Changes in v2:
> - modified the put_device() operations and the patch title as suggestions.
v5 of this patch has been already merged with a modified commit message;
there's no need to resend this anymore.
--
Kind regards,
Sakari Ailus
prev parent reply other threads:[~2025-10-22 9:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 9:25 Ma Ke
2025-10-22 9:55 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPiqDLFcnOm4qu1Y@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bingbu.cao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=make24@iscas.ac.cn \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®