mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Andrea Righi <arighi@nvidia.com>
Cc: David Vernet <void@manifault.com>,
	Changwoo Min <changwoo@igalia.com>,
	Emil Tsalapatis <emil@etsalapatis.com>,
	sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 sched_ext/for-6.19] sched_ext/tools: Add compat layer for kfuncs using struct *_args
Date: Thu, 23 Oct 2025 15:12:25 -1000	[thread overview]
Message-ID: <aPrSeQ9560YjwXlB@slm.duckdns.org> (raw)
In-Reply-To: <20251023080130.76761-1-arighi@nvidia.com>

Hello,

On Thu, Oct 23, 2025 at 10:01:30AM +0200, Andrea Righi wrote:
> +#define scx_bpf_select_cpu_and_args __COMPAT_scx_bpf_select_cpu_and_args
> +struct __COMPAT_scx_bpf_select_cpu_and_args {
> +	s32 prev_cpu;
> +	u64 wake_flags;
> +	u64 flags;
> +};
> +
> +#define scx_bpf_dsq_insert_vtime_args __COMPAT_scx_bpf_dsq_insert_vtime_args
> +struct __COMPAT_scx_bpf_dsq_insert_vtime_args {
> +	u64 dsq_id;
> +	u64 slice;
> +	u64 vtime;
> +	u64 enq_flags;
> +};

I think this makes the inline compat wrapper to always pick the compat
interface as it'd do bpf_core_type_exists() on the __COMPAT prefixed type
name which doesn't exist in the kernel.

Thanks.

-- 
tejun

      parent reply	other threads:[~2025-10-24  1:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-23  8:01 Andrea Righi
2025-10-23 14:03 ` Emil Tsalapatis
2025-10-24  1:12 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPrSeQ9560YjwXlB@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=emil@etsalapatis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®