From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2600B2EF654 for ; Fri, 7 Nov 2025 02:44:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762483446; cv=none; b=TJK4rOZ49nAOripUvqYZDpS1fn0DiDyo6pQFwpzvvL1empzu00uOucRiL5hM2fAaTbRRWSizgpIvyamEcVHMY3BfUGb9BluqQKwBUvsuqsj2nEjHpnNOimuQR1Yt7m+Y5zipaQjfZkfO/Iut9WW+nLN1L8ehKVzDZZ6SPY0eVw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762483446; c=relaxed/simple; bh=f0zO8wvgQhxW3NMqX1Rfvdtn5DxNIhGdOq4ogpGv4Pk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZCxOsarNkyHsGpDUstHE3jZaF1vNT2b27xyeTWgfMQX6xBTH0hOmnLE4O+crC7FW51V3wJq1JcjfC1YGOXca9qF/71NbRPT99tpfTEY9bO0NjpiIMFk018eCZoGAnOPAByXCBMTjkTaYkZjTZnGm/2ocf6WoKeQVeDIvZzc5EX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BlHBFQLh; arc=none smtp.client-ip=209.85.160.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BlHBFQLh" Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-3c9991e6ad1so189926fac.0 for ; Thu, 06 Nov 2025 18:44:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762483444; x=1763088244; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=tQJFO3d01XRWHlItzAgkgKpAHFmrqaV2k8tk3VC7Qsk=; b=BlHBFQLh/UZuO1Vd7TyJbmQiWmsQH5fEz+JdpMIVwmNjuTfmB3USdPmo577ml5MDX9 RNQC+4Q5khFuY7fzTzOwH5JYMlMUFoc7YQfO8Y2kYnvV1CrYlc7lSkSpKg+HSZqXarGf eFXLnmVP0zZ1FsTpG7OaknTglg5nDP2UbclVZ37b7DGOs6TKfhV3tpKAGsy4S4bhg1ua 1Z9c7IV5hvMua0/rZqdBpdIZgmM8E7+n7WIUMd4KGshnXYduPSskKUMVQ9ZfE68pBP9i V+nxtdXpvJBrmGIIwZn2o8GfefHsHbbzj3F3dasldmLjH+KX1y587ZPd/mCXGlQv8SJk DXcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762483444; x=1763088244; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tQJFO3d01XRWHlItzAgkgKpAHFmrqaV2k8tk3VC7Qsk=; b=QJT0PCJySq7whkhKpo08y2hmlF5tAEqGaREXukySE+XaKT3e1WTjBAjp1WN/Y7tsqB ua02zCGBjm99yo48xcCKkWzBygAptaYioxhoEjgaE97CoFEffUNAay5sBZtyf6c6VJlg Y6sf9YS9iFW38ojbCNxMFB34MMKE0DIN5M0zbI64Cabm0O9KF1NxOoj0nda8TZdv4llH 5ciiiWqxWW96+Z24uEK+8knUBs2VkoKevnUkqH+hgzeBXEMIG9KyLNoUpTFFcj0l8DSt ZVJw20jMMroFDRrs6QAZ3myNopt8d3NYUHyfIaWwfYdytFxbAwZce0uYoP889gpLeD78 jfMw== X-Forwarded-Encrypted: i=1; AJvYcCUjPkloFT46hi8bGdjX3eSkkExKcA939hb/gscO5JzTGP+hfEx9WCzaWAfCyECBdNJrstuJblWuGzWVBBo=@vger.kernel.org X-Gm-Message-State: AOJu0YzM4HcRjEGh7lfqsQDZX85v1wMVhN6/XoxLavL67Lv1/ic3WY3f RwXxuMrcrOnhu5EDeYS5kipMsLLj6JQ06cKCKC8wrPkUf0hyRaRkrA6N X-Gm-Gg: ASbGncuEU54l/6X26SI62B1nIa/0w+zgYJELCVgnr0c0A0bnJo92p2iiAFNKgkqZedi KV3ZsOfMO+iUGc/kcROeXDsr8sxJbIQIyxEIVeorNhC9UyhOO2U6ZmdTj3nXZ4iwJ0p7U18JKIS D7jHVtqxC3KyxH/Fb4DkjOR9weMN6LCSAahSfrmlQFHmeerdfp/JvUmZPvWOYG1cTDKbxnRieXk e1SuH/lJtDYKnuc2PB6EcDhItCXsZOO4XVAU3Jv3t0AXZ097cDqMNjf2+8jk51dVUjpl9ybNDPb G8+YVy3iEaik8AWjADxz4GUVDI/udRdzKoopZerzkIcOO+Hh5c2M2ohpVclbOf8d9Buv8kRk6BD tJgbHidLnAxlokKHEH3rZyLDVI4RC9/kaBv5FehqxFqjQJgzW40VV6p1/hfxZug== X-Google-Smtp-Source: AGHT+IFD2D//hG6hBMCeFSWKnWdmScBR8+/9DZwOHc0uXkeVWeA8HfOnZLz9J/lfwgpLyio/zbkAWg== X-Received: by 2002:a05:6871:51e7:b0:3e0:aec2:8b50 with SMTP id 586e51a60fabf-3e42aba92a0mr60346fac.22.1762483444119; Thu, 06 Nov 2025 18:44:04 -0800 (PST) Received: from geday ([2804:7f2:8082:6c9::1]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-3e41f1ec269sm760868fac.20.2025.11.06.18.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Nov 2025 18:44:03 -0800 (PST) Date: Thu, 6 Nov 2025 23:43:57 -0300 From: Geraldo Nascimento To: Shawn Lin Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski , Conor Dooley , Johan Jonker , linux-rockchip@lists.infradead.org Subject: Re: [PATCH] arm64: dts: rockchip: align bindings to PCIe spec Message-ID: References: <4b5ffcccfef2a61838aa563521672a171acb27b2.1762321976.git.geraldogabriel@gmail.com> <67b605b0-7046-448a-bc9b-d3ac56333809@rock-chips.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <67b605b0-7046-448a-bc9b-d3ac56333809@rock-chips.com> On Wed, Nov 05, 2025 at 04:56:36PM +0800, Shawn Lin wrote: > 在 2025/11/05 星期三 16:18, Geraldo Nascimento 写道: > > Hi Shawn, glad to hear from you. > > > > Perhaps the following change is better? It resolves the issue > > without the added complication of open drain. After you questioned > > if open drain is actually part of the spec, I remembered that > > GPIO_OPEN_DRAIN is actually (GPIO_SINGLE_ENDED | GPIO_LINE_OPEN_DRAIN) > > so I decided to test with just GPIO_SINGLE_ENDED and it works. Shawn, I quote from the PCIe Mini Card Electromechanical Specification Rev 1.2 "3.4.1. Logic Signal Requirements The 3.3V card logic levels for single-ended digital signals (WAKE#, CLKREQ#, PERST#, and W_DISABLE#) are given in Table 3-7. [...]" So while you are correct that PERST# is most definitely not Open Drain, there's evidence on the spec that defines this signal as Single-Ended. Thanks, Geraldo Nascimento