From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A28A32A3C1 for ; Mon, 27 Oct 2025 23:33:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761607984; cv=none; b=gXLax9s+3ILuXd/o+DgYJaXvbldDTFNPHhX3gVm8tvSH36xBcmA64wV2gQ4dWyYB0Lsp8jYYcTW00wdnr4p27xTscuvWMTv/9nU003MxTISMQK5JU8FcHH5SHeSpfXuHssoMvxMQbGjOGx/VMW88jh72DqulJ7TOTySDrQPaAjo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761607984; c=relaxed/simple; bh=ya34dnXBkVMZ4acUVB749ZaVXuLYyX25Ei5hDiCldOk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y8U5RxEX2hNy+nhxccupXOPEjfphmu5Ea+i9qV+cZCKk/o6THrSIoCYMNRrbcpB1dO1uMC5/ZFaUX1DnkcMVxUETofXLtsBAvPW8y52JaTfezVueLe2HuoxJxPa+kLZe4qChjSGvR9wh3M/4BJ+hjawk2kYdh1mHjfaFK6kxopU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=XPfEVKpA; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="XPfEVKpA" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-81efcad9c90so63849916d6.0 for ; Mon, 27 Oct 2025 16:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1761607981; x=1762212781; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SeBkBGZ09M3QB76OpujQtXgjWBBtrpYzqcpEmFvCTi4=; b=XPfEVKpAkz0EqqJlblUgrQ2PbfAJJwC+FFil/Vd5htXfHTtIAt0AcJCsl4NmBxKXRJ eIW5UeA7107giYfaQifJ5a/gcKAR8VZ9z0golFJy5Hb23kycJSDDiGo9zpEv9kL7Qk7s w7zRqTxUMrIW23T1nvKpH2c36Y7Gmc+zKGLLJpUtGCt5fPfRM1WTsbfA/tTdW9nn2aUs ftNj7HpeKguvAOHG0jEjFwpWYouZrm59oAzF2CNPOw8w7oeCkLSrBScDF73Fz4cxKAC8 hjTanLd8/LkCYdg+DpDtdHCnEdUb1gxr4DzFdHDnJdW+eZ6Z/hxItchsfPdz1TLQ2R8w 4aIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761607981; x=1762212781; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SeBkBGZ09M3QB76OpujQtXgjWBBtrpYzqcpEmFvCTi4=; b=f+aHp6Zj+8c7ZOApiyKUoqZQAY7PYvHyyXoNi6yrUxFE1qAhj3M5MwI6X5Cm7YcW7d lQON09PdEHyf86vxrYZNiayrvIFsJmB9IkfCQfs0CWP1bgh6RMRdRSSdN608xIMuN/p/ jvTs8ch5kbt7JUVKB0CjpKgIgy5ESY72GM7OKU1hC0jRZ1A6Cavvk3iFXr2xcoLNSU60 aKwea9M9dCi4P7uCdC7LNh03nqPPsZCbnLjanRMtH+mc+yxMEfuUD5UkNbf/X2VRTqkq +tSQuib9+T65JpmuFXrgSF9eOtZMoYHJKSXjR63idh+7YIGiHN27cgPHTFjeuieOMRu6 ipUg== X-Forwarded-Encrypted: i=1; AJvYcCV+pkNgwIGL7CQKiIwTnEKyHuMV6NDYpqbqjxPuAwHGBYexSX9aHTYP1Ctzhl67vCbAyI5XIPlMToRk6Cc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+a0+7g1yB0ZZzDuIPcyVBHmsaRLEaHMBWpZ8E3pYkDJisqYZT Kmx4Rr6mOibcJ4z9+ZFLdSgk3Sn0aVy0kCn91p9DOE0UgJIW8Zv8aBF0lGnu75RF/w4= X-Gm-Gg: ASbGnct8DNw9l4nmh2C70YNT7GUe+5kV+RbqAnmUxT9U23NyIrDgwv37koDwbDtmshA w8ZACcyMlN5oRTPheDJZQfUvWHtnNcZ5mdfFYFOHiPYXlb42Ne5zVSJUI2VxDR6miDkwBG9fZKz RoKP8HB7fK/dmDnDDrMYbDF80xZW4OgGxhv/los/gLU9+EScd97ykPfKmUP6cmcChitfObiwdq7 FXFns1zcVriSeDLV4uxhOP61lqYqVfwCIFSuEcDSbXd+8vel4tsd9u3aMm/3iTCpfbW4D3BkA4y maQYHBL5uCZAXIm6FDSKqaHf6sDVcW68tksOQj8lssTjDNz9wadsFjXgEgZtGMKVfRvngHkKzYb tP6ih4+BwUclj5fbKn4mk8+wx3ve9gNFNm2nqzBjjIcyE7PLRbBIOWKkfmUbo2Upb3spyjdv1WZ A6cdD/6wUMRwr5NkXZxU8/vg8nFuDLM0GCsRIsHViYq4ow7R/vfChkjxDr7IM= X-Google-Smtp-Source: AGHT+IGY0mnN3CFDP7vaLRad7aeAt7RbVIUmDhfxoFPsiCMHR/zS0q6YLuuynQuqtuF/1igQEZd8Tg== X-Received: by 2002:ad4:5cad:0:b0:87c:2b03:c776 with SMTP id 6a1803df08f44-87ffb0f3094mr20891046d6.47.1761607981318; Mon, 27 Oct 2025 16:33:01 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc48ea92fsm64277606d6.24.2025.10.27.16.32.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 16:33:00 -0700 (PDT) Date: Mon, 27 Oct 2025 19:32:58 -0400 From: Gregory Price To: Jason Gunthorpe Cc: Lorenzo Stoakes , Andrew Morton , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Sven Schnelle , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Kemeng Shi , Kairui Song , Nhat Pham , Baoquan He , Chris Li , Peter Xu , Matthew Wilcox , Leon Romanovsky , Muchun Song , Oscar Salvador , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Pedro Falcato , Pasha Tatashin , Rik van Riel , Harry Yoo , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 00/12] remove is_swap_[pte, pmd]() + non-swap confusion Message-ID: References: <20251027160923.GF760669@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251027160923.GF760669@ziepe.ca> On Mon, Oct 27, 2025 at 01:09:23PM -0300, Jason Gunthorpe wrote: > > I'm not keen on is_non_present_entry(), it seems confusing again. > The confusion stems from `present` referring to the state of the hardware PTE bits, instead of referring to the state of the entry. But even if we're stuck with "non-present entry", it's still infinitely more understandable (and teachable) than "non_swap_swap_entry". So even if we never get to the point of replacing swp_entry_t, this is a clear and obvious improvement. ~Gregory