From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F9F42798E5 for ; Wed, 29 Oct 2025 01:58:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761703134; cv=none; b=tpPBzlFLMuBMHwijPik1JUAx0SHDeNNHh1TRMig09ONkdcF2Zpidz+mA3o2WbwCJ1FdhO8DnRU59MdYE/1+N5LG82b3D3MpqAG7N8vsYlMG/sBHu2gugACwS9fzVAY/437ITpFMknTpBQsyADID0NsRjP/6qLlhY+I35TgzEMSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761703134; c=relaxed/simple; bh=gEPztik0DarWvmLzMwy+9sVo0AjJ4WmJObG/Q41ZORY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RbdCXJ4A/xKmcP1KeejVSNR7RueC3ACFZ74DFdsUE8EPCy2/LRTd7FAzN1ZyDd5n+vuNkNjeXgCR7XNb89sPrhFhqW76eqBiFqF5HVUEi0dUvYf7eJPy+ZsLnXg2HrqRJGHDkyTTlJC0If8PXy8s+mK62J9Ybe+PL+ad1ta+iJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gk1piDNa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bp0EdDcb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gk1piDNa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bp0EdDcb" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 59SJm3ln2554005 for ; Wed, 29 Oct 2025 01:58:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=9IavgnA3wJTsxViY9YsmCRsi 9l8lOQx14IrwVBYaXOw=; b=gk1piDNaqjcYc7khLjvcbaS3hQHEM6gNLW0sgkjQ pasEx8zmvJnuk6HqMuOaPVxkCCwvLT3nAHjchhn6d7OeZFmC+4c/nzPUZH/V//PY 3s0R5jL/IFziOEw/YsxMufZ53+fGOzFfLLrhDlB73vXfW+sKa7+JGCoN6+mvB3tj SorUxQqWLkAng9r1RpqT1hhUHgghoDIsKO+4dLnHpaze3FkRzYjswAPRH700LHFv uNgotEe2RW/iBh/zWt2yKNJYhNoYJwtE8PFu4wl12UzlDfwdGX1fKuvGmheu0aiy 4loV4QLCExmB0qnma6zbGv2NqFU+ZD3QCId4xa0dC5lQpg== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a34a2gt4w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Oct 2025 01:58:52 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-87a0e9be970so197375716d6.3 for ; Tue, 28 Oct 2025 18:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1761703131; x=1762307931; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9IavgnA3wJTsxViY9YsmCRsi9l8lOQx14IrwVBYaXOw=; b=bp0EdDcbe863seAhEtHS6Zqcpuf6Y+moOGsIDnXoVyF51XObFg/zEfVflszwFix86F 384JsG0JjsK9BN+DPHD0bzYXtCZ6cKme1eRajtwZ0fOBLCyEwcSqGw1Vahd7jTvjBG3r q9eJxjqn93PbC4KksWFq3QaOcLWFJEwM+zumlY9jNlNs+G3k5lPpVhukXHyWzmHqMfJV tpJsM9YKKE/qcGl9+gxlffHHdYkitdeQmEAlASFwYlB+nFF71geBvde8Q03oB0JrzLoY JMNYsBJ5dGOGGHYKUlPcrfJ6Xy+vKUX3NK/IdjsVGGsAAHFHqwt48vOyB3E9pToCNoPB R3Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761703131; x=1762307931; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9IavgnA3wJTsxViY9YsmCRsi9l8lOQx14IrwVBYaXOw=; b=N4B9EvQJR79TJ2nGDufojlqBYJQHAO8y9+xB25Aa/+Q3XXC48fodnwz4aP3CidvP7e AYlNE6frEGpapMkwFD54qI1I4jX13ENLfyXTCMebcmuPM47cZ/33F4Mmbo6mxePQd1hc VKONKd2CvaNtpTDAxuKAjUVAkZP26MITmx9zHSsyQtlbztPFwavpQRNgt+N62iv0fkFN WCelrxAj/x0+bYTKh7w5rN+f/eFInq7GwVIY2apwzOZyUQepinuROKmsbIiRLHcLRUCG Z3BvyPAaksT2PMr0QTWHacWKZFovhBsSa4mauG55bh+Kmm5PxBD0mAV5R0NHNJsR+Hdo UEqQ== X-Forwarded-Encrypted: i=1; AJvYcCV6NwLFU2zTVr/92tZpG33n7QNO2UJW+7GZulXlO53PTzr2L+shY21RK8zS54G9A8oF/ZIWbFjCcBn0m8k=@vger.kernel.org X-Gm-Message-State: AOJu0YychAjC4EKE3MOA9XrtoRK8vds+QDgR2kaZFNtu/utyt+Q8l6tH RTcLdiIXgSSqIdB3QBqvUwsI7l4c+xDfjWdq5XQ5VhBr8a+rkxJWJODBua5eGTWx7M+OOk+oPpU vh+Q5HRo3s0yt62vYnPT66qGYgnYo0NfGEbnXbQvnGC878NTGXaRTyQL0zORyb0zv9rQ= X-Gm-Gg: ASbGncvM0CX4Xv5Egp5O5sZJp1v1YbeR7HOkqHqVnYNjbwSfubzy14wLH3uOphI1WQf mvMwnHYFY7+XLaO1Lnx6/5gERZu7vV57DgpieUjSVZHby38VXcNSuE9soIMCLX+xd36m0YsFVxr lN19iJPev4uvhTtZAIXX7aINmhFl+O/+UimYmFXb1PbFbBGxCqNYtk6IMOTFT0OexNh9JgmCx1A +JUluoorY53hPj/rqkxyyPlz+npP+09LOtnLJWszuHK/jueQQW0HHHZH/ar1io8Y+TqmhdGkbvA Tm1CFhV1YC7+71rnzlOtsYM1jnejyPd8qN4s4BqlJZM2bDAKUMIBSYFmKmbWxpU9vPaTWgiBzhb 48sUjls37+VfRdfReHK+zJ5JEl91nGN4Xva7kttzxMefGwZXrmKBKHmy2f0M+qGG/ X-Received: by 2002:a05:6214:242f:b0:87d:f2e9:488 with SMTP id 6a1803df08f44-88009acdd94mr15033576d6.11.1761703131475; Tue, 28 Oct 2025 18:58:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGDHmfG0LUjzp2Ek/MezF+lDC26fFhbmOLWFp413US458OqwG2FWmdGE+xxaaQJ07XpmM3Yzg== X-Received: by 2002:a05:6214:242f:b0:87d:f2e9:488 with SMTP id 6a1803df08f44-88009acdd94mr15033436d6.11.1761703131057; Tue, 28 Oct 2025 18:58:51 -0700 (PDT) Received: from yuanjiey.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87fc4944a84sm91522446d6.36.2025.10.28.18.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Oct 2025 18:58:50 -0700 (PDT) Date: Wed, 29 Oct 2025 09:58:39 +0800 From: yuanjiey To: Dmitry Baryshkov Cc: robin.clark@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, sean@poorly.run, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, quic_mkrishn@quicinc.com, jonathan@marek.ca, quic_khsieh@quicinc.com, neil.armstrong@linaro.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, tingwei.zhang@oss.qualcomm.com, aiqun.yu@oss.qualcomm.com, yongxing.mou@oss.qualcomm.com Subject: Re: [PATCH 07/12] drm/panel: Set sufficient voltage for panel nt37801 Message-ID: References: <20251023075401.1148-1-yuanjie.yang@oss.qualcomm.com> <20251023080609.1212-1-yuanjie.yang@oss.qualcomm.com> <20251023080609.1212-2-yuanjie.yang@oss.qualcomm.com> <4bnvh2ydtrmejknzpsxoalxoyjpq5g5cjbrico5ezbek24r52s@u5zy6ekh6lps> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4bnvh2ydtrmejknzpsxoalxoyjpq5g5cjbrico5ezbek24r52s@u5zy6ekh6lps> X-Proofpoint-GUID: yNIDslsoLDZ6xr2x65-dAjDYbjnr-tMa X-Proofpoint-ORIG-GUID: yNIDslsoLDZ6xr2x65-dAjDYbjnr-tMa X-Authority-Analysis: v=2.4 cv=PcvyRyhd c=1 sm=1 tr=0 ts=690174dc cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=kj9zAlcOel0A:10 a=x6icFKpwvdMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=e5mUnYsNAAAA:8 a=EUspDBNiAAAA:8 a=RHm5ZmmhJtTlhXRmaf0A:9 a=CjuIK1q_8ugA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=Vxmtnl_E_bksehYqCbjh:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDI5MDAxMyBTYWx0ZWRfX6c9UibX89TCb QWk0e4eEubcvQt83X/xaPnQO2AKsPPCCcjCZVj9cvL8RAXRoSQBHhkp5TUnH3oV9iiTSG3XxbkD xmulYEH4o3+zvNeQ7eXvhXmzXsOFnkA5PWFbvZt1IBxEXA21lLm3MKlBfWw6RmatgdNaqLRP3Hp 2ZqL3/ky7lZvnmMXBULj1R+idf2hH75RtfLeuspiCOcVVm8FRur3OgjIEygqvYmBNdKdsVe66YT rg2DNASMMQGCOK5sLbmiOLD99HgLzepfD9s//Knj98RerhJ9T+z8PV+2cHNmG5WzDghT9K4rsA8 2HMlSZf+8nFEODy2QcWkPc0du4OAffg9SdBAkBNR7NE7Hzy2wG73qOeCoKKrPV/j2vJD36Mxb8a BvljmP0DWInQ5T13G+khi3gi8tmFpw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-29_01,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 suspectscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2510290013 On Mon, Oct 27, 2025 at 02:22:04PM +0200, Dmitry Baryshkov wrote: > On Fri, Oct 24, 2025 at 02:00:50PM +0800, yuanjiey wrote: > > On Thu, Oct 23, 2025 at 03:14:38PM +0300, Dmitry Baryshkov wrote: > > > On Thu, Oct 23, 2025 at 04:06:04PM +0800, yuanjie yang wrote: > > > > From: Yuanjie Yang > > > > > > > > The NT37801 Sepc V1.0 chapter "5.7.1 Power On Sequence" states > > > > VDDI=1.65V~1.95V, so set sufficient voltage for panel nt37801. > > > > > > > > Signed-off-by: Yongxing Mou > > > > Signed-off-by: Yuanjie Yang > > > > --- > > > > drivers/gpu/drm/panel/panel-novatek-nt37801.c | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt37801.c b/drivers/gpu/drm/panel/panel-novatek-nt37801.c > > > > index d6a37d7e0cc6..7eda16e0c1f9 100644 > > > > --- a/drivers/gpu/drm/panel/panel-novatek-nt37801.c > > > > +++ b/drivers/gpu/drm/panel/panel-novatek-nt37801.c > > > > @@ -267,6 +267,11 @@ static int novatek_nt37801_probe(struct mipi_dsi_device *dsi) > > > > if (ret < 0) > > > > return ret; > > > > > > > > + ret = regulator_set_voltage(ctx->supplies[0].consumer, > > > > + 1650000, 1950000); > > > > > > This should be done in the DT. Limit the voltage per the user. > > Two reason: > > 1. > > I see https://patchwork.freedesktop.org/patch/354612/ > > > > panel panel-novatek-nt35510.c also use regulator_set_voltage set right voltage, > > so I do the same work. > > Please look for the majority rather than the exceptions. Out of all > panel drivers only two set the voltage directly. > > > > > 2. Kaanapali vddio regulator: > > > > vreg_l12b_1p8: ldo12 { > > regulator-name = "vreg_l12b_1p8"; > > regulator-min-microvolt = <1200000>; > > regulator-max-microvolt = <1800000>; > > > > Voltage is from 1.2~.1.8 V , So I can not set it 1.65~1.95 V from DT(1.95V is beyond the allowed range). > > So I use regulator_set_voltage to set voltage, and regulator_set_voltage will choose the appropriate voltage. > > DT has to list the voltage values that work for the devices on that > particular platform. So, ldo12 should be listing 1.64 - 1.8 V. get it. I check downstream DT, dosnstream DT: regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; I test 1.8V works, So I will add 1.8V in next patch, do you think it is ok? Thanks, Yuanjie > > > > > > Thanks, > > Yuanjie > > > > > > + if (ret < 0) > > > > + return ret; > > > > + > > > > ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); > > > > if (IS_ERR(ctx->reset_gpio)) > > > > return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), > > > > -- > > > > 2.34.1 > > > > > > > > > > -- > > > With best wishes > > > Dmitry > > -- > With best wishes > Dmitry