From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: remi.buisson@tdk.com
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: imu: inv_icm45600: Initializes inv_icm45600_buffer_postdisable sleep
Date: Fri, 31 Oct 2025 14:47:39 +0200 [thread overview]
Message-ID: <aQSv6xM6j-lpTzdb@smile.fi.intel.com> (raw)
In-Reply-To: <20251031-icm45600_fix_buffer_sleep_init-v1-1-924efbb165e8@tdk.com>
On Fri, Oct 31, 2025 at 10:58:02AM +0000, Remi Buisson via B4 Relay wrote:
> From: Remi Buisson <remi.buisson@tdk.com>
Sorry, but you must write the commit message.
> Fixes: 06674a72cf7a ("iio: imu: inv_icm45600: add buffer support in iio devices")
> ---
> The sleep variable in inv_icm45600_buffer_postdisable could be used without being
> assigned in case f error. It must be initialized to 0 by default.
Why is this in the comment and not in the commit message? Also, can you spell
out the real compilation warning or so?
Otherwise the code might look okay, depending on the context. Again, usually
it's recommended to assign as late as possible to avoid subtle mistakes when
the same variable might be reused in the (future) code.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-10-31 12:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 10:58 Remi Buisson via B4 Relay
2025-10-31 12:47 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQSv6xM6j-lpTzdb@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=remi.buisson@tdk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®