From: Johan Hovold <johan@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: greybus-dev@lists.linaro.org, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Mark Greer <mgreer@animalcreek.com>,
Miaoqian Lin <linmq006@gmail.com>
Subject: Re: [PATCH] greybus: es2: Use pointer from memcpy() call for assignment in output_async()
Date: Tue, 4 Nov 2025 12:41:48 +0100 [thread overview]
Message-ID: <aQnmfCKoB3FJ5Jz8@hovoldconsulting.com> (raw)
In-Reply-To: <b542b028-4f9b-44cd-aca7-5d4977c2faa4@web.de>
On Fri, Oct 31, 2025 at 07:57:47PM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 31 Oct 2025 19:50:39 +0100
>
> A pointer was assigned to a variable. The same pointer was used for
> the destination parameter of a memcpy() call.
> This function is documented in the way that the same value is returned.
> Thus convert two separate statements into a direct variable assignment for
> the return value from a memory copy action.
Markus, stop sending these kind of crap patches that just wastes other
people's time. You've had a number of maintainers reviewing the latest
batch (including patches which apparently does not even compile) all
telling you the same thing.
> The source code was transformed by using the Coccinelle software.
Since you know how to work with Coccinelle, at least try to come up with
something that fixes actual bugs.
Johan
next prev parent reply other threads:[~2025-11-04 11:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 18:57 Markus Elfring
2025-11-04 11:41 ` Johan Hovold [this message]
2025-11-04 11:55 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQnmfCKoB3FJ5Jz8@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgreer@animalcreek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®