mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolas Schier <nsc@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Dimitri John Ledkov <dimitri.ledkov@surgut.co.uk>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, Omar Sandoval <osandov@fb.com>,
	Samir M <samir@linux.ibm.com>,
	Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Subject: Re: [PATCH] kbuild: Strip trailing padding bytes from modules.builtin.modinfo
Date: Thu, 6 Nov 2025 07:57:18 +0100	[thread overview]
Message-ID: <aQxGziZq6yK-V8HC@derry.ads.avm.de> (raw)
In-Reply-To: <20251105-kbuild-fix-builtin-modinfo-for-kmod-v1-1-b419d8ad4606@kernel.org>

On Wed, Nov 05, 2025 at 03:30:27PM -0700, Nathan Chancellor wrote:
> After commit d50f21091358 ("kbuild: align modinfo section for Secureboot
> Authenticode EDK2 compat"), running modules_install with certain
> versions of kmod (such as 29.1 in Ubuntu Jammy) in certain
> configurations may fail with:
> 
>   depmod: ERROR: kmod_builtin_iter_next: unexpected string without modname prefix
> 
> The additional padding bytes to ensure .modinfo is aligned within
> vmlinux.unstripped are unexpected by kmod, as this section has always
> just been null-terminated strings.
> 
> Strip the trailing padding bytes from modules.builtin.modinfo after it
> has been extracted from vmlinux.unstripped to restore the format that
> kmod expects while keeping .modinfo aligned within vmlinux.unstripped to
> avoid regressing the Authenticode calculation fix for EDK2.
> 
> Cc: stable@vger.kernel.org
> Fixes: d50f21091358 ("kbuild: align modinfo section for Secureboot Authenticode EDK2 compat")
> Reported-by: Omar Sandoval <osandov@fb.com>
> Reported-by: Samir M <samir@linux.ibm.com>
> Reported-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> Closes: https://lore.kernel.org/7fef7507-ad64-4e51-9bb8-c9fb6532e51e@linux.ibm.com/
> Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> Tested-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
>  scripts/Makefile.vmlinux | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
> 

Reviewed-by: Nicolas Schier <nsc@kernel.org>

-- 
Nicolas

  reply	other threads:[~2025-11-06  7:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05 22:30 Nathan Chancellor
2025-11-06  6:57 ` Nicolas Schier [this message]
2025-11-06 17:09 ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQxGziZq6yK-V8HC@derry.ads.avm.de \
    --to=nsc@kernel.org \
    --cc=dimitri.ledkov@surgut.co.uk \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=osandov@fb.com \
    --cc=samir@linux.ibm.com \
    --cc=stable@vger.kernel.org \
    --cc=venkat88@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®