From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC5F42DE702 for ; Thu, 6 Nov 2025 07:13:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762413229; cv=none; b=QNt3e6dvDLKRzwPR4wdDgK4UZfahgD5BMRzTdK7mIH6I+WznIi1JThHF5Kc9PRe6AiWm40k2UanBxJ3IgOrisIoQLldKpsX9YGpKDZNcWuOEc0m4AVUPWh38jocwwluIIDZFFuj2MaFO4YXGf5cVNeBm3faV4HovMzg9Vc8ffPY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762413229; c=relaxed/simple; bh=O8Kuzgwo8NxVtUGQ/sqROsYTAZBIAHhIOZ8Fv83q4tE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PC8CWAT9GI+6NW2jnPqzp3K3HiUtsTuHD20lxAs4ycZVdcBF/XCKlFLEdAr/BDlfwKOF92PujPSpCQqqcghMn+h+w8tO7ujLVld4q29CVXoL9vYd2jDC8abYXwamUajjKl7bjHlflHdJIwzee826jpngfi4fTG9gmD+M2lQlJdc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BgiGz3vO; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=USLIWSv8; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BgiGz3vO"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="USLIWSv8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762413226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FOLQ/S3FFuFAGuSGNX4WWksMd2R4YXO/SrRbOgkSfy8=; b=BgiGz3vOUFyK1nci3w+69HxNd80AQJ/Uuckw38Y12hG7G3QvL4dUzltLOKZ/p1U9CBmU2V AKbqBppNzgixQfvyiZB6amZkBRixmSWV3zy/O6VyNtetfiToHNtVVTufdYkrrGZmgskpX9 lBDgYLugOIP6cQMoCfk5X4elgy68uEI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-5C8oLOEOPpi2aqxm4qFm2Q-1; Thu, 06 Nov 2025 02:13:44 -0500 X-MC-Unique: 5C8oLOEOPpi2aqxm4qFm2Q-1 X-Mimecast-MFC-AGG-ID: 5C8oLOEOPpi2aqxm4qFm2Q_1762413223 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4775e00b16fso4007775e9.2 for ; Wed, 05 Nov 2025 23:13:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1762413223; x=1763018023; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FOLQ/S3FFuFAGuSGNX4WWksMd2R4YXO/SrRbOgkSfy8=; b=USLIWSv8jzi0XwvpacddR61/GSGBEEnW5HqdAGi9dOuVt5eZynS6+qOaziAkKnePa9 WDzk/xevrJWhayw3YcdI52DeJEIyK/22xcwKQJs3uq91aj0whaQmsO2CkZAhe1vgI0Yp cfS2ZgeezRcKoLwpUPPZ9K4bKQu4DiKcp228wb0piIcBSUXXCOcb2zSnUWY7WWswF1K0 NB1fPy2YNDQyfSMUrICVtZMABsGHF7kSA0zt4vJ0Sebet5o7DDBjqtuxhsITuURArDct w53a95XJwsFu30b1LXQj04HYoAkKHpHxSU1J2Ntn3P+WQMtSozboh68GD8UkPh2B/8v1 Df8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762413223; x=1763018023; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FOLQ/S3FFuFAGuSGNX4WWksMd2R4YXO/SrRbOgkSfy8=; b=dx4zPWUwT0ZQZxTvwYScKQF84MydcnyMAdlRNW54fKnI8mMtRdiMe9VqB11JDqd+a+ ACDMRxGnMNSE3VJZXrO4D4uvpEVUmmdTh1GYZIA7dpOIIIOAaYMuT+R6I6QyzLXRn0Tl Hu5zeUCupepj8Y0EAYe792PAnMepyGEqbFPl8yWwdi75Zu6/9+EC7xpGW0t5Z7ktjqSs w666yfFGlDEgbT0N/AojAMr+fN27+nApuzSYtDoaM7DSZAnHFOion7U0cHC6xA+WSkX4 nFPDOdq6L1gHRbBLzqPZ3uf96/Jfri6YNm4KogwHFceH37tgq5F2zPpr6StOYu6QRVxo mRkg== X-Forwarded-Encrypted: i=1; AJvYcCW/bDZRQuTK/Mu2/rPjs5yNS1I30pdHbkrdxiI8vQfANFINUqcdHKq9XojIRl4vdKkqzHsIWkh/amyuOIs=@vger.kernel.org X-Gm-Message-State: AOJu0YxawlnhWEAil0m3Uvr5LE11nRQoTZy6MhiP6fuXpvSfq78K/0lN Vl207jPgbgcim1rmdojzObrFVuqLb9GtA0ivrfbaVpJmTUCFegSgM4HqWEjjkEKqYOkecoQmjuo oiun++IgEu1nlNGDzZWS3dYjg5PSFXAaDb07js7dDmdzDac/nlZDpV4g8lgVWgel/sg== X-Gm-Gg: ASbGncvd7hc17JhPmm+SaqDXJTRmrrV8oUrfQvtkQfi3wEzgKfK3tVBGFCStmM+ovRk SsBm2RHGKxZgsxn8xPMTEtArI4zO94v5Y2gSHuyt3aWnIpf2kshbhJascu6m4ARZGy8HCuZDtwY 7EPeMHyiFaLQ0PUKxncGZORBDUAoGpY/wW0mXWzn/6qUGdUmycIMhcAjoJWQSIXatlA/cjWJ9id spWFWSq6XKQiqlKDv/vQVIWdF9lVL5RxaLhVNr0Jc/M+jDEKAF3nng6tesZvnJPLxdMJTlqMB/K 16wVYiXBJR6yc6DVebDnRWxZYrBPJV8e6s+9KUJFVXVbHy5pk25XbVJnyOnW1S/Vedxt4i9PY7q DXisK6JxUAf9iFC58PQ4cqzD/55x94A== X-Received: by 2002:a05:600c:3112:b0:477:54cd:202f with SMTP id 5b1f17b1804b1-4775cdbd575mr53958325e9.3.1762413223132; Wed, 05 Nov 2025 23:13:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUu7ukY7OdyVbeRYFijYbMWBIebeXNAL9BcWIWvL8Cng+u4L3PwJcTQmxc3W42nkhzCF1KSg== X-Received: by 2002:a05:600c:3112:b0:477:54cd:202f with SMTP id 5b1f17b1804b1-4775cdbd575mr53958155e9.3.1762413222738; Wed, 05 Nov 2025 23:13:42 -0800 (PST) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.129.40]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429eb4adde4sm3235490f8f.46.2025.11.05.23.13.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Nov 2025 23:13:41 -0800 (PST) Date: Thu, 6 Nov 2025 08:13:39 +0100 From: Juri Lelli To: Andrea Righi Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Tejun Heo , David Vernet , Changwoo Min , Shuah Khan , Joel Fernandes , Christian Loehle , Emil Tsalapatis , Luigi De Matteis , sched-ext@lists.linux.dev, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/11] sched/debug: Stop and start server based on if it was active Message-ID: References: <20251029191111.167537-1-arighi@nvidia.com> <20251029191111.167537-3-arighi@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251029191111.167537-3-arighi@nvidia.com> Hi, On 29/10/25 20:08, Andrea Righi wrote: > From: Joel Fernandes > > Currently the DL server interface for applying parameters checks > CFS-internals to identify if the server is active. This is error-prone > and makes it difficult when adding new servers in the future. > > Fix it, by using dl_server_active() which is also used by the DL server > code to determine if the DL server was started. > > Acked-by: Tejun Heo > Reviewed-by: Juri Lelli > Reviewed-by: Andrea Righi > Signed-off-by: Joel Fernandes > --- > kernel/sched/debug.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c > index 6cf9be6eea49a..e71f6618c1a6a 100644 > --- a/kernel/sched/debug.c > +++ b/kernel/sched/debug.c > @@ -354,6 +354,8 @@ static ssize_t sched_fair_server_write(struct file *filp, const char __user *ubu > return err; > > scoped_guard (rq_lock_irqsave, rq) { > + bool is_active; > + > runtime = rq->fair_server.dl_runtime; > period = rq->fair_server.dl_period; > > @@ -376,8 +378,11 @@ static ssize_t sched_fair_server_write(struct file *filp, const char __user *ubu > return -EINVAL; > } > > - update_rq_clock(rq); > - dl_server_stop(&rq->fair_server); > + is_active = dl_server_active(&rq->fair_server); > + if (is_active) { > + update_rq_clock(rq); > + dl_server_stop(&rq->fair_server); > + } > > retval = dl_server_apply_params(&rq->fair_server, runtime, period, 0); > > @@ -385,7 +390,7 @@ static ssize_t sched_fair_server_write(struct file *filp, const char __user *ubu > printk_deferred("Fair server disabled in CPU %d, system may crash due to starvation.\n", > cpu_of(rq)); > > - if (rq->cfs.h_nr_queued) > + if (is_active) > dl_server_start(&rq->fair_server); Something that I noticed while reviewing this series is that we still start back a server even if the user put its runtime to zero (disabling it) and I don't think we want to do that. It's not of course related to this change or this series per-se, but something we probably want to fix independently. Thanks, Juri