From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: kees@kernel.org, broonie@kernel.org, gregkh@linuxfoundation.org,
arnd@arndb.de, hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
linus.walleij@linaro.org, brgl@bgdev.pl,
platform-driver-x86@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mod_devicetable: Bump auxiliary_device_id name size
Date: Thu, 6 Nov 2025 10:05:51 +0200 [thread overview]
Message-ID: <aQxW3-M-B6OlusEg@smile.fi.intel.com> (raw)
In-Reply-To: <aQxVNPRVdJvbqkiz@black.igk.intel.com>
On Thu, Nov 06, 2025 at 08:58:44AM +0100, Raag Jadav wrote:
> On Thu, Nov 06, 2025 at 09:40:46AM +0200, Andy Shevchenko wrote:
> > On Thu, Nov 06, 2025 at 10:58:38AM +0530, Raag Jadav wrote:
> > > We have an upcoming driver named "intel_ehl_pse_io". This creates an
> > > auxiliary child device for it's GPIO sub-functionality, which matches
> > > against "intel_ehl_pse_io.gpio-elkhartlake" and overshoots the current
> >
> > Looking at the name there is another question: Why do we need 'elkhartlake in
> > the GPIO driver's name now? It's a dup to 'ehl' in the first part.
>
> Just kept it for historic consistency and I'm a bit terrible at naming.
I am afraid this alone wouldn't be enough to justify the bump.
> Perhaps "gpio-aux"? But that's too generic from subsystem POV.
From the above the simple 'gpio' would suffice (as long as this driver won't be
used by name directly, also makes sense to check the sysfs file / folder list
to see where it may appear and may or may not clash with the similar driver
from other AUX bucket).
> Open to suggestions.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-11-06 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 5:28 Raag Jadav
2025-11-06 7:40 ` Andy Shevchenko
2025-11-06 7:58 ` Raag Jadav
2025-11-06 8:05 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQxW3-M-B6OlusEg@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kees@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®