From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F65A311C07 for ; Tue, 18 Nov 2025 23:31:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763508687; cv=none; b=p/BVTy97XL0omn5nPbQo3GyOiFe4OmJ0RNfhikKMqoqcctWNJdtMhX6z7C52+QfKfMio8Gv+V7nqHl+LJ+LVha+VwB+S9WNirOn+opAWj5amnV+njQuPOe26+REiqpP4W2rtGdc9EZPZVUCLqoBr/teZTLfZjBATzH2mYl7jqGA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763508687; c=relaxed/simple; bh=5WBwqUVhmKiZfIpTpsQTwtOFw21J/JhhQ4L/zj7meTg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=TwQhawweoGDKQ29kPR4P5F7TRXaOmqJ3rUImjGR2YcN0NGixOQ06xhB9rKsk/ATsxUxDvhVXGC+vY4grqiS/jBym70ZN8O4XPxTfrlUmKCLpYykKS/UUW0i8mmSJL9VYxcMlk+zanVUSi1oYL5ZWEDS3DbH9+dBQKR9FitH5FNA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=VQQqjyCV; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VQQqjyCV" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-3438b1220bcso7127421a91.2 for ; Tue, 18 Nov 2025 15:31:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763508684; x=1764113484; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=vhbmIaudy7FUgPhz41c9iiSjQeSWp1bqqQI5ni0zcdI=; b=VQQqjyCVKUjethBzmocMAKOMZ1Qk6f5+puPh/BGYtTyIWze6b1FACLZwRYeu2GTtT6 Ka5NqxXzLHFbn7+q4velVVnI0knXOUecLZK1+BZ5V/cOs26euxCEk0eGIw/iCi2xLh/4 vtPBR+vy8msAFS2Ej6JQijGmxjN3w2H6WJbI8Vq7GbkTZq/DKlRv4mO7pcM2hGu9Qq9M 8oVpUbsUPGhrpKfoyp0VrrMOXA+uECznX1BNDbTejb7wBC/ArDFhRBhhM8WKvvFXF3eB /ChnZmu4M3eUGiNK8oXMFjia3S86lnBVfqiOQWh2eLY9QYI/SqDHIBCcJvcBTZYocvN2 F8og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763508684; x=1764113484; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vhbmIaudy7FUgPhz41c9iiSjQeSWp1bqqQI5ni0zcdI=; b=oU21vCBjIdPpxSlsWj46Z23KMSppbnbO534tlvXk8MxH97Wz88ux6hs8bDiTN7Nf/u vZZxXNxPGdtYQ9TUZ41hYBTp2vAgXCiEFlH9jVF3U7ZltvT8FUa3S5uH/FEhOugfu1bU vl1kjebNscdXvUEYWbn9jGf/roALW1e6Wggb6o/iHqv9tqWHcgP6FACYgy1DIWl8TJIZ xHmU7P7qlNF/bZPxkpqSGUG98ny1B8yqF7vmfIlp43uYB0AimD3Z55FdGie+UOI7IlP8 YlygucXOHNZTReEfOcCm6pjT8XexjeOreZUzxcEfxhkYc7Jj5QSPSqNIRQBYB53w49ij FD2A== X-Forwarded-Encrypted: i=1; AJvYcCVizACLVi2+7PDyjOdtSqja6bR50SzHVfQO0bRXm81Ei/R8JHBvbgqrdSvyVbWY9bgnCPv1C/OLbs9Mp8U=@vger.kernel.org X-Gm-Message-State: AOJu0YyGDuyY/YFx4TDdOQ429u+eTz9oS1saitpxsrTI0YgtbwHxGTko +j+xkKVsxJXY00wkOBGz2pw9BkQDQC7s3+yH+gSXsXJFQB44agAH90IoLaBPNKYNADi9nTtx17d XGfra7A== X-Google-Smtp-Source: AGHT+IE1o3OuDgEYh+WwImWCZtj32ss/bDTcBxOCjrPrz1sqG0DLMNd/QRhOEpFCg6/bq23FewNy3cS6Bik= X-Received: from pjbpd18.prod.google.com ([2002:a17:90b:1dd2:b0:340:e8f7:1b44]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5484:b0:341:124f:474f with SMTP id 98e67ed59e1d1-343fa6390cfmr19214010a91.32.1763508684387; Tue, 18 Nov 2025 15:31:24 -0800 (PST) Date: Tue, 18 Nov 2025 15:31:22 -0800 In-Reply-To: <20251028002824.1470939-1-rick.p.edgecombe@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251028002824.1470939-1-rick.p.edgecombe@intel.com> Message-ID: Subject: Re: [PATCH] KVM: TDX: Take MMU lock around tdh_vp_init() From: Sean Christopherson To: Rick Edgecombe Cc: ackerleytng@google.com, anup@brainfault.org, aou@eecs.berkeley.edu, binbin.wu@linux.intel.com, borntraeger@linux.ibm.com, chenhuacai@kernel.org, frankja@linux.ibm.com, imbrenda@linux.ibm.com, ira.weiny@intel.com, kai.huang@intel.com, kas@kernel.org, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, maddy@linux.ibm.com, maobibo@loongson.cn, maz@kernel.org, michael.roth@amd.com, oliver.upton@linux.dev, palmer@dabbelt.com, pbonzini@redhat.com, pjw@kernel.org, vannapurve@google.com, x86@kernel.org, yan.y.zhao@intel.com, zhaotianrui@loongson.cn Content-Type: text/plain; charset="us-ascii" On Mon, Oct 27, 2025, Rick Edgecombe wrote: > Take MMU lock around tdh_vp_init() in KVM_TDX_INIT_VCPU to prevent > meeting contention during retries in some no-fail MMU paths. > > The TDX module takes various try-locks internally, which can cause > SEAMCALLs to return an error code when contention is met. Dealing with > an error in some of the MMU paths that make SEAMCALLs is not straight > forward, so KVM takes steps to ensure that these will meet no contention > during a single BUSY error retry. The whole scheme relies on KVM to take > appropriate steps to avoid making any SEAMCALLs that could contend while > the retry is happening. > > Unfortunately, there is a case where contention could be met if userspace > does something unusual. Specifically, hole punching a gmem fd while > initializing the TD vCPU. The impact would be triggering a KVM_BUG_ON(). > > The resource being contended is called the "TDR resource" in TDX docs > parlance. The tdh_vp_init() can take this resource as exclusive if the > 'version' passed is 1, which happens to be version the kernel passes. The > various MMU operations (tdh_mem_range_block(), tdh_mem_track() and > tdh_mem_page_remove()) take it as shared. > > There isn't a KVM lock that maps conceptually and in a lock order friendly > way to the TDR lock. So to minimize infrastructure, just take MMU lock > around tdh_vp_init(). This makes the operations we care about mutually > exclusive. Since the other operations are under a write mmu_lock, the code > could just take the lock for read, however this is weirdly inverted from > the actual underlying resource being contended. Since this is covering an > edge case that shouldn't be hit in normal usage, be a little less weird > and take the mmu_lock for write around the call. > > Fixes: 02ab57707bdb ("KVM: TDX: Implement hooks to propagate changes of TDP MMU mirror page table") > Reported-by: Yan Zhao > Suggested-by: Yan Zhao > Signed-off-by: Rick Edgecombe > --- > Hi, > > It was indeed awkward, as Sean must have sniffed. But seems ok enough to > close the issue. > > Yan, can you give it a look? > > Posted here, but applies on top of this series. In the future, please don't post in-reply-to, as it mucks up my b4 workflow. Applied to kvm-x86 tdx, with a more verbose comment as suggested by Binbin. [1/1] KVM: TDX: Take MMU lock around tdh_vp_init() https://github.com/kvm-x86/linux/commit/9a89894f30d5