From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1602355030 for ; Wed, 19 Nov 2025 15:46:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763567220; cv=none; b=mUrZOdfo248QebrT4J/rX87ZTtXlhlWsuoPWvSBtHxWZzhPFCkuAvtLa6VIwi2iBGbybRMeXtxwH/erry6bfpUCUP487fukdvLrVK0DkG6Qxu3nQGwlUAxL9NO052/laba6N4rzUAKA35WNz1JN7sZFmsEy9YU2TolmZcRFuYfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763567220; c=relaxed/simple; bh=U5NhlkeRqUN10mR4o8uWI2N5NAgpt//v0cCmIvAwbXc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SZyFObXUZ9ZSLkhcUwH3SVsXzIIZvimy4ygo/Uy6tWLnT5W14SUwmPGXM2Aj3LjF/if0f5wPG667aFSItMsiI8ypU46UglZMMIKSFcnVXGru6fKfCVEwwDwnaTGXkB9tnAH68VcQf1JuFHOzJ08d0wVnNdh5QPwMegx19pL+y/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=SV+ASRkf; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="SV+ASRkf" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-640aa1445c3so10806818a12.1 for ; Wed, 19 Nov 2025 07:46:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763567215; x=1764172015; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4YNlzYd8r9oimJ6yoxrQ5cthaTZ8k3XmV4fV99EqbZs=; b=SV+ASRkf/Fy7cStDZXR0TpAohZbZS6fW5tt7YTLxlQiKWfcl+iAlrd3YWyWwHvCDJf bu/eudLAJEWmp+4kVdnKF7D+y0W3O56bJZknpGMbfiaDoth/V92LCReBhsjrQOHg7ant qQN2RRBdmszjTbNmdpYEvn1IG0hJ82i7Gb44Y/buQ6CW8UmUkfE9E2Be0QhIJ7EL/58S sKAwlVICmb2o/71//hzZ4tRaqIlbneLtocKJKKAUTsNf1eGih/YF2aK40kh3qacO8B8F rZbzSjpJOgUiGMUA+3JoHJDDqoyUYaONODHJdhTC8sC/eDvCJjRwCgY75lI6qYsVXQTf pYlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763567215; x=1764172015; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4YNlzYd8r9oimJ6yoxrQ5cthaTZ8k3XmV4fV99EqbZs=; b=l94bAL3MCaL3lwTAPTaDYMn4cQhXXSPaeXdscRCyHGv055io9hqBVKCpQT8E/djZGQ gKX0JJigkOnIwuFuWkyTM0KQHz2ef/7aa6w06j/Y0XOPtG+1qWtrYBvUrfMXNgXUYPhN Gfy1laTW/uMyQisJsulBD3dg7PH4jUAao/zs+JLupYkO3Lbvflw0c6O7PYxN8lPusMOE aG5xli9q+wKqrQHSnXRBZu5vF6+/ABteJ/+NygHDoSAQH38Kxm60HxLqe0meVt7jPLCJ f2qMziUBT/Iug0i7VfOM0okXIi+PQBj1sUHLI07OrM4TJxo1IvnvIbqEb1r0QQiY7diz u2aw== X-Gm-Message-State: AOJu0YxrKTrn3GHVGPJNqmOmkCFjUerumg0qMuyUFAh5Vq68hrq0nm9T W712NYYEh8/1eURzSfZiZFhlSB0nNrfkecgJDadAg9TYvnEiMQWsLIOSi1LpR4SHMk8= X-Gm-Gg: ASbGncvpw4+/qc83ji4TqO0btyfDDPXTUjz8OhlnsCp9Vb1RNPX4HZVV1hFe8fwIUoE IFE1qvetNKTrUNfMcECoU5NQh3oNeonlw3IaPaOsnqvE07CXawiSHTEnGafwBEyJ1BXeCb6w/yG 8gDGjn4FKIClH950WKUPrlYN25CO/drtbFuFW5777K7DaVKzEIwnlFkktExXIR8h0C3zxqeg/se T1zAYNBEczlJf/s6iJ6bAtCWAgDXDibL7fl+7tDDd/TAinlD0G0m2yxVHnN0VF9hELOIkhcCY4v kx3cH0iDUKsAc5WDDPPGIklDTfRWo2N8RG6326hpQGhJpot0nTMwOW93ay3sojDnIOwHyFWPdkM fcoOfhy1cQ+G8jOrc6q3HzCvsnwQmlhEaWkLDYKT29NweqqDGl3QwpPVK8pHF3WiJ/kWTjDrXE5 fYBn1yZkgeyceLqIT6leWfCrbA X-Google-Smtp-Source: AGHT+IFa63LJsrKSvdyflyEPLmlZuC0jWDwAii2BEaA/gMFkbT4cwgZ1rrVRVJz7zEAYmtgf53oePw== X-Received: by 2002:a17:907:1b19:b0:b5b:3ab0:a5b7 with SMTP id a640c23a62f3a-b73678eac8amr2133815566b.42.1763567214508; Wed, 19 Nov 2025 07:46:54 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fd809absm1654510266b.44.2025.11.19.07.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 07:46:54 -0800 (PST) Date: Wed, 19 Nov 2025 16:46:52 +0100 From: Petr Mladek To: Chris Down Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Sergey Senozhatsky , Steven Rostedt , John Ogness , Geert Uytterhoeven , Tony Lindgren , kernel-team@fb.com Subject: Re: [PATCH v7 01/13] printk: Avoid delaying messages that aren't solicited by any console Message-ID: References: <8c69a5fccc15a512e5ba6385f3c933e3d2f8a96b.1763492585.git.chris@chrisdown.name> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed 2025-11-19 03:33:20, Chris Down wrote: > Of course, one reviews the whole patch set and then misses... I think that this is a classic post-sent panic ;-) > Chris Down writes: > > - boot_delay_msec(level); > > + /* If the message is forced (e.g. panic), we must delay */ > > That should obviously say "_not_ delay". I'll fix it on next resend. IMHO, the original message is correct. The message is forced => shown => the delay allows to read the message on a screen. > > + if (!is_printk_force_console() && suppress_message_printing(level)) > > + return; > > + > > + boot_delay_msec(); Best Regards, Petr