From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2855335BDCE for ; Wed, 19 Nov 2025 16:22:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763569366; cv=none; b=droGUBqtBniZlilXDOiSt28byzucuZUHGfhDdZoPWDnoGno3qmr6wdXXC7UtYBZESmiPP4Mso0G2gFRTWQtDA1imTaQVWglmeUZLC1YQb/Z6TmZ8yPvN2ORVwdVrRA6gwXAo1R5rhEl6tzD828gL/CdUnlHNJ4+R994z0MMI+Ok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763569366; c=relaxed/simple; bh=4tZVfB9dJ+rmxklUVisjbT+aHHa2hP/95ghmvU1+jv0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Nd36MGa1Nz3E1ZE56hW9dgQ+/cHb856jQOgvEV0VQRdCBi6yHyDfBxfUjyODw8of7fqtwCKEKoA9+tptzoiseYcYmHiqgEDV9T8gDjYB7JpL57WmkuLy6Ym4fC53pc6s/xlvwlGgshotS8fbG3w0r+eZ6r6zW0y8L8gRocBjE00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xE9gufn/; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xE9gufn/" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7bb3092e4d7so5514542b3a.0 for ; Wed, 19 Nov 2025 08:22:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763569364; x=1764174164; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=SqgArqZqDLLZkxxlGxEl0Eyz/se4zZ6TXQ2QUXMksPc=; b=xE9gufn/HyPx1J1FHvG46nO5e7dC32J8ZDVbZcCfJaO7HMleyz1NWZrgOKyL9+hMMc ZqQB/X2etB4WKjPkf6DCLa8CTzxv+Jnt99Gh7kzXnS7EF2WmtmAE3msPLkaX9aMrImSy k3FjhU+nPsz0vjYtIsT4tp1UOimOhztNo16IagJB58yJoIxed/FelEMxgC+X6xIWIxbF WZOZhKBsD/STpXJsFG5O2UDLPK/av0kM8NJrc8OPiQgJYBU3cY+xFUKhXLCLQ4HO0N65 BrGYOT3TZBl9m4Pbe7Vs9IbKztJzL77o2xrugqB5gSkSo/IWfZq7TR/5a0rWGqYFZgb6 2y6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763569364; x=1764174164; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SqgArqZqDLLZkxxlGxEl0Eyz/se4zZ6TXQ2QUXMksPc=; b=I374n6I0r24knIgjQKm/Np7awZZLKDLYiCTl+9mniZ9Cz1eYpcIFHDYSVFos3akd+s fTqwyfopz5fgaXtSs21mpPxgjVGiXHKo4kdC7/8Lrzf0yOV3U2+UiPvLX/iNO3t6M0jf oUV2MQIlLl+vfe45ujY66XM5EbHlG8l7qRouXOBi/5BBjzXb/5cgK5/HoCi0eNuEpSpS 81IjGhzJoIaaqXlcs7vhsTBrgiEZ84a2wsnVEVdUVsYbWEs0liFRFS1hMStDWVLrx9+3 Bpm6WkvAbY+JlVxApBXAvPvWuT3z+Ko8ePxFVuNGXQ76poGik0Va5qJvxD3Fpmygu526 v6gA== X-Forwarded-Encrypted: i=1; AJvYcCVeRrctOD2PUFtra5/vih9u+HTDtdly4f9LZvxtbgWjADdj6HOzAqoDGfLOI2ND5hFBAnAKQnFOf3NDpUg=@vger.kernel.org X-Gm-Message-State: AOJu0YxzwZXTrwdix6uTgfCjzhM16VTOIetAYVb56ChpGu1DHOx/zbtr pHM7m0+0h5EhGdqoF421v3tFwg3gNRQduf8snMwsN6ubuKUlNHyyNq2E8ldWlhYWNWvhle3XSRS hk0L8a6Y= X-Gm-Gg: ASbGncv+Yi1xjtSD7whMEidh0ygopDnuVO2HpmQXRDx3hZeOMZrgJGVuoYabUVyJwvR YyVUOJAijaMFlThDX2i1qkbNKaYFw8sG4wpkcoi5NbbYlL43bPxJPbKS3d1isVn6UorqAC3mV8p tF7ox7tpdBzuXMl0x5azdOtXnbP2bCL2Kp4HfFxjwlnip9vXm/RxR03IAjaIbHKTADhl3nK1JDd hVWkDG02wsVzWj7HN1GslHebRh+XYTk2wskR/6OBt7RPhOxj5dS46HPKbAh300mYnlXsQ7Pb0SD qWA6Tzrr2ogUafpZGgJx9ZvCoxOwgnOncDxxjr3H+g5TCVEojau8fmb8/jxgL3U2BE5oY3TQLBZ htDaSsIuurub0bXk7FgLUM7XW1iRfW57zrydHO/nngQu49Bv+uaySmiq88SfAQUjITz1v92TuRK cqxD71WC7yZlCKTQ== X-Google-Smtp-Source: AGHT+IHuSIrZBCiLgca0WU1DQj7ineP68uKwSXumgVfu9Fe9sbAmM4VWuP+tv6PTaJCg3+0A1H698w== X-Received: by 2002:a05:6a00:812:b0:7ad:9e8a:1f72 with SMTP id d2e1a72fcca58-7c29c492acamr4056626b3a.14.1763569364343; Wed, 19 Nov 2025 08:22:44 -0800 (PST) Received: from p14s ([2604:3d09:148c:c800:f8d9:9ae3:90a2:d39e]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ba611682cfsm17088879b3a.26.2025.11.19.08.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 08:22:43 -0800 (PST) Date: Wed, 19 Nov 2025 09:22:40 -0700 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Frank Li , Daniel Baluta , Shengjiu Wang , Iuliana Prodan , linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH v4 00/12] remoteproc: imx_dsp_rproc: Refactor to use new ops and remove switch-case logic Message-ID: References: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> On Wed, Nov 19, 2025 at 12:21:45PM +0800, Peng Fan (OSS) wrote: > This patchset aligns imx_dsp_rproc with the cleanup and modernization > previously applied to imx_rproc.c. The goal is to simplify the driver by > transitioning to the new ops-based method, eliminating the legacy > switch-case logic for a cleaner and more maintainable design. > > Patches 1–5: General cleanup, including code simplification and adoption > of the devres API. > Patches 6–10: Transition to the new ops-based approach, removing the > switch-case structure. > Patch 11: Remove the obsolete enum imx_rproc_method. > Patch 12: Cleanup goto based logic. > > Signed-off-by: Peng Fan > --- > Changes in v4: > - Collected R-b and T-b > - Address the build warning in patch 1 > - Add a new patch 12 to cleanup the goto based logic > - Link to V3: https://lore.kernel.org/imx/20251111-imx-dsp-2025-11-11-v3-0-d05dcba737fa@nxp.com/ > > Changes in v3: > - Collected R-b > - Simplify commit log for patch 4 per Frank. > - Link to V2: https://lore.kernel.org/all/20251106-imx-dsp-2025-11-06-v1-0-46028bc3459a@nxp.com/ > > Changes in v2: > - Collected R-b > - Patch 3: Update commit per Frank/Daniel > - patch 8: Use priv->dsp_dcfg->dcfg to avoid adding "const struct imx_rproc_dsp_dcfg *dsp_dcfg" > - Link to v1: https://lore.kernel.org/linux-remoteproc/CAEnQRZAOTFw=sBppHTYQAdfDBuNqkqk6gVO4FyP0EBsva3Oi+Q@mail.gmail.com/T/#m27c93af9fb1e7fdeb0766bdbffbaae39d79eefab > > --- > Peng Fan (12): > remoteproc: imx_dsp_rproc: simplify power domain attach and error handling > remoteproc: imx_dsp_rproc: Use devm_rproc_add() helper > remoteproc: imx_dsp_rproc: Use devm_pm_runtime_enable() helper > remoteproc: imx_dsp_rproc: Use dev_err_probe() for firmware and mode errors > remoteproc: imx_dsp_rproc: Drop extra space > remoteproc: imx_dsp_rproc: Use start/stop/detect_mode ops from imx_rproc_dcfg > remoteproc: imx_dsp_rproc: Move imx_dsp_rproc_dcfg closer to imx_dsp_rproc_of_match > remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_MMIO switch case > remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_SCU_API switch case > remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_RESET_CONTROLLER switch case > remoteproc: imx_rproc: Remove enum imx_rproc_method > remoteproc: imx_dsp_rproc: simplify start/stop error handling > > drivers/remoteproc/imx_dsp_rproc.c | 353 +++++++++++++++++++------------------ > drivers/remoteproc/imx_rproc.h | 14 -- I have applied this set. Thanks, Mathieu > 2 files changed, 186 insertions(+), 181 deletions(-) > --- > base-commit: 187dac290bfd0741b9d7d5490af825c33fd9baa4 > change-id: 20251119-imx-dsp-2025-11-19-fa99d7c84c91 > > Best regards, > -- > Peng Fan >