From: Nicolas Schier <nsc@kernel.org>
To: Simon Glass <sjg@chromium.org>
Cc: linux-arm-kernel@lists.infradead.org,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Tom Rini" <trini@konsulko.com>,
"Ahmad Fatoum" <a.fatoum@pengutronix.de>,
"J . Neuschäfer" <j.ne@posteo.net>,
"Chen-Yu Tsai" <wenst@chromium.org>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
"Tamir Duberstein" <tamird@gmail.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH v6 5/8] kbuild: Split out module targets into a variable
Date: Wed, 19 Nov 2025 21:20:04 +0100 [thread overview]
Message-ID: <aR4mdI3u51z4qhoN@derry.ads.avm.de> (raw)
In-Reply-To: <20251119181333.991099-6-sjg@chromium.org>
On Wed, Nov 19, 2025 at 11:13:26AM -0700, Simon Glass wrote:
> Add a modules-targets variable to list the targets which cause modules
> to be built, since we want to add a conditional target.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> (no changes since v5)
>
> Changes in v5:
> - Add a new patch to split out module targets into a variable
>
> Makefile | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 638bc09a546a..8cd46222fc48 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -772,7 +772,12 @@ endif
> # in addition to whatever we do anyway.
> # Just "make" or "make all" shall build modules as well
>
> -ifneq ($(filter all modules nsdeps compile_commands.json clang-%,$(MAKECMDGOALS)),)
> +modules-targets := all
> +modules-targets += modules
> +modules-targets += nsdeps
> +modules-targets += compile_commands.json
> +modules-targets += clang-%
> +ifneq ($(filter $(modules-targets),$(MAKECMDGOALS)),)
> KBUILD_MODULES := y
> endif
>
> --
> 2.43.0
>
Reviewed-by: Nicolas Schier <nsc@kernel.org>
next prev parent reply other threads:[~2025-11-21 19:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 18:13 [PATCH v6 0/8] scripts/make_fit: Support ramdisks and faster operations Simon Glass
2025-11-19 18:13 ` [PATCH v6 1/8] scripts/make_fit: Speed up operation Simon Glass
2025-11-26 9:24 ` Ahmad Fatoum
2025-12-02 10:28 ` Chen-Yu Tsai
2025-11-19 18:13 ` [PATCH v6 2/8] scripts/make_fit: Support an initial ramdisk Simon Glass
2025-11-26 10:56 ` Ahmad Fatoum
2025-11-19 18:13 ` [PATCH v6 3/8] scripts/make_fit: Move dtb processing into a function Simon Glass
2025-11-26 11:01 ` Ahmad Fatoum
2025-12-02 10:54 ` Chen-Yu Tsai
2025-11-19 18:13 ` [PATCH v6 4/8] scripts/make_fit: Provide a way to add built modules Simon Glass
2025-11-26 11:09 ` Ahmad Fatoum
2025-12-11 13:20 ` Simon Glass
2025-11-19 18:13 ` [PATCH v6 5/8] kbuild: Split out module targets into a variable Simon Glass
2025-11-19 20:20 ` Nicolas Schier [this message]
2025-11-26 11:10 ` Ahmad Fatoum
2025-11-19 18:13 ` [PATCH v6 6/8] kbuild: Allow adding modules into the FIT ramdisk Simon Glass
2025-11-19 20:20 ` Nicolas Schier
2025-11-20 7:49 ` Thomas Weißschuh
2025-11-20 20:09 ` Nicolas Schier
2025-11-25 21:58 ` Simon Glass
2025-11-26 7:16 ` Thomas Weißschuh
2025-11-26 11:26 ` Ahmad Fatoum
2025-12-02 10:31 ` Thomas Weißschuh
2025-12-11 13:31 ` Simon Glass
2025-12-11 13:49 ` Ahmad Fatoum
2025-11-19 18:13 ` [PATCH v6 7/8] scripts/make_fit: Support a few more parallel compressors Simon Glass
2025-12-02 10:17 ` Chen-Yu Tsai
2025-12-11 13:29 ` Simon Glass
2025-11-19 18:13 ` [PATCH v6 8/8] scripts/make_fit: Compress dtbs in parallel Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR4mdI3u51z4qhoN@derry.ads.avm.de \
--to=nsc@kernel.org \
--cc=a.fatoum@pengutronix.de \
--cc=j.ne@posteo.net \
--cc=justinstitt@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=ojeda@kernel.org \
--cc=sjg@chromium.org \
--cc=tamird@gmail.com \
--cc=thomas.weissschuh@linutronix.de \
--cc=trini@konsulko.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®