From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from lgeamrelo07.lge.com (lgeamrelo07.lge.com [156.147.51.103])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id D327C2FFFA3
	for <linux-kernel@vger.kernel.org>; Thu, 20 Nov 2025 07:11:44 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.147.51.103
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1763622709; cv=none; b=gJh8AwsZhyfloEstKUfT+BIYSKbzZ7xbmtglkEl+kkOg68oOlvPx9TCDjIMnAoK2OvGnNS7p2YTyV2zHMw62YtyH6pnCAOSQQFtbFxKoDy/ks/0dUOoJSqJNJrKhpiXvJKJ8NyIRDC8L7rJo4B17VFVTGOUATWvVXULRhkIBi+c=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1763622709; c=relaxed/simple;
	bh=7zeYsQGOfzlvL8HaDkGT8eUXUXOs3a9UD9O60DqZxSU=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=f4l2zNEC0sP1HjsOIAemQls2gzTuyDaa3gZQPHdlyB7RNGXKubwDDz+L8OlfqTl9VxkOtri+Xh0cy3UpQD88j59ZK4TCGC0lWd3rH+UIR15SykiJT9HbcFBbgSAwIjaIjsuf6oj8uiVPx+ngAzB7eK+1BmFsuGh8YM1zmaapyMA=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lge.com; spf=pass smtp.mailfrom=lge.com; arc=none smtp.client-ip=156.147.51.103
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lge.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lge.com
Received: from unknown (HELO yjaykim-PowerEdge-T330) (10.177.112.156)
	by 156.147.51.103 with ESMTP; 20 Nov 2025 16:11:37 +0900
X-Original-SENDERIP: 10.177.112.156
X-Original-MAILFROM: youngjun.park@lge.com
Date: Thu, 20 Nov 2025 16:11:37 +0900
From: YoungJun Park <youngjun.park@lge.com>
To: Kairui Song <ryncsn@gmail.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	Baoquan He <bhe@redhat.com>, Barry Song <baohua@kernel.org>,
	Chris Li <chrisl@kernel.org>, Nhat Pham <nphamcs@gmail.com>,
	Yosry Ahmed <yosry.ahmed@linux.dev>,
	David Hildenbrand <david@kernel.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Hugh Dickins <hughd@google.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Ying Huang <ying.huang@linux.alibaba.com>,
	Kemeng Shi <shikemeng@huaweicloud.com>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	linux-kernel@vger.kernel.org, Kairui Song <kasong@tencent.com>
Subject: Re: [PATCH v2 10/19] mm, swap: consolidate cluster reclaim and check
 logic
Message-ID: <aR6/Kc0kag8Z9y6y@yjaykim-PowerEdge-T330>
References: <20251117-swap-table-p2-v2-0-37730e6ea6d5@tencent.com>
 <20251117-swap-table-p2-v2-10-37730e6ea6d5@tencent.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20251117-swap-table-p2-v2-10-37730e6ea6d5@tencent.com>

I found the just very Nit comment cleanup.

In swap_cache_add_folio() comment, it mentions "SWAP_HAS_CACHE bit
to avoid race or conflict." Also shouldn't the comments that reference
HAS_CACHE(the word, swapfile.c) be updated accordingly?

Youngjun Park