From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lgeamrelo03.lge.com (lgeamrelo03.lge.com [156.147.51.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D9E2284888 for ; Thu, 20 Nov 2025 07:13:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.147.51.102 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763622809; cv=none; b=WJ8MHqrnGqBbuABgfWApbkpOFwvlk9gWPB8bBBVol6h3x0tJR/OLoeus/TD2J3ar3HuVxZyfOf4agmr1wQF5Df0vMoY6AcSs+nLqsWjSLiB4SJz8M63FKnNpS5oKU/HykvX/gyLYbeZnlnvGqTa0q11Rdo8gBsUqLw6ySFM5Egg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763622809; c=relaxed/simple; bh=jDKm93oGoXYEflT/fbdjLpNCiCF8FYHb5MuJK3Ys4Fg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f19uI2NFftP1BGIZ+zs9kIPhEzchDZFVDGVIx7hCDv5qgplr15R8ZtoAxvo1cYLXWYtnXm+IPDEXwDvMBAxZFZj6NwTh8gpnZpPGbvd+6e4QZ0lZ3TzCnObdFFSnmW3a/VAWasAVWtFghv82et5jEY5R+vOGRxrf4nwbRtJb+6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lge.com; spf=pass smtp.mailfrom=lge.com; arc=none smtp.client-ip=156.147.51.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lge.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lge.com Received: from unknown (HELO yjaykim-PowerEdge-T330) (10.177.112.156) by 156.147.51.102 with ESMTP; 20 Nov 2025 16:13:24 +0900 X-Original-SENDERIP: 10.177.112.156 X-Original-MAILFROM: youngjun.park@lge.com Date: Thu, 20 Nov 2025 16:13:24 +0900 From: YoungJun Park To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , Baoquan He , Barry Song , Chris Li , Nhat Pham , Yosry Ahmed , David Hildenbrand , Johannes Weiner , Hugh Dickins , Baolin Wang , Ying Huang , Kemeng Shi , Lorenzo Stoakes , "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org, Kairui Song Subject: Re: [PATCH v2 10/19] mm, swap: consolidate cluster reclaim and check logic Message-ID: References: <20251117-swap-table-p2-v2-0-37730e6ea6d5@tencent.com> <20251117-swap-table-p2-v2-10-37730e6ea6d5@tencent.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Nov 20, 2025 at 04:11:37PM +0900, YoungJun Park wrote: > I found the just very Nit comment cleanup. > > In swap_cache_add_folio() comment, it mentions "SWAP_HAS_CACHE bit > to avoid race or conflict." Also shouldn't the comments that reference > HAS_CACHE(the word, swapfile.c) be updated accordingly? > > Youngjun Park I added reply on wrong patchset, Sorry. The comment is for [PATCH v2 18/19] mm, swap: drop the SWAP_HAS_CACHE flag Thanks Youngjun Park