From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C0163126B7 for ; Thu, 20 Nov 2025 09:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763631006; cv=none; b=XmygXAPs/fpWVhCNF6lbWL1/7C38OnWFbR8WP/Ig/X/5Bj6Q+89RNu8oOp64okOIzTV0yYMQI9F9lj09gUPaRVRyihmvSxDzmWEb5lF+Fy8sdiZ5PiMUVRf9EHuDZP3bU09LO5JF6zU1ElFf+vc64kIfJlc8qdzhoaoS+YPjUts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763631006; c=relaxed/simple; bh=yQl6Am+yjM+jiH0K2AKGK6fLV8tbHJIiZjM0lPoL1lE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QYKc9ASj5xWwRaT97VxpESkkXXCROByZ2DYr8jgouqawXeVgfiRvHYpuUuv5szOkw5FaoddWxR1O9YKWY9cSfM7W/+fRElljeGs1XvrCb4ENDPriMQHYKBHG5LySpDCViiDNdY3vXglzf85tMIpz3xQUDKBm/sCeu9wU/1RMhCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LkJdHGqH; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LkJdHGqH" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7b89c1ce9easo758264b3a.2 for ; Thu, 20 Nov 2025 01:30:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763631004; x=1764235804; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Y0ahZnkbKTq/zXCngVOV5tNUB9eHwQteBjkic4SlaNw=; b=LkJdHGqHa6ld60aK0jwh3vfQDfBL7YvT20Lef9wLzgef2/0kVrbgnn0E9X2FzUySE/ mCwQS99km2qsErzS+qX/l6SX1c2zSFbZWrm+aSavnNybRJzkblgyHyUG8E8Ang1OlLhq m3jV9LGxzoXpUdtfAWBsgli08pmT+m11KghmtlsZHNXW5WTKKqeaMSR4F93OWwg1k0aN iJh8Csg8J5SGt0lgGJ8WUT5GJcLoL5RMRVV1Muya1mGZmpk+x7VDmWCDwC7Ucln8HgW7 jkrL0IFtJ6uUOsPKUJ22D0h0zzGGVr79PwX66it6nkquXq1hZmI9Q7RzaJU38FZ5i1SG 9aRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763631004; x=1764235804; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y0ahZnkbKTq/zXCngVOV5tNUB9eHwQteBjkic4SlaNw=; b=nhvUCaXv0P5Esne/0BzeE6colVHj9epNMvEL1vDaBkRull3dkzy5grzNos2Sknfx1d sijmVx+pDyeZ7X4/0Y2x+b6TlyGUsFcjMXT1I8d0glLU+YtuCYZ5UdCvGOetsrGu7LYa s72lXJjQpqxoKPFNKQptsk4TOVX8AzOsO1DQa16GCDGTT9VUxmGqlMAQ4FJ5iHTtFxvR gJFjNvtzVWIjEvPQhgh29JY3yuazWTKJlW6P9Fn3IE3bfpSTsyauIQknZqmLGJFtlS3K L+vkcbSBqZt+kvXFjlGzj5FxT9BXUeG+LhBcgE14g+B28O6IKLRXWEQjNqKQU9bxIXbH sTZw== X-Forwarded-Encrypted: i=1; AJvYcCV+EDFcuh8jIW932Vo9a3b/x/KzcwoqVtBHf3d3hVC8VTODBpBrAjp+rvhBuiNih3E+pS0ZgPUG6WleL6A=@vger.kernel.org X-Gm-Message-State: AOJu0YwILftnufbUsUFZ1lX+hhjczArNWMpZvxR3OhXSpY10s1+YKQI9 hGOIen2hEU9MhK7HG3zOKC+Ppt+eJDCTWHF1Qmf/9RKIAfU+zp5PMl72 X-Gm-Gg: ASbGncsvty2R6oedhzfPqhg58JTshq3bClk9HJp/LtAHLmExmqgIwpK0qhxwGGOdNOl 5wawZOIDw2yWIJ3v+2YNX6pxju4Dge1Y4cYJXGQAMoqYkOmcdtKP6Sxh/g/HeRaj4FzIVurza6s F6u+5JrEgKiB+JABgCrYg1egg6qIHLuGKwUtkiMNXPbL0aBjI2r1ybrTn+OR3sfhTKn+kasC/2S 40TjkV4J6nNnS6oRZIfO3YCmrvKaSpiQ/l2zARuZYSdZSsOcvdro4QWeWikujIFG/Fptsvovkjc RJxO7qRRNyMy+kJ3KOTRskjTT57gz87agOCGX9yqDpBsp23RMoi6rIxY15tLpNkIX+2bkwnzCoK 1EBEZzj346AkX9A2rOFG/C+es7HbU6ryvrJwgto8CjK0ujsnjEKUIwG5HdndPSn+mFPWyOYMZcb ViwbhW9xzJYbBDmg3+G+aNTg== X-Google-Smtp-Source: AGHT+IFM1rG6BQ9QLPRgC9WRSoHnGffbzNzuoM89C5S7NauJeRqdu2h4JvYetmK1mXobCaM3XLB4rA== X-Received: by 2002:a05:6a00:10ce:b0:7ab:8d8a:1024 with SMTP id d2e1a72fcca58-7c3ee197dfemr2897250b3a.7.1763631004085; Thu, 20 Nov 2025 01:30:04 -0800 (PST) Received: from archie.me ([210.87.74.117]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3ed379558sm2106554b3a.25.2025.11.20.01.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 01:30:03 -0800 (PST) Received: by archie.me (Postfix, from userid 1000) id 5E84A41117C8; Thu, 20 Nov 2025 16:30:01 +0700 (WIB) Date: Thu, 20 Nov 2025 16:30:01 +0700 From: Bagas Sanjaya To: Jim Cromie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, gregkh@linuxfoundation.org, jbaron@akamai.com Cc: ukaszb@chromium.org, louis.chauvet@bootlin.com, linux-doc@vger.kernel.org Subject: Re: [PATCH v6 04/31] docs/dyndbg: explain flags parse 1st Message-ID: References: <20251118201842.1447666-1-jim.cromie@gmail.com> <20251118201842.1447666-5-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tNRZFCgC3+laadDu" Content-Disposition: inline In-Reply-To: <20251118201842.1447666-5-jim.cromie@gmail.com> --tNRZFCgC3+laadDu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 18, 2025 at 01:18:14PM -0700, Jim Cromie wrote: > - > -A match specification is a keyword, which selects the attribute of > -the callsite to be compared, and a value to compare against. Possible > +Note: because the match-spec can be empty, the flags are checked 1st, > +then the pairs of keyword values. Flag errs will hide keyword errs: > + > + bash-5.2# ddcmd mod bar +foo > + dyndbg: read 13 bytes from userspace > + dyndbg: query 0: "mod bar +foo" mod:* > + dyndbg: unknown flag 'o' > + dyndbg: flags parse failed > + dyndbg: processed 1 queries, with 0 matches, 1 errs The snippet above is shown as long-running paragraph instead, so I wrap it in literal code block: ---- >8 ---- diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentat= ion/admin-guide/dynamic-debug-howto.rst index fd3dbae00cfc60..7690287cbe0c79 100644 --- a/Documentation/admin-guide/dynamic-debug-howto.rst +++ b/Documentation/admin-guide/dynamic-debug-howto.rst @@ -112,8 +112,8 @@ The match-spec's select *prdbgs* from the catalog, upon= which to apply the flags-spec, all constraints are ANDed together. An absent keyword is the same as keyword "*". =20 -Note: because the match-spec can be empty, the flags are checked 1st, -then the pairs of keyword values. Flag errs will hide keyword errs: +Note that since the match-spec can be empty, the flags are checked first, +then the pairs of keyword values. Flag errs will hide keyword errs:: =20 bash-5.2# ddcmd mod bar +foo dyndbg: read 13 bytes from userspace @@ -122,9 +122,9 @@ then the pairs of keyword values. Flag errs will hide = keyword errs: dyndbg: flags parse failed dyndbg: processed 1 queries, with 0 matches, 1 errs =20 -So a match-spec is a keyword, which selects the attribute of the +Hence, a match-spec is a keyword, which selects the attribute of the callsite to be compared, and a value to compare against. Possible -keywords are::: +keywords are:: =20 match-spec ::=3D 'func' string | 'file' string | Thanks. --=20 An old man doll... just what I always wanted! - Clara --tNRZFCgC3+laadDu Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCaR7flQAKCRD2uYlJVVFO ozygAQDeqV2+eAL925SBI3I8R+CQGvz0yTuUJJ9a6KUiNhCDDgEAsMy6wTgxalgk ymAwck6TVuSNIyI5PoEJGZv83FrVLgs= =wp6p -----END PGP SIGNATURE----- --tNRZFCgC3+laadDu--