From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 733492727E7 for ; Thu, 20 Nov 2025 10:11:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763633491; cv=none; b=BtZX4P2vSvBwt0Mg6L6kx0g1MYRccJ97evj1aMMnEAmimCilePgUMHq1jjiJRFVP4wQYZLpCDntEEtQo+g4DLmlBajdHc9Wrsy5yU8KJ6+k5f6zcVQ7llrueK+wrQzznLU11n4Sk3BsBC74poj+VXzlsLIr37UUEmr60+zIBRKo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763633491; c=relaxed/simple; bh=9uLkA4W4IbkFLHv+Okqtj59tjdBFCUhfyKyASqjkUs4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FU71x7qDSTGDgNp5SZ9T/6kG90MUxOsSmh30vpReaDhJi8XqYZUux9+4lJ+FedZNRhxD2wiJ5BYKRlnlQEj0r7T+qSbfedvu4NCQLjT7OG4fTP6tPt6eFi5V/1B2Qj70WvxfwPMW1zDC23J+T1dpbLvdTR7ylefpv8f8wuxQETE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GUBynf27; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CCFrv5kQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GUBynf27"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CCFrv5kQ" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AK56OgX4026178 for ; Thu, 20 Nov 2025 10:11:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= B2ybP7s2k5iT1i13ZiiSzbeQ5g0IaqgiAvpSa5BJiFA=; b=GUBynf27TzmZgkSS fXg5+2EJ/xcBHTwktJJ8Mzsbefx7PNti1oiEVvXEI/B7JKLGhKqLUx40sZob2oBd IQ0aVda6ENBt4V7NboH6EB7CV3mW4zg0D8xVS+MZNL5ME+cN1A4gCLKgbmUxGCcZ 3SAybd19zP0spPNbEbivk0owruYNXZZPNMnfcfu+DNb35GNmSwingM7+RsfxCJSr Adqv8nhoe1ISxWuqI+HoNxCMGDb3Xl0NTTiuqsPDgGrqhZytcmt13/tVCWaIE571 +oRKnDgfgXIVictlWBMXg3HmUel1Tv1ojlndds9mb757PTWN6dU/0pbuwpwaM+5g t93Ang== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ahvj3gx2e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Nov 2025 10:11:28 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-29557f43d56so10086965ad.3 for ; Thu, 20 Nov 2025 02:11:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763633487; x=1764238287; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=B2ybP7s2k5iT1i13ZiiSzbeQ5g0IaqgiAvpSa5BJiFA=; b=CCFrv5kQC+AuDxdDNe5FCo+Y7qwAA7usQ+JZY4rQCiR9WSbvbGuAtlhoM8QmdUfXnL QH4p7r0tojLfaOD8l1HAcDzLNd67IqZ6gi485pSj94Bj+28GhibfWsDEIBJTQmAU0QCH lpiYkFNcSuW8DzDYyHpnOrxLT5eX1tvYMVqD8kmVmGMjrzORV+YVkHKjL43mHxSx4z19 FtsO6hzX07g2alhCk22IL5ZNAdzA6iInQWGvQa1HZrxyz5Aohoc7vixSw8bCyq+xfIvl Oy+kmUhAwNGWcoWUos93HS27Gv/60ls1RyEvkarzpNMPwPInZhpfZl+BJE+JRCFcrM8X PAlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763633487; x=1764238287; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B2ybP7s2k5iT1i13ZiiSzbeQ5g0IaqgiAvpSa5BJiFA=; b=NqO57jPJYgfZgxctRHvk4zItSZ+X54WkHTIe+XXXp+gcKhilU0j9yZS/ekwOO2yEG1 1i1HbHtLONgKvOVSWfJYUflHiU8QUs996Zk0rDJlzSNQIGYFzzhcQRVPKhs8hzKP9Wij 0yXGY8206LDlgXoluHKpnZ1kGG8CGCZqovSuRN/yTlhxwz6HzrfKYYSklqqF1Vet7gC4 8psYAc7lo2lFEEhCALRezMVjE5GO9Sbg275QJBp1893AiuN6OQWtg+VtQzgNmDCCqKIU f2PXLCuspZ2m0Y11Txc0wwBk5L3roBWVa4TwuhsCdtgHMoEBEKrsuGngzPfqXuggqAH0 ifow== X-Forwarded-Encrypted: i=1; AJvYcCUWS1+qD6SvdPOssLxeLgIVhbkpNDCTQByfV4aSaAmZ76QSmuY+gZBYibRBtYYJZrYRYrZOVQdoyQX6hCs=@vger.kernel.org X-Gm-Message-State: AOJu0YyYw33uWaOa2rLuih/pqtNeq0zsIfN+QNbq8XWouGrjeanAaYWL 6c0HgSBLgrPZik3X/ZoXf6GoEd9Zw2Y5H2/hXO/p6+UilkuYjaOAuNXyOJpy1IJLzqDStxjivQr iSvOeBsDEYf+6AWi8GA8ACGQFJVbEz0refhLLXMj59JGPwngxdmRHSjsYKnc9x7VHMs8= X-Gm-Gg: ASbGnct+kEZjtoQpVdZJHkf8o/x4jX4pGkptPT9ohVnASUiWYHFxAIh+9FxjP+XEPso sUi8/KLGb1mNb3TGnQGFY2OxRCp5X6sO1OTS8o5CLk8SRW6qKpGsr2JGbo/3epjmMe2CDS9J8A1 KSuGTJBUG6o0N1VAxV12+15uhrq6mO+YQ/I61sJVgS8us8aqVDqqTHHT2QnSsN/E1BM9pal/shL le604Tth4Rm3KCPXgwwHuZ3StPHLE7jgjGyxzxp9oYIJoAaVqqTrUR420mJC86PpipqFZylVI27 L/pKXmFfnJTp3/ec1jqCJ8CUmiiH4e85r7BRLR9pn2u+BfFOfsmHrsc7lkeyaMSii/U1XEqbx63 ufXJf0zLZmEeAjhORq0eLfDdgugMwiAtvaGxqVLRUkOp5TQA= X-Received: by 2002:a17:90b:4a02:b0:321:9366:5865 with SMTP id 98e67ed59e1d1-34727d50dcbmr2823439a91.33.1763633487444; Thu, 20 Nov 2025 02:11:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQB+TA/zta5xrTMxfomqaYjsZRa6IblcMZ6IpKSWQ8LQF0xzZ4Li73qO23C4U756cAPhjZYg== X-Received: by 2002:a17:90b:4a02:b0:321:9366:5865 with SMTP id 98e67ed59e1d1-34727d50dcbmr2823414a91.33.1763633486966; Thu, 20 Nov 2025 02:11:26 -0800 (PST) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-347267a10b2sm2134517a91.5.2025.11.20.02.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Nov 2025 02:11:26 -0800 (PST) Date: Thu, 20 Nov 2025 15:41:21 +0530 From: Abhinaba Rakshit To: Manivannan Sadhasivam Cc: Bjorn Andersson , Konrad Dybcio , "James E.J. Bottomley" , "Martin K. Petersen" , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 1/2] soc: qcom: ice: enable ICE clock scaling API Message-ID: References: <20251001-enable-ufs-ice-clock-scaling-v1-0-ec956160b696@oss.qualcomm.com> <20251001-enable-ufs-ice-clock-scaling-v1-1-ec956160b696@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Authority-Analysis: v=2.4 cv=J8WnLQnS c=1 sm=1 tr=0 ts=691ee950 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=fzFDaW2BCt8HcSSa5e0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: TjURbgA6r5oozNxnvLNJkOz0-c4qQrM0 X-Proofpoint-ORIG-GUID: TjURbgA6r5oozNxnvLNJkOz0-c4qQrM0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIwMDA2MSBTYWx0ZWRfX6XX+QdFJYC4s 3XZzgM73Zh4PdR3q+O8C3fi4/cv37Z4sjT2uiIxmf+2XxpevC7dKbTXIHKABwqGQZ5QbyB8YETD eZkLuAUt0o/WxBOFkAcXSLdcg1fEcW/A3l9sdK92F3gzahTheDyqGq8hBbxF7/Ixw98lQHEFD7d 97tuck5ge7TT/dzRkEFMDowtgycY+FndGLirtUrSp/W6nlknJwxZjFp70QnR8flb5TpPvu/UIiW 4wdo8IowkbO+i7GNXOKkbHVZpcriIHz1KRK3f6BflQi10/slL9UdSAUKcr44rFyB+IxIuOvO608 btRXheP914kh5WAE6PYSAwOmtVO1g0yirOvgM9rVFqTZlk4zPG9IqqjOYUnbpcK3GrN6LBV/TFB E4K+EudykfXFsSVOnRivNj/Xv1eeww== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-20_03,2025-11-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 suspectscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 spamscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511200061 On Fri, Oct 03, 2025 at 10:10:28PM +0530, Manivannan Sadhasivam wrote: > On Wed, Oct 01, 2025 at 05:08:19PM +0530, Abhinaba Rakshit wrote: > > Add ICE clock scaling API based on the parsed clk supported > > frequencies from dt entry. > > > > Explain the purpose. > > > Signed-off-by: Abhinaba Rakshit > > --- > > drivers/soc/qcom/ice.c | 25 +++++++++++++++++++++++++ > > include/soc/qcom/ice.h | 1 + > > 2 files changed, 26 insertions(+) > > > > diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c > > index c467b55b41744ebec0680f5112cc4bb1ba00c513..ec8d6bb9f426deee1038616282176bfc8e5b9ec1 100644 > > --- a/drivers/soc/qcom/ice.c > > +++ b/drivers/soc/qcom/ice.c > > @@ -97,6 +97,8 @@ struct qcom_ice { > > struct clk *core_clk; > > bool use_hwkm; > > bool hwkm_init_complete; > > + u32 max_freq; > > + u32 min_freq; > > }; > > > > static bool qcom_ice_check_supported(struct qcom_ice *ice) > > @@ -514,10 +516,25 @@ int qcom_ice_import_key(struct qcom_ice *ice, > > } > > EXPORT_SYMBOL_GPL(qcom_ice_import_key); > > > > +int qcom_ice_scale_clk(struct qcom_ice *ice, bool scale_up) > > +{ > > + int ret = 0; > > + > > + if (scale_up && ice->max_freq) > > + ret = clk_set_rate(ice->core_clk, ice->max_freq); > > + else if (!scale_up && ice->min_freq) > > + ret = clk_set_rate(ice->core_clk, ice->min_freq); > > + > > + return ret; > > +} > > +EXPORT_SYMBOL_GPL(qcom_ice_scale_clk); > > + > > static struct qcom_ice *qcom_ice_create(struct device *dev, > > void __iomem *base) > > { > > struct qcom_ice *engine; > > + const __be32 *prop; > > + int len; > > > > if (!qcom_scm_is_available()) > > return ERR_PTR(-EPROBE_DEFER); > > @@ -549,6 +566,14 @@ static struct qcom_ice *qcom_ice_create(struct device *dev, > > if (IS_ERR(engine->core_clk)) > > return ERR_CAST(engine->core_clk); > > > > + prop = of_get_property(dev->of_node, "freq-table-hz", &len); > > + if (!prop || len < 2 * sizeof(uint32_t)) { > > + dev_err(dev, "Freq-hz property not found or invalid length\n"); > > We have deprecated the 'freq-table-hz' property in favor of > 'operating-points-v2'. So you should not be using it in new code. Also, throwing > error in the absence of this property is a no-go. Sure, will move the soultion using OPP-table in patchset v2. > > - Mani > > -- > மணிவண்ணன் சதாசிவம்