From: Johan Hovold <johan@kernel.org>
To: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
bsp-development.geo@leica-geosystems.com
Subject: Re: [PATCH V2] USB: serial: option: add Telit FN920C04 RNDIS compositions
Date: Thu, 20 Nov 2025 14:09:54 +0100 [thread overview]
Message-ID: <aR8TInn-XN1oUdSV@hovoldconsulting.com> (raw)
In-Reply-To: <20251120123908.1865387-1-Qing-wu.Li@leica-geosystems.com.cn>
On Thu, Nov 20, 2025 at 12:39:08PM +0000, LI Qingwu wrote:
> 0x10a1: RNDIS + tty (NMEA) + tty (AT) [+ tty (DIAG)]
> Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
> ---
What changed in v2? Always include a short changelog here after the ---
line when respinning.
> drivers/usb/serial/option.c | 6 ++++++
>
1 file changed, 6 insertions(+)
> @@ -1415,6 +1419,8 @@ static const struct usb_device_id option_ids[] = {
> .driver_info = RSVD(0) | NCTRL(2) | RSVD(3) | RSVD(4) },
> { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x10aa, 0xff), /* Telit FN920C04 (MBIM) */
> .driver_info = NCTRL(3) | RSVD(4) | RSVD(5) },
> + { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x10ab, 0xff), /* Telit FN920C04 (RNDIS) */
> + .driver_info = | NCTRL(3) | RSVD(4) | RSVD(5) },
This does not like it will even compile...
> { USB_DEVICE_AND_INTERFACE_INFO(TELIT_VENDOR_ID, 0x10b0, 0xff, 0xff, 0x30), /* Telit FE990B (rmnet) */
> .driver_info = NCTRL(5) },
> { USB_DEVICE_AND_INTERFACE_INFO(TELIT_VENDOR_ID, 0x10b0, 0xff, 0xff, 0x40) },
Johan
prev parent reply other threads:[~2025-11-20 13:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 12:39 LI Qingwu
2025-11-20 13:09 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR8TInn-XN1oUdSV@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=Qing-wu.Li@leica-geosystems.com.cn \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®