From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Ajith Anandhan <ajithanandhan0406@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: Add support for TI ADS1120
Date: Sun, 9 Nov 2025 19:05:42 +0200 [thread overview]
Message-ID: <aRDJ5ugv8xJzbxTW@smile.fi.intel.com> (raw)
In-Reply-To: <aRDJexPYkIDoE9nc@smile.fi.intel.com>
On Sun, Nov 09, 2025 at 07:03:56PM +0200, Andy Shevchenko wrote:
> On Sun, Nov 09, 2025 at 07:41:19PM +0530, Ajith Anandhan wrote:
...
> Many are still missing... Please, follow IWYU principle.
>
> > +#include <linux/bitfield.h>
> > +#include <linux/cleanup.h>
> > +#include <linux/delay.h>
>
> > +#include <linux/device.h>
>
> Not see why you need this and not
>
> dev_printk.h
> device/devres.h
Actually even devres.h is not needed if I did not miss anything.
> instead.
>
> > +#include <linux/err.h>
> > +#include <linux/module.h>
> > +#include <linux/regmap.h>
> > +#include <linux/spi/spi.h>
> > +#include <linux/unaligned.h>
...
Overall looks much better than previous version.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-11-09 17:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-09 14:11 [PATCH v2 0/2] iio: adc: ti-ads1120: Add driver and dt-binding Ajith Anandhan
2025-11-09 14:11 ` [PATCH v2 1/2] dt-bindings: iio: adc: Add TI ADS1120 binding Ajith Anandhan
2025-11-10 7:59 ` Krzysztof Kozlowski
2025-11-15 18:31 ` Jonathan Cameron
2025-11-18 0:19 ` David Lechner
2025-12-15 14:49 ` Ajith Anandhan
2025-12-15 15:58 ` David Lechner
2025-11-09 14:11 ` [PATCH v2 2/2] iio: adc: Add support for TI ADS1120 Ajith Anandhan
2025-11-09 17:03 ` Andy Shevchenko
2025-11-09 17:05 ` Andy Shevchenko [this message]
2025-11-10 10:17 ` kernel test robot
2025-11-15 18:45 ` Jonathan Cameron
2025-11-18 14:04 ` David Lechner
2025-12-15 16:13 ` Ajith Anandhan
2025-12-15 16:36 ` David Lechner
2025-12-15 16:49 ` Ajith Anandhan
2025-12-15 17:00 ` Andy Shevchenko
2025-12-15 17:38 ` Ajith Anandhan
2025-12-15 17:42 ` David Lechner
2025-12-15 17:50 ` Ajith Anandhan
2025-12-21 18:57 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRDJ5ugv8xJzbxTW@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=ajithanandhan0406@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®