From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: javier.carrasco@wolfvision.net, neal@gompa.dev,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tipd: mark as orientation aware
Date: Mon, 10 Nov 2025 10:21:22 +0200 [thread overview]
Message-ID: <aRGggpULQM3xH-pS@kuha.fi.intel.com> (raw)
In-Reply-To: <20251107151311.2089806-1-peter@korsgaard.com>
Fri, Nov 07, 2025 at 04:13:10PM +0100, Peter Korsgaard kirjoitti:
> The driver contains orientation detection logic and correctly calls
> typec_set_orientation(), but forgets to set the orientation_aware
> capability, so the orientation value is not visible in sysfs - Fix that.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tipd/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 2b1049c9a6f3..d561032a2970 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -1695,6 +1695,7 @@ tps25750_register_port(struct tps6598x *tps, struct fwnode_handle *fwnode)
> typec_cap.data = ret;
> typec_cap.revision = USB_TYPEC_REV_1_3;
> typec_cap.pd_revision = 0x300;
> + typec_cap.orientation_aware = true;
> typec_cap.driver_data = tps;
> typec_cap.ops = &tps6598x_ops;
> typec_cap.fwnode = fwnode;
> --
> 2.39.5
--
heikki
prev parent reply other threads:[~2025-11-10 8:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 15:13 Peter Korsgaard
2025-11-10 8:21 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRGggpULQM3xH-pS@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=javier.carrasco@wolfvision.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neal@gompa.dev \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®