Re: [PATCH] i3c: master: add WQ_PERCPU to alloc_workqueue users

[Frank Li <Frank.li@nxp.com>]

On Fri, Nov 07, 2025 at 11:28:30PM +0100, Sebastian Andrzej Siewior wrote:
> On 2025-11-07 16:00:06 [-0500], Frank Li wrote:
> > > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> > > index d946db75df70..519b98c37ac7 100644
> > > --- a/drivers/i3c/master.c
> > > +++ b/drivers/i3c/master.c
> > > @@ -2925,7 +2925,7 @@ int i3c_master_register(struct i3c_master_controller *master,
> > >  	if (ret)
> > >  		goto err_put_dev;
> > >
> > > -	master->wq = alloc_workqueue("%s", 0, 0, dev_name(parent));
> > > +	master->wq = alloc_workqueue("%s", WQ_PERCPU, 0, dev_name(parent));
> >
> > Maybe off topic, I think it is not neccesary to create wq for IBI at all.
> > it can directly use system_bh_wq, or other wq.
>
> Do you really meant system_bh_wq or would system_unbound_wq do the job?
> The _bh_ one would imply softirq usage, I don't think you want that.

My major means is that not neccessary to alloc a work queue for IBI. Use
one of system predefined should be enough. system_unbound_wq is good
candidate.

Your change is also good, let's wait for more reviewer's comments.

Frank

>
> > Frank
>
> Sebastian