From: Nicolas Schier <nsc@kernel.org>
To: Abel Vesa <abel.vesa@linaro.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kbuild: install-extmod-build: Properly fix CC expansion when ccache is used
Date: Tue, 11 Nov 2025 14:03:10 +0100 [thread overview]
Message-ID: <aRM0DmrBq-neaNYw@derry.ads.avm.de> (raw)
In-Reply-To: <20251111-kbuild-install-extmod-build-fix-cc-expand-third-try-v2-1-15ba1b37e71a@linaro.org>
On Tue, Nov 11, 2025 at 08:43:51AM +0200, Abel Vesa wrote:
> Currently, when cross-compiling and ccache is used, the expanding of CC
> turns out to be without any quotes, leading to the following error:
>
> make[4]: *** No rule to make target 'aarch64-linux-gnu-gcc'. Stop.
> make[3]: *** [Makefile:2164: run-command] Error 2
>
> And it makes sense, because after expansion it ends up like this:
>
> make run-command KBUILD_RUN_COMMAND=+$(MAKE) \
> HOSTCC=ccache aarch64-linux-gnu-gcc VPATH= srcroot=. $(build)= ...
>
> So add another set of double quotes to surround whatever CC expands to
> to make sure the aarch64-linux-gnu-gcc isn't expanded to something that
> looks like an entirely separate target.
>
> Fixes: 140332b6ed72 ("kbuild: fix linux-headers package build when $(CC) cannot link userspace")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> Changes in v2:
> - Moved the new double quotes inside of single ones, to be able
> to drop the escape, like Nathan suggested.
> - Re-worded the commit message according to the above change.
> - Link to v1: https://lore.kernel.org/r/20251110-kbuild-install-extmod-build-fix-cc-expand-third-try-v1-1-5c0ddb1c67a8@linaro.org
> ---
> scripts/package/install-extmod-build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Just as a note: the fix is only required for build rpm packages. For
the Debian package call of install-extmod-build
CC="${DEB_HOST_GNU_TYPE}-gcc" is used, no matter what was given to make
deb-pkg.
Reviewed-by: Nicolas Schier <nsc@kernel.org>
next prev parent reply other threads:[~2025-11-11 13:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 6:43 Abel Vesa
2025-11-11 13:03 ` Nicolas Schier [this message]
2025-11-11 14:28 ` Abel Vesa
2025-11-11 14:33 ` Nicolas Schier
2025-11-12 5:36 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRM0DmrBq-neaNYw@derry.ads.avm.de \
--to=nsc@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®