From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 570932D94B7 for ; Wed, 12 Nov 2025 06:26:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762928783; cv=none; b=Bg8DrRGA5SJyFLQ079TxTkCYgoYUyoe9idqZBGLjowtpQd5777vKRWjwAHXJkzXPFvel7+9uUX5ISUKAKydLpe8QMVB6jJfbuNDvRGYJnaqHENgibirGDYtDQWQL65nW5lBa5L/TiddCY7wqn5PMlaAqgDevwGw6UJM+P9xBdcU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762928783; c=relaxed/simple; bh=7cNsMy0TilUH2idBCaLTV0/wx4B4LwinQE6xmQeQ74I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VSd4v8TtsIj0JcRr4Ju7AYfP+4LM6qaAf1sB9LjcSNFn9ExzvTz5GnSUx76JaMpbYn3sPk0+veFPy14vKzAzzFewvsskD0GJG4FIUO32S4/JEI13DtDtNX0oUQHR1DprMQq7RUx+5+6AtDRNH7WJ+b9UqyRkitDpiKBSSAOgon8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JazUFIiu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kwM8tqYK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JazUFIiu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kwM8tqYK" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ABN3dOA3924235 for ; Wed, 12 Nov 2025 06:26:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=DJ2gU5bCjGTpIsiHGccNxiCb rIQ97KDbuRdyIzahWDs=; b=JazUFIiuuzfaacaTw7dr9rK/xPZ7LOCPtZV0WbHz OQ87MZZ9aUw9Hednlk72rLLka8qH20ZzD71Dpgjve2Zb7zwa3x6JmiQt7dKyrS/S LfyOs71mC1tOFvak3n1hSk8oYu7s/tA7D3B/FQrQT5Bap1V6xjXOnaATmYrYg6Nb +NviipPD3seekW1GSwzQ9IObs7r6dOw2XFWuhS+rLNFMZ+fQW51WJK2s/PAoV1/q KOklJrkom3NP62rvr7T1jQmxJ2nunWf7MXf9tMbztyroCBEO3WYkTwNO5XGnn/Zb mBRRLxyzDq6jgnTvxgFc0VUsWyyWT2cJF8fiR6ChC7nCdQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4acefus0g9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Nov 2025 06:26:20 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-295952a4dd6so5743675ad.1 for ; Tue, 11 Nov 2025 22:26:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1762928780; x=1763533580; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DJ2gU5bCjGTpIsiHGccNxiCbrIQ97KDbuRdyIzahWDs=; b=kwM8tqYK6lKVDueNN/ZliYPFkb8CKOVfsparR6nxQa4c8sfQQVrNBr6W7c7ga2G3ne tuF/QwDWocMkbqWisBUq7XNM+KQeWFgFuNIhhGh7Aiyq3ckrbY/sEHnxTHHjj8CH2AN9 f36ckYgXh8gw0q6sFeLk5rcIoabXm1VTqjTYkr2a1/VwYXGA7WAEKbu/kI75nXdoAcTE Ldh7ik3zA0BONa8Svx00Ph5i6igTl9Fqy3/tYJebsQPpPjlf2jBhjCX7yuvmSTWHh1fZ hQzvfQRf243C8XUGLvhB/WvvemAG7LkCBNfvVszY2GZu6SQq7JLSKi+H8CDgKR4iFuay bDLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762928780; x=1763533580; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DJ2gU5bCjGTpIsiHGccNxiCbrIQ97KDbuRdyIzahWDs=; b=w2LgmTHuKvUK5DLxT8BgP2JSmrCzIHTgnU8hBjaFhB3hKsRsrtGnFiLYEJmSrl6QEW DVXSdYPNSVq4G6rIlS+qNbCiGAXFfPJjlctKxCxFvJYoD9QzuLAoxTHYOt2ajhcpANnO 70PxrYsvPlPI8H5+qnIHNqOQ3cmTVvGfPijO9bKVPY3SefHl03US7N+kDB6r85fkVJJ1 kVo301NRhO+QV6HTh+wjnYlAtql9ADcXVPkEw7qabCL7zw7an+ex2e/6ot/5f3IlL9Cu oMCzf5/WIQu/Qpw0m3gdXyDCnA7RZ1kaOZ27CEhs/IP41WsckH3TqeBgk9WunIdziW0k jlHw== X-Forwarded-Encrypted: i=1; AJvYcCUoOanQnZGF9Nma+ra2HXV1nc6ew6WjPL4f1p+jSNEMEhKz6Aez2o7ZDrRessnjSii0qc9wizzEDoG8hhw=@vger.kernel.org X-Gm-Message-State: AOJu0YwHqgmeutMH5tqSLIUWBN9pbyMAbL/pQGwXMMCdXFZ9dtI6EY8n h6ZouB1w/7yz+VxLwYhDPDBRwuVqFW4OlFsGJ44nS/LOsh/4nK+GN52Brx1tfu8mlVSUiUyeRmx 865T2YlKSjX9nEu3guohA27ICaeDMRq7OH22w4kMyW7n1Q76dXd8VQEXws/yMSxQofHc= X-Gm-Gg: ASbGnctZo7bDsF6BbGIVf6qrbyLoYmqsIf6q04idnMVqhQu3quO6olsBGLte18crQ2W NI2yRAeaombq2Mrx7gQQcy5wl9ycbPQp7CVO5HxdzabOx9tPagVIJy9bmImCUxhW8Uz2Wux4fGI sJ95lBuTLlbXU50xo7GNnLKJP+lZnPxaC2CMkEQJHEsVh9WlaUGFmAQMplKUsGcb87KZtoIwVnH kwhjurS80omdE7dPh4ep/RC/qnVnRS0Kw2WWm5hwEo7AR7bdUBmSb7uqptzGca5Zwo2OF1BhXgd gHep7PkQdrcR/OEX7M615uZKz4VIhY9rtl1fcGk54mJNznJ9pHXn0tsAUZp/N98d/Sb6dR/iZQH fA03zgKA0BSwgmYaBLHtH9z096vNNVbA+l4+D X-Received: by 2002:a17:902:d543:b0:295:99f0:6c65 with SMTP id d9443c01a7336-29840b4b1dcmr73920615ad.30.1762928780010; Tue, 11 Nov 2025 22:26:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEdPYGS02Zp2ukMNxCKwDxvQGW+xbsrHTAJZPviBeLRtQAtKBwye+kN8OTi2mmGMSLVJJUS0g== X-Received: by 2002:a17:902:d543:b0:295:99f0:6c65 with SMTP id d9443c01a7336-29840b4b1dcmr73920155ad.30.1762928779205; Tue, 11 Nov 2025 22:26:19 -0800 (PST) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-343e1cdfe29sm426981a91.3.2025.11.11.22.26.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Nov 2025 22:26:18 -0800 (PST) Date: Wed, 12 Nov 2025 11:56:14 +0530 From: Abhinaba Rakshit To: Bjorn Andersson Cc: Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 2/2] ufs: host: scale ICE clock Message-ID: References: <20251001-enable-ufs-ice-clock-scaling-v1-0-ec956160b696@oss.qualcomm.com> <20251001-enable-ufs-ice-clock-scaling-v1-2-ec956160b696@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-GUID: w_cX2ROT2198qRrZa2LmTHnFtwSOMS9W X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTEyMDA0OSBTYWx0ZWRfX7jiX7RcduFZ2 kwwnGxI3sKqZ5eqmgcoqKTSIZ+G1hm7Vom2EQL5KAybB8qx6wO5XcLc0xtgiAwmmq1d8v8MEhWK N3jLsJyz1P1XeDm+2hzSx0zWjf/WryyzGtIVKbrKtmUK9cP6Bn/j6Q9V6lavzwmtTc5T6ovVACi eDAkr9kIZvr42KnOuPiC028N/9sYIKZNZY3QFLQkK4H6G080DBHDBYTWeRUHCY44QS3+RvOjI/8 nc7TJQJM0GGDGSLOy0Vc5CejdUGrhJnYcqJX/qdl5ElLIIo/cP40n1JScL11vK00GJHXZYF/4b4 4pxGvwXv+lnJfk2BObjnZYyLhgMZirQfEkHeSjZ9cvT/KQDklnTnUPBH5fe0mN5YT3xRhihPiYR ZhIJB5SFsoHlrSr6WWLTkdrb/QE2IQ== X-Proofpoint-ORIG-GUID: w_cX2ROT2198qRrZa2LmTHnFtwSOMS9W X-Authority-Analysis: v=2.4 cv=H8HWAuYi c=1 sm=1 tr=0 ts=6914288c cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=fj1KHxAH09wAVEZJ720A:9 a=CjuIK1q_8ugA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-12_02,2025-11-11_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 clxscore=1015 impostorscore=0 suspectscore=0 priorityscore=1501 spamscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511120049 On Wed, Oct 01, 2025 at 10:15:27PM -0500, Bjorn Andersson wrote: > On Wed, Oct 01, 2025 at 05:08:20PM +0530, Abhinaba Rakshit wrote: > > Scale ICE clock from ufs controller. > > > > This isn't a good commit message. Sure, will add more details in patchset v2. > > Regards, > Bjorn > > > Signed-off-by: Abhinaba Rakshit > > --- > > drivers/ufs/host/ufs-qcom.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > > index 3e83dc51d53857d5a855df4e4dfa837747559dad..2964b95a4423e887c0414ed9399cc02d37b5229a 100644 > > --- a/drivers/ufs/host/ufs-qcom.c > > +++ b/drivers/ufs/host/ufs-qcom.c > > @@ -305,6 +305,13 @@ static int ufs_qcom_ice_prepare_key(struct blk_crypto_profile *profile, > > return qcom_ice_prepare_key(host->ice, lt_key, lt_key_size, eph_key); > > } > > > > +static int ufs_qcom_ice_scale_clk(struct ufs_qcom_host *host, bool scale_up) > > +{ > > + if (host->hba->caps & UFSHCD_CAP_CRYPTO) > > + return qcom_ice_scale_clk(host->ice, scale_up); > > + return 0; > > +} > > + > > static const struct blk_crypto_ll_ops ufs_qcom_crypto_ops = { > > .keyslot_program = ufs_qcom_ice_keyslot_program, > > .keyslot_evict = ufs_qcom_ice_keyslot_evict, > > @@ -339,6 +346,11 @@ static void ufs_qcom_config_ice_allocator(struct ufs_qcom_host *host) > > { > > } > > > > +static inline int ufs_qcom_ice_scale_clk(struct ufs_qcom_host *host, bool scale_up) > > +{ > > + return 0; > > +} > > + > > #endif > > > > static void ufs_qcom_disable_lane_clks(struct ufs_qcom_host *host) > > @@ -1636,6 +1648,8 @@ static int ufs_qcom_clk_scale_notify(struct ufs_hba *hba, bool scale_up, > > else > > err = ufs_qcom_clk_scale_down_post_change(hba, target_freq); > > > > + if (!err) > > + err = ufs_qcom_ice_scale_clk(host, scale_up); > > > > if (err) { > > ufshcd_uic_hibern8_exit(hba); > > > > -- > > 2.34.1 > >