From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF52327586C for ; Fri, 14 Nov 2025 16:25:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763137547; cv=none; b=PnY5aMZiKHFuhybLJ0tS1V42gA/7j/QBcUprKeLVvBAfZV5/qaLLh4vIPvnjI4AeX7jcCehueezVF+f6N/hudW9WMmygbllmJ0DDF8rXqoPZUHW+BwwKEYT8Yte+xhZcz4SfqR3PiQRFCqu3e7q3bEpY3TOdmECnZFmKGE0sQXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763137547; c=relaxed/simple; bh=DmJBwefMZoeCr6KZ8b+qwY+RIqc/g/yjHguKPhXfyfs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kxefcuPI+MXART+5nMsRkggspyVqHEZuDSHwiXSHPJhgxn8LP7/5tuxH7fyhMFi3Bg1i3H+C67O6hO0j8rB/ykPjd9yQVrt1QTByG+9QMpms1DhQiJot9Y6g8E7ZglG+vetwwtDwrA0QvKv6EKaIAIWXCjmEMHot62Osz+Z9vSg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H2DStiBu; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H2DStiBu" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2955623e6faso19390085ad.1 for ; Fri, 14 Nov 2025 08:25:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763137545; x=1763742345; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yDPYrZ5jC9FU9ONafAxEWetdxuWbNZj9O50TUKzl3xg=; b=H2DStiBu0xpXV0vg42Lx8xCl3KdFF0Ws5brOIz2uW4gtoXeERTOGrtXc4jyaS3le8o aLdHNJJ7Pj6wAXkT8urpoYsw+e1KpIsP3mIUzhUEtq0QZ59D7VUYYdSZEngRuagBcG+r G4Vo6WFjhNVj868VYFmmK7fwsQartDsJAuYiV0B18QGrggQdMLUcb4Tz9DHKhs86Z5hX TEDe/faLDLrYzW+BtTlBRCBuYS137F69mKDjHI5GfaTjY36UuxtLbB3ph0KyVTzEjKr9 QCJUSbu6FmEhrufuZ3B0BBo24mTAIbuDDrCymWLJM3H9ZIpe6BrfoducwNICofa+OkME bipg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763137545; x=1763742345; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yDPYrZ5jC9FU9ONafAxEWetdxuWbNZj9O50TUKzl3xg=; b=nHnBdvFiCvCW9i55v2v3Jkjhbkj4007vFhll+VjHRqsBR5PLXWkHZUXY3tU/TyaESM le2B7ZWlICrN66LyqAmxk13mStaIeDqE2Ok/X6rthuZrotgn1OTHvg7UCuwana51weRl bgRDJIHNORnKof61FmNWqp2oIv0hL9Khxit4nvsXF21fuOf5yhNR/WNbMU34qDMQjiWO DNvGRI8nyuxjlrOToNDZuu4TGcjJ1HRGU6uD5Rap8RK6u6W7eo48Z4NQg87+d7b69VnQ 7sDvspQA6r9Jn1sFXpfYNC2wK32j4MlYjcMeapN9bWmGeTgfzhH3ICX7lqijoxPi3Q/B rDig== X-Forwarded-Encrypted: i=1; AJvYcCVvKHetEZB2ZZaqU0gR6TZyVa+Q2zRu8GZZS4MQj6JFgwzLZ+Kzbv9e/k2VP4jnPRBp5ViXXqm85OZJj8k=@vger.kernel.org X-Gm-Message-State: AOJu0YxCse6gsnDQmSq49sPj0jaNWZR0O1N3mOMhVVAjugVTalDgTiJN 5ZZcvXg+3AuH7arnJUWHI7Lt5vuBzOPQxShaSwjoEua9sduYom+lhxhy X-Gm-Gg: ASbGncvxhBEHqfC6Z+1zerkieVoqkrTlEehosKM/zuAJyjwpbQOcZEtkCEmZznJaCZO fG//2SK0T75E6n7QN3P/EMUBwC3NPGEDYAg9zFUpRoXW5ffq/U4iCwt1roZYrlp6+eK5Ce+eH6W YHDZzwaAqakt9+g+5zKWqDtukuqxmhv5sls9mNBTDXmhFcoicrh9R7qKF/Fov1w9QmMEFSqXYy9 fN1YokazJIuCaZ0B4mvTYD3zUxr+LJAr0dCp/+qXiTvxZPxWxvpgEbvUsRuKvAE7XhraXGpd+4i xCvW6VFOCnHL+rIrqzBAIln+YHDCNH6v6pICkOTrrjiM2FFKffvnqaOnyQa2Z0GFuKhpF8xtXJj pFNl9y+m5ZiRVUKXl3kyF+YiP5HZbrJfiMocMMy1C5H57p2iQDGsxyQyxE+kK4W09GIt5p5wzpE lOZLW1en6/6g== X-Google-Smtp-Source: AGHT+IEAMJrHxlc2wb2LmODar5xSV/mQiDepjY/vcKYRxsAv+KWjopJ3xQRNP9uvvpTXkNoqfctKLg== X-Received: by 2002:a05:7023:a82:b0:119:e55a:9c09 with SMTP id a92af1059eb24-11b4120f614mr1056255c88.37.1763137544997; Fri, 14 Nov 2025 08:25:44 -0800 (PST) Received: from localhost ([2804:30c:1661:8a00:578a:911c:ac25:24a6]) by smtp.gmail.com with UTF8SMTPSA id a92af1059eb24-11b0608860fsm9538769c88.5.2025.11.14.08.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 08:25:43 -0800 (PST) Date: Fri, 14 Nov 2025 13:27:04 -0300 From: Marcelo Schmitt To: Pavel Zhigulin Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Greg Kroah-Hartman , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] iio: adc: ad7280a: handle spi_setup() errors in probe() Message-ID: References: <20251114151302.2255348-1-Pavel.Zhigulin@kaspersky.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251114151302.2255348-1-Pavel.Zhigulin@kaspersky.com> On 11/14, Pavel Zhigulin wrote: > The probe() function ignored the return value of spi_setup(), leaving SPI > configuration failures undetected. If spi_setup() fails, the driver should > stop initialization and propagate the error to the caller. > > Add proper error handling: check the return value of spi_setup() and return > it on failure. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 2051f25d2a26 ("iio: adc: New driver for AD7280A Lithium Ion Battery Monitoring System") > Signed-off-by: Pavel Zhigulin Reviewed-by: Marcelo Schmitt As patch suggestion, we could also have spi-cpha: true in ad7280a dt-binding. Thanks, Marcelo > --- > drivers/iio/adc/ad7280a.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/ad7280a.c b/drivers/iio/adc/ad7280a.c > index dda2986ccda0..63fceb239bd8 100644 > --- a/drivers/iio/adc/ad7280a.c > +++ b/drivers/iio/adc/ad7280a.c > @@ -1024,7 +1024,9 @@ static int ad7280_probe(struct spi_device *spi) > > st->spi->max_speed_hz = AD7280A_MAX_SPI_CLK_HZ; > st->spi->mode = SPI_MODE_1; > - spi_setup(st->spi); > + ret = spi_setup(st->spi); > + if (ret < 0) > + return ret; > > st->ctrl_lb = FIELD_PREP(AD7280A_CTRL_LB_ACQ_TIME_MSK, st->acquisition_time) | > FIELD_PREP(AD7280A_CTRL_LB_THERMISTOR_MSK, st->thermistor_term_en); > -- > 2.43.0 > >