From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A49F6EAF9 for ; Sun, 16 Nov 2025 07:16:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763277396; cv=none; b=VQSou4FhuDBtpgq8q1AXaQwrWb2fMnC1WFyBRhhEvfc1d9oKsacXgo9zTIkaRwYH93n58SVxmTKTleh0DiqtWE6UIKi+ZZnI3NHSTNm0BywuJeKg61nyzjduOnIdzlIu0/t6hZC4+Fcgvj8VWpL6tZWRVImxeUX/sCxt+uxLLdI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763277396; c=relaxed/simple; bh=v69hWEm8w/VwWKJJxPmbTs2HDW8EVLtiqohTD1bYH9E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sOKBM6OSxIVN4yv1lBCXrR6kUgSjISya2+4Z/pWQKb7cjK4JpqHo6w7J6MesyKjaVgBwoop+ZXvtqha4jT+CcV5JRFByWEL27g0VefTgUwE3kB4NLmFpWYLRas6fsLEfceL4RW/lkEUzWM9Cq2uagf9ZOljBULDhRjKDnIckspg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=XqBouYYb; arc=none smtp.client-ip=115.124.30.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="XqBouYYb" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1763277385; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; bh=vVaE8jewd1gMJDqOLSsTftYN71054KK0zhIS3t5OjSs=; b=XqBouYYbkZtRcb/ttwgrZadP76cuNMtSFlI06SDVyQWDiCG3YwxqRSZUHkf0ewfBKxuWtbILt8t3X3OBTMQfmyr2u3lvrcLneWsfDneqxd9adHA3BeP4Lt2sKrROvQs2Z+SuJJDtCw/62H9GyCZikY+G/D5pvm5gMlTz5yCl7co= Received: from localhost(mailfrom:feng.tang@linux.alibaba.com fp:SMTPD_---0WsRqPPE_1763277384 cluster:ay36) by smtp.aliyun-inc.com; Sun, 16 Nov 2025 15:16:24 +0800 Date: Sun, 16 Nov 2025 15:16:23 +0800 From: Feng Tang To: Petr Mladek Cc: Andrew Morton , Lance Yang , Jonathan Corbet , paulmck@kernel.org, Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] hung_task: Add hung_task_sys_info sysctl to dump sys info on task-hung Message-ID: References: <20251113111039.22701-1-feng.tang@linux.alibaba.com> <20251113111039.22701-3-feng.tang@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Fri, Nov 14, 2025 at 04:36:39PM +0100, Petr Mladek wrote: > On Thu 2025-11-13 19:10:37, Feng Tang wrote: > > When task-hung happens, developers may need different kinds of system > > information (call-stacks, memory info, locks, etc.) to help debugging. > > > > Add 'hung_task_sys_info' sysctl knob to take human readable string like > > "tasks,mem,timers,locks,ftrace,...", and when task-hung happens, all > > requested information will be dumped. (refer kernel/sys_info.c for more > > details). > > > > Meanwhile, the newly introduced sys_info() call is used to unify some > > existing info-dumping knobs. > > > > Suggested-by: Petr Mladek > > Signed-off-by: Feng Tang > > It would have been better to split the refactoring (moving some logic > from check_hung_task()) into a separate patch. Yes, it would be cleaner to have a functional patch and a clenup one. Will pay more attention in the future. > But the result looks good. Feel free to use: > > Reviewed-by: Petr Mladek Thank you! - Feng