From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Jon Kohler <jon@nutanix.com>
Subject: Re: [PATCH 0/4] KVM: x86: Cleanup #MC and XCR0/XSS/PKRU handling
Date: Mon, 17 Nov 2025 10:35:00 -0800 [thread overview]
Message-ID: <aRtq1BUthxWcAYLT@google.com> (raw)
In-Reply-To: <176254658743.821204.2042588290407024138.b4-ty@google.com>
On Mon, Nov 10, 2025, Sean Christopherson wrote:
> On Thu, 30 Oct 2025 15:42:42 -0700, Sean Christopherson wrote:
> > This series is the result of the recent PUCK discussion[*] on optimizing the
> > XCR0/XSS loads that are currently done on every VM-Enter and VM-Exit. My
> > initial thought that swapping XCR0/XSS outside of the fastpath was spot on;
> > turns out the only reason they're swapped in the fastpath is because of a
> > hack-a-fix that papered over an egregious #MC handling bug where the kernel #MC
> > handler would call schedule() from an atomic context. The resulting #GP due to
> > trying to swap FPU state with a guest XCR0/XSS was "fixed" by loading the host
> > values before handling #MCs from the guest.
> >
> > [...]
>
> Applied to kvm-x86 misc, thanks!
>
> [1/4] KVM: SVM: Handle #MCs in guest outside of fastpath
> https://github.com/kvm-x86/linux/commit/6e640bb5caab
> [2/4] KVM: VMX: Handle #MCs on VM-Enter/TD-Enter outside of the fastpath
> https://github.com/kvm-x86/linux/commit/8934c592bcbf
> [3/4] KVM: x86: Load guest/host XCR0 and XSS outside of the fastpath run loop
> https://github.com/kvm-x86/linux/commit/3377a9233d30
> [4/4] KVM: x86: Load guest/host PKRU outside of the fastpath run loop
> https://github.com/kvm-x86/linux/commit/7df3021b622f
I've dropped these for now as patch 2 broke TDX. I'll send a v2 shortly.
prev parent reply other threads:[~2025-11-17 18:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 22:42 Sean Christopherson
2025-10-30 22:42 ` [PATCH 1/4] KVM: SVM: Handle #MCs in guest outside of fastpath Sean Christopherson
2025-10-30 22:42 ` [PATCH 2/4] KVM: VMX: Handle #MCs on VM-Enter/TD-Enter outside of the fastpath Sean Christopherson
2025-11-17 12:38 ` Tony Lindgren
2025-11-17 15:47 ` Sean Christopherson
2025-11-18 5:33 ` Tony Lindgren
2025-11-17 16:30 ` Edgecombe, Rick P
2025-10-30 22:42 ` [PATCH 3/4] KVM: x86: Load guest/host XCR0 and XSS outside of the fastpath run loop Sean Christopherson
2025-11-05 10:42 ` Binbin Wu
2025-11-05 14:43 ` Sean Christopherson
2025-11-06 1:55 ` Binbin Wu
2025-10-30 22:42 ` [PATCH 4/4] KVM: x86: Load guest/host PKRU " Sean Christopherson
2025-10-31 17:58 ` Jon Kohler
2025-10-31 20:52 ` Sean Christopherson
2025-11-03 15:32 ` Jon Kohler
2025-10-31 17:58 ` [PATCH 0/4] KVM: x86: Cleanup #MC and XCR0/XSS/PKRU handling Jon Kohler
2025-10-31 23:35 ` Edgecombe, Rick P
2025-11-10 15:37 ` Sean Christopherson
2025-11-17 18:35 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRtq1BUthxWcAYLT@google.com \
--to=seanjc@google.com \
--cc=jon@nutanix.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®