From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E76830F922; Tue, 18 Nov 2025 09:30:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763458234; cv=none; b=GDCeAm+rXe8vYMEFXlkyfL4yAPJF1nZcXRNDeC9QlCVBMjoaewz4AY86AFp3Nsljo0fYyrf/7qmlQmdzC/YFvYegQU2L4PWKivh7XoIi8/HPyxgREDARR3DxY7xs7gI2LyTreS1peKKLIDeG3L45dsoWVWb+FPU54ZtJxtihUHo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763458234; c=relaxed/simple; bh=CI0PsB0EzCBT/vkFRETcQNlw9KsBGj6g3PpqTbX+BGY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=otOPG6AruI61JcxYUD+4TgF/tntkUxuGkK6urTOuaQvwEE7rUe8sCQl6tui55BwOBXg+lwmZhYjruTxrqRSIZmwhyHgtJrEvd7V10CVFeZMorMpoJvN3XocUClq5C9vdEDteDRU7OkFRzMVAZXx+7VWHwUq0M5NW1ZbqctIBj7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HIii7xuB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HIii7xuB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B24D4C2BC86; Tue, 18 Nov 2025 09:30:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763458231; bh=CI0PsB0EzCBT/vkFRETcQNlw9KsBGj6g3PpqTbX+BGY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HIii7xuBjx0KRLn6b9BXUaNFNNqbPNbWYeiBCmj21wnxCemDy8ojhTCITSIUUFpgT JiC1AAsyAm9LNQB7ctPS/J5YEIDYPmQYg17JfU6m+sh7d+EJRk/40nRaon6zRGUhwC j4YTSUCtcW+QzYvAt50rKLqihakl7P5NYJBy70YBOJMha8PiJIchSmGmbklQvTggRX MxqdIQzR/JRb8KOHuNKAX2QSKgVAlzTmlz668TIedye4ZxrtvJBfWpkOLNvPhMSBCd nXG1cfviugI6dsN7AXhkeZjcijKGY0rpp+fJ6GYpYR4qpe+HnAvovqpKP6xOd3hOZR cCXbN9xkJFGdQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vLI2f-000000000e5-2mqI; Tue, 18 Nov 2025 10:30:29 +0100 Date: Tue, 18 Nov 2025 10:30:29 +0100 From: Johan Hovold To: Vladimir Zapolskiy Cc: Vinod Koul , Ludovic Desroches , Viresh Kumar , Andy Shevchenko , Vinicius Costa Gomes , Dave Jiang , Piotr Wojtaszczyk , =?utf-8?Q?Am=C3=A9lie?= Delaunay , Maxime Coquelin , Alexandre Torgue , Peter Ujfalusi , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 06/15] dmaengine: lpc18xx-dmamux: fix device leak on route allocation Message-ID: References: <20251117161258.10679-1-johan@kernel.org> <20251117161258.10679-8-johan@kernel.org> <2e38039b-f136-44c6-829c-1d98783bbb1a@mleia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e38039b-f136-44c6-829c-1d98783bbb1a@mleia.com> Hi Vladimir, On Mon, Nov 17, 2025 at 09:24:48PM +0200, Vladimir Zapolskiy wrote: > On 11/17/25 18:12, Johan Hovold wrote: > > Make sure to drop the reference taken when looking up the DMA mux > > platform device during route allocation. > > > > Note that holding a reference to a device does not prevent its driver > > data from going away so there is no point in keeping the reference. > > > > Fixes: e5f4ae84be74 ("dmaengine: add driver for lpc18xx dmamux") > > Cc: stable@vger.kernel.org # 4.3 > > Signed-off-by: Johan Hovold > Reviewed-by: Vladimir Zapolskiy Thanks for reviewing. Johan