From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D37525785E for ; Tue, 18 Nov 2025 15:19:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763479143; cv=none; b=azV3AhjbeS0sqIc22q1GM1DYwOl79dNmi2NDflAlk8heUn37sQUmdwLoYYtUUFSRHC+c4D1T9zYIq2ipyX67RSuIt1pRSR5FkQq4egvhFwPDZDMldUfdRdDrgiblfiP3g+MV7YUFZLpEa1ZUMtZKATcn52/Xmm6Aic8PKOEbkGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763479143; c=relaxed/simple; bh=/x2SQtZk9gwZGHlMIXPo7wuYMStd+07Ty0pcS3s55po=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uVsOF7GtdUp3UJAiyMjUi/EEJeCiPZ8wPAWzQUQvS1u4qclZNm+6q0sArDoHoU2hIH5BCQM5VLsTSHECrgFqq0/HPKmEAIdoK/JdfkeP+D6N6uNTQQFQ0SqlRxEoS5d5sIhmMs4sMTLzDnjHQN8Ry8uqkAortppZhxkKlpGK4i0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=bNO1aJeB; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="bNO1aJeB" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MLsd4qAXxPWmEcZ//svKd319GCI2W0dgLquvbJUwSxQ=; b=bNO1aJeB7FzN24YGVojvkx4Skl VpJ5urZUM1I38LeqMrNeygkb5J4BRVJ+yKrfBv64R26y1qldwW2BYnsiCt79pWQHnA8sg+e2wvy5q rxx2r8aKOl63+ciDFmH8kto4N0QGRzAoOaXUwK52liB09KtLJfq386EHGEB5T6ZnZYjXg78bcCdEG XchVdDM8HF7pCz5NPzp+aqtSV6metWKBtl2fNU5FnIlqmKKxC70yWPjGoWdA//KdiRyanRK/Jbk9a DcPQe/sK28rUKLOgtWo10gjo56WsKrkb4akz14WqWkWC8ykzYE9t/GgofMoASvvG2lLm6t172YQlu vjRUzVFg==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLNTm-0000000FeuB-1Mcb; Tue, 18 Nov 2025 15:18:50 +0000 Date: Tue, 18 Nov 2025 15:18:50 +0000 From: Matthew Wilcox To: David Laight Cc: Sahil Chandna , akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, zhengqi.arch@bytedance.com, Liam.Howlett@oracle.com, weixugc@google.com, axelrasmussen@google.com, yuanchu@google.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm/pagewalk: use min() macro instead of manual ternary Message-ID: References: <20251118104537.7ebf4422@pumpkin> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251118104537.7ebf4422@pumpkin> On Tue, Nov 18, 2025 at 10:45:37AM +0000, David Laight wrote: > On Tue, 18 Nov 2025 11:38:49 +0530 > Sahil Chandna wrote: > > +++ b/mm/pagewalk.c > > @@ -313,7 +313,7 @@ static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long addr, > > unsigned long end) > > { > > unsigned long boundary = (addr & huge_page_mask(h)) + huge_page_size(h); > > - return boundary < end ? boundary : end; > > + return min(boundary, end); > > You can remove the temporary: > return min((addr & huge_page_mask(h)) + huge_page_size(h), end); You can, but I'm not sure that's better. What would be better is: unsigned long boundary = (addr | ~huge_page_mask(h)) + 1; return min(boundary, end); if you insist, we could do: return min((addr | ~huge_page_mask(h)) + 1, end);