From: Crescent Hsieh <crescentcy.hsieh@moxa.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
ilpo.jarvinen@linux.intel.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v1 09/31] serial: 8250: split 8250_mxpcie from 8250_pci
Date: Wed, 3 Dec 2025 10:54:04 +0800 [thread overview]
Message-ID: <aS-mTGjGtn1gQuvI@moxa-ThinkCentre-M90t> (raw)
In-Reply-To: <CAHp75VeDsVt0GQYUFxLM+obfmqXBPa3hM3YMsFbc26uzWZG-SQ@mail.gmail.com>
On Sun, Nov 30, 2025 at 09:22:20PM +0200, Andy Shevchenko wrote:
> On Sun, Nov 30, 2025 at 12:44 PM Crescent Hsieh
> <crescentcy.hsieh@moxa.com> wrote:
> > +#include <linux/module.h>
> > +#include <linux/pci.h>
>
> This needs more headers to be included
>
> bitfield.h
> bits.h
> dev_printk.h
> device/devres.h
> ioport.h
> types.h
May I ask a clarification: my understanding was to include headers only
when the corresponding symbols are directly used.
Is the intention here to avoid relying on implicit includes and to make
the driver’s dependencies explicit?
---
Sincerely,
Crescent Hsieh
next prev parent reply other threads:[~2025-12-03 2:54 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-30 10:41 [PATCH v1 00/31] serial: 8250: consolidate Moxa UPCI/PCIe support under 8250 drivers Crescent Hsieh
2025-11-30 10:41 ` [PATCH v1 01/31] tty: mxser: serial: 8250: replace mxser with 8250-based driver Crescent Hsieh
2025-11-30 17:07 ` Andy Shevchenko
2025-11-30 10:41 ` [PATCH v1 02/31] serial: 8250: add MU860 UART configuration Crescent Hsieh
2025-11-30 17:10 ` Andy Shevchenko
2025-11-30 10:41 ` [PATCH v1 03/31] serial: 8250_mxupci: enable enhanced mode and custom FIFO trigger levels Crescent Hsieh
2025-11-30 17:13 ` Andy Shevchenko
2025-11-30 10:41 ` [PATCH v1 04/31] serial: 8250_mxupci: enable auto RTS/CTS flow control Crescent Hsieh
2025-11-30 17:17 ` Andy Shevchenko
2025-11-30 10:41 ` [PATCH v1 05/31] serial: 8250_mxupci: enable on-chip software " Crescent Hsieh
2025-11-30 10:41 ` [PATCH v1 06/31] serial: 8250_mxupci: add custom handle_irq() Crescent Hsieh
2025-11-30 17:20 ` Andy Shevchenko
2025-11-30 10:41 ` [PATCH v1 07/31] serial: 8250_mxupci: add GDL-based Rx routine for 8250_mxupci Crescent Hsieh
2025-11-30 17:29 ` Andy Shevchenko
2025-12-05 3:47 ` Crescent Hsieh
2025-12-05 8:03 ` Andy Shevchenko
2025-11-30 10:41 ` [PATCH v1 08/31] serial: 8250_mxupci: add custom Tx " Crescent Hsieh
2025-11-30 10:42 ` [PATCH v1 09/31] serial: 8250: split 8250_mxpcie from 8250_pci Crescent Hsieh
2025-11-30 19:22 ` Andy Shevchenko
2025-12-03 2:54 ` Crescent Hsieh [this message]
2025-12-03 9:18 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 10/31] serial: 8250: add MUEx50 UART configuration Crescent Hsieh
2025-11-30 19:23 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 11/31] serial: 8250_mxpcie: enable enhanced mode and custom FIFO trigger levels Crescent Hsieh
2025-11-30 19:25 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 12/31] serial: 8250_mxpcie: enable auto RTS/CTS flow control Crescent Hsieh
2025-11-30 10:42 ` [PATCH v1 13/31] serial: 8250_mxpcie: enable on-chip software " Crescent Hsieh
2025-11-30 10:42 ` [PATCH v1 14/31] serial: 8250_mxpcie: add custom handle_irq() Crescent Hsieh
2025-12-01 1:40 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 15/31] serial: 8250_mxpcie: optimize Rx using memory-mapped FIFO access Crescent Hsieh
2025-12-01 1:43 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 16/31] serial: 8250_mxpcie: optimize Tx " Crescent Hsieh
2025-12-01 1:52 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 17/31] serial: 8250_mxpcie: enable serial interface switching Crescent Hsieh
2025-11-30 10:42 ` [PATCH v1 18/31] serial: 8250: allow low-level driver to override break_ctl() Crescent Hsieh
2025-12-01 1:54 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 19/31] serial: 8250_mxpcie: add break signal support under RS485 Crescent Hsieh
2025-12-01 1:56 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 20/31] serial: 8250: add optional callbacks for rx_trig_bytes Crescent Hsieh
2025-12-01 1:58 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 21/31] serial: 8250_mxpcie: implement rx_trig_bytes callbacks and persist per-port level Crescent Hsieh
2025-12-01 2:02 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 22/31] serial: 8250_mxupci: " Crescent Hsieh
2025-12-01 2:03 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 23/31] serial: 8250_mxpcie: defer uart_write_wakeup to workqueue Crescent Hsieh
2025-12-01 2:05 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 24/31] serial: 8250_mxupci: " Crescent Hsieh
2025-12-01 2:06 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 25/31] serial: 8250_mxpcie: add basic GPIO helper functions Crescent Hsieh
2025-12-01 2:13 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 26/31] serial: 8250_mxpcie: add basic CPLD " Crescent Hsieh
2025-12-01 2:25 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 27/31] serial: 8250: Allow dynamic extension of uart_port attr_group Crescent Hsieh
2025-12-01 2:30 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 28/31] serial: 8250_mxpcie: Track current serial interface for later feature gating Crescent Hsieh
2025-11-30 10:42 ` [PATCH v1 29/31] serial: 8250_mxpcie: Add sysfs to control terminator Crescent Hsieh
2025-12-01 2:40 ` Andy Shevchenko
2025-12-03 2:54 ` Crescent Hsieh
2025-12-03 9:21 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 30/31] serial: 8250_mxpcie: Add sysfs to control pull state via CPLD Crescent Hsieh
2025-12-01 2:42 ` Andy Shevchenko
2025-11-30 10:42 ` [PATCH v1 31/31] serial: 8250_mxpcie: add RS485-2W auto-adjust sysfs control Crescent Hsieh
2025-12-01 2:45 ` Andy Shevchenko
2025-12-03 2:55 ` Crescent Hsieh
2025-12-03 9:24 ` Andy Shevchenko
2025-12-03 9:28 ` Andy Shevchenko
2025-12-05 5:26 ` Crescent Hsieh
2025-12-05 8:35 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS-mTGjGtn1gQuvI@moxa-ThinkCentre-M90t \
--to=crescentcy.hsieh@moxa.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®