From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11023122.outbound.protection.outlook.com [52.101.127.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 948A7189BB6; Wed, 3 Dec 2025 02:56:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.122 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764730566; cv=fail; b=haWxYSuCtVawFteG7PzEr4kTgNEjuQfo0Jvl6hNyS3s5EEddZvotsV3ZqbzgCHGwQNEOPEy3+tYuIWHjre9Mnyq53gTpeyHbwFr2G4T46c/q4TTFqsOL2erDeRU8a4qQ2Ue60lhdbCYGStdOohmYBwi/PzvcoQ6Y0bpJW/prdaU= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764730566; c=relaxed/simple; bh=Nl5orRLt/3fAwBZL6clzYaEW5EjFAyKGhYh53ssaHNE=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=hcYY1woleOcte/i3lQDXhPGucyMCzPUBBJNb1UmLD8HdpjuWPXsxipnu6l4giNB7IC47zG0ap0MXnfjJCKQmvHAi5OqHPkhSelJN7t4TOOB/Pc9OWRLULqrGw9frKUAemcKkXC944MiMAkOAzkkA8OKXtb4ESGDfxGua6YxVGlQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=moxa.com; spf=pass smtp.mailfrom=moxa.com; dkim=pass (1024-bit key) header.d=moxa.com header.i=@moxa.com header.b=Ij0Zn/hL; arc=fail smtp.client-ip=52.101.127.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=moxa.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=moxa.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=moxa.com header.i=@moxa.com header.b="Ij0Zn/hL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PhqWNwWQt0IeC4Z0+OiI5ZL50eLfc0inuZNtKQGNnDZk2rBFaeCnSR3rs/SGu7oklqhk6mPURMz/iiRLk7ObfBhYs8/UWBLHOf723yaeZSdAk2KfBxcAxRO+h43GG/GVfeU1JgAOHxTO14RGoOmrmiAq2ShhYE1MblcbjdpdYjpoylYNMdY9AW0MKHhjI/mQnIywTmimTj6G6HwAKjcl4bJzkagtGZnpAAWDb6EXfzHVaayFw2uJUg/2bWC08bexVSr1esrHlGVJh+jRKpbfBjB/zvw8cUo0AkvSnGee+RNG1uW3ZFUmfosYdKz1SNcHr6RiANlrQUvMJPGaGJiSbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yv6ARZW2ELBwduJxo9aSw/ISoBZ60kS36nsxDdh9N4E=; b=dF1Kgro+BF+cKsmOxzFBfB/74n0YKXfUpZ/GY7GCgdctdLfFx700C6AOU3CwGoZrqgZDe0805JOWGvMA1H6Zd4SDubGWjW8f0sPouEGTqB76ec6JHG1w82c+rrnJu+oU5kbv4P4gPdglptj1ldcossTtL39/2GmV8six+27SqnNX22Pz/zUTJ4z7CkCxOgpHey7UqfeRfS03B9ODoLnZzKgy2pGYSmz6hxj2iVLN75q2Zklgak9GkeM8lfJi3EJeFriZlwCdBDJaFRdPVd4wyfL9iJbEBheTqF4s1Sg35M7wm5Przp+0oF4+pGL0DIyvM+N6/p/MprPktTTeNkLcSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=moxa.com; dmarc=pass action=none header.from=moxa.com; dkim=pass header.d=moxa.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=moxa.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yv6ARZW2ELBwduJxo9aSw/ISoBZ60kS36nsxDdh9N4E=; b=Ij0Zn/hLs8iKMBWU+A8VycNNC4fc5nXTbHZjvL94O3E7t9lBDqnm+n11VANb4+sJVNZAQiX8VL5IdD9artsK8NnX1jjamJTCVVNVVD6H6HdPliLMDwNhnPfDGsE2QugbHRjNpHe5GbUb3xABpaZkk2drtVNLT9m07NiLjw2c2/k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=moxa.com; Received: from PUZPR01MB5405.apcprd01.prod.exchangelabs.com (2603:1096:301:115::14) by SI2PR01MB4417.apcprd01.prod.exchangelabs.com (2603:1096:4:1b0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.16; Wed, 3 Dec 2025 02:55:57 +0000 Received: from PUZPR01MB5405.apcprd01.prod.exchangelabs.com ([fe80::60ab:8615:ab67:8817]) by PUZPR01MB5405.apcprd01.prod.exchangelabs.com ([fe80::60ab:8615:ab67:8817%6]) with mapi id 15.20.9320.013; Wed, 3 Dec 2025 02:55:57 +0000 Date: Wed, 3 Dec 2025 10:55:54 +0800 From: Crescent Hsieh To: Andy Shevchenko Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v1 31/31] serial: 8250_mxpcie: add RS485-2W auto-adjust sysfs control Message-ID: References: <20251130104222.63077-1-crescentcy.hsieh@moxa.com> <20251130104222.63077-32-crescentcy.hsieh@moxa.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: TP0P295CA0010.TWNP295.PROD.OUTLOOK.COM (2603:1096:910:2::12) To PUZPR01MB5405.apcprd01.prod.exchangelabs.com (2603:1096:301:115::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PUZPR01MB5405:EE_|SI2PR01MB4417:EE_ X-MS-Office365-Filtering-Correlation-Id: 08e0b734-3958-4ddb-172d-08de32177ba7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?R1FyNUhwOHk2WHRsaklSZkFXV2FHSzhpaldwcUdsNXloZExoYkZmMVNyYllU?= =?utf-8?B?aW5NK0pYNkROTTR5NDM1KzQrSUw0ZVdlODlwSUM0L2FoNTNFbFVhckloY2Ew?= =?utf-8?B?QjVWQWhEZEg3VUNOZkk2S3cyMFJybzNGVTFZRzV2dGpMbHpSemdGWVVtakhr?= =?utf-8?B?RFFRYnBBOUszbVZnSEwrcjFqeDBQU2NzRnU0N1NSTGZRUkxZSzhwTW9RNzZn?= =?utf-8?B?MHh6NmJ2bWZQQXpHSGNFaUh0SHdHSlRYMHJOUzc5QUZwY3prT3hNQ0RUc0dU?= =?utf-8?B?cGdhbFF6VEJHUStDR1JhTXdnQmFzVXZBYXcrUWFGeGp1ZkV5aWh4bHNwRWRp?= =?utf-8?B?TEVkZlFOamtaVC9DVTh1Q2lCWmtLYnFtb1BZaGZRTGxTR2ozUmtNdjdnWE5K?= =?utf-8?B?VkVqS0hnSmNBOGcwSy81R2ZjZDJmK0NQNkhwZExNZ0g0cHBxdldZWHI2RFZs?= =?utf-8?B?T0w0QVdOUHdVT3dQM01ma0ZkSVlMbTIrVlZjSVo1VTlzVlN1TWNWTHQyS2N5?= =?utf-8?B?a2ViTW84OWtISEpESUtrRDNROFpVaFhJdHoyZzZyWnpIZ1l0TFFIRTRKOTVx?= =?utf-8?B?bTMxSDdqc2Ftb3Nxek92UWhzYVE5UGpsNWcxZWtnSEJmbU1jRjE0M3hreHZR?= =?utf-8?B?b3J2d1lQaGJaR2hxbk1VWDlZWVNka1VBUS83R09MMnJEK0F6KzJVcCtZL1g4?= =?utf-8?B?RTdyRTZ2OE96RHJ2WE9UdXlhNXpDMEphbnlJNEtzZGR2c2NaRkt6bDNiMkdU?= =?utf-8?B?OXhsRFFjOGpMRlpGRWdzVFNHNDByUTBSY3FraUlOakhteVZHYzIrUUZIMGl1?= =?utf-8?B?VUpMRmlnQ3VVTHRHT3YzbmFmaDRLY29DRjFSa0tzOUk3cVp1bStySEZuTVFW?= =?utf-8?B?aHZYQy9peXRaZTBRSDd5SFdBVkVaY0FJVTAyWlR6c29XVkg3OERZR1dMNTBG?= =?utf-8?B?VVBVRWNUdEcvcEJmdEdPUmo2M2dWNjVtS2ZrcU0xMnhvTk8rNkRvZXE5TXZQ?= =?utf-8?B?MXEvRU1MTEk1OWo1T2cwamNnR3ZtOXc1eHFwYmRYMVY5NlNpazNaRjNDQnZU?= =?utf-8?B?RGJhM2hTRXo3eU5EOUp2QVhxM3FxN0JxUlVrbzFkK01Pd1dLY01tNnczQlph?= =?utf-8?B?cTBtT0RvNmRxQUhMOFZQalNOZnRrK1l3RTFBdHF5WUE1M1cyVXBjVTlnR3Q2?= =?utf-8?B?NVczNFJLL29iMkVBdG9HRjVmc0k5eWpGSkhpcXNMdGRMV0FDdTRBQldQcEp5?= =?utf-8?B?VHpZUHk0RWRqN1FxNEdVQXdMOEhJTUt0SlF5NElsQS9aWGd1OTRnR212bVBk?= =?utf-8?B?ZXk2WlkyNmgxWHFuczQ3bzBQQkRaTGRWaHAyWUxsZ25WLytFNVBPeUNPQ3V5?= =?utf-8?B?VWZ5WTRFSStNdnZHcnR5WWJHZlF6SU5Ub3I4eHN2b0RtZStuaHBtYVJGelRI?= =?utf-8?B?bWVjRllPYTdxekZkcnZwQ2ZWSnM3Mm45VDNZT1NmRDg5WVFTRkhrUFlPQnkr?= =?utf-8?B?MVJqb3N6OHowNXEzNkVMSmxtdGRwWDJDV3A1eFdDdEcwSW5GRTlGekg4V0Zj?= =?utf-8?B?NUViMnhjNWFBK25MMHlkZWs4K0JoQ0N3RFR1bTJtaXNvQndQQjNUT3BmaVAr?= =?utf-8?B?OXJxRisvY2tIaTJ2Q0xHWHcrNXoxcSttRW9WQXNVdHZZb2s5R1lra0drTHBn?= =?utf-8?B?eEVMLy9oUFhTeFR5cGh5eCtodU40bkd2WHA5bFJvWFNGd2oxcWZiOUdKYXhW?= =?utf-8?B?d3JJUmtyR2hOc0gxbitQQVE4ZlZRR1FudThKRVQyV1A3THdkMkd6a0FVRE1H?= =?utf-8?B?N0puS0NVc3V0cUs4OGQ5UlFlNVo3U2NybWxmMjV5Sk1qSmg5dXZRNGRmcHRi?= =?utf-8?B?QWRJTzBUZlZKSHdVcDNMazI5VWRjTnQ1aXBCOEs3RXd6OEZ5NXlkSm5nWHJ2?= =?utf-8?B?WmhPTUhXVE14anlTdUpZbFRRYVkydFpRRWFuOHh5c1IrQjRjaHdMakIyK1Nx?= =?utf-8?B?aFdaMDNiaHBTT2NuNW1VcXROa0tOYXdMYTJPbC81Y1c3cy9Rak1DYjN1VmhI?= =?utf-8?Q?eNv3lr?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PUZPR01MB5405.apcprd01.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(52116014)(366016)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnoxZ1IrZzNobFJ4eU50N0k5NDM5T2tnRVkyajU4OFJZY1hLcXFVV1JBOWdo?= =?utf-8?B?R2dkNGo2Ny9qeEZYUXZ6N29WQXlwUjJQOTFudXJuTGVBMzZnbVgzRFl4UVkz?= =?utf-8?B?QWRKdHhWK3FSOEJUSFl4MmFDRmJwd1IrQjlqcFYzL2VCMVpCZjNwbkVxZEtw?= =?utf-8?B?Y0pabGFiR2lMclczN3BoNWxXK2FLNjhBV2VqR0JxVEJkc0tXS3B2MkdONG5l?= =?utf-8?B?V0k4d1FCdGpsYkhZRzNodWNkUy9CSDYyYlhSTlRkQkF3VnBHNzVQY2lDa0Iz?= =?utf-8?B?eWp1VVpzWXBnMllSTFgreVg1Z0RIeEh0MXJ3eUltQktXMFpndkhQYjNqUW00?= =?utf-8?B?ck1wL25hV2RCOGNmT2dCN29hVXpobUdrd0hiZjRvdTMwbkptY0s2U1VuYmNF?= =?utf-8?B?UDlkZTBYYTZyZVV3SXRwNWN0Yy9NUGtLSjFVNUhnY2phSlpFTXI2bGJJQkJz?= =?utf-8?B?cHRibFJINndPUW9vUnlLT1NBNlA2MGJhYU80MHVIc1NQSmNxNmlHME4zai9D?= =?utf-8?B?YkRJUXhKWEtmM1VDd3l6T0NEc3hjc09ZQ1RZTVZucE9UVUtxTXFHYXlYVkNP?= =?utf-8?B?NUV3SmY0MVlaMDBNVU1SMHpEUG0zaE0xdFRSckg4bWExOGs4QTVNU3d1SUQz?= =?utf-8?B?azZpTzIzVVcrclMvZW8wN0dFQU5aRjVwMHRrRitZb1BLTlk3QXdRSXJrMllZ?= =?utf-8?B?QVBXSkkzWVdLUlJQNlpLeFJjWXppNFh0Q0V3S2ZCM3NERFFIblU4SW5SbjdZ?= =?utf-8?B?WHFtK0lWM1luTkdBYlVJeDJheUM0K21pQ2taT2liSEtFNHBoNWtHODRFYnoy?= =?utf-8?B?REZoUEx4TXlBdFlIcmQ3cndPZ1ZaS0RXRmpEVWtWd2hwYWF3dEUyNDJKaG5l?= =?utf-8?B?RG5BS1dMTzQ5ZGxwZUdXaUJxL2N2cFdaNi9TK3RsQjRCTVRGM2luUjRVdDIw?= =?utf-8?B?akpWUXZhUjBjNEVxNDB3ZUZUcW5IVGVGUlQwL0h6QXZ2RENnbC9QSFVtcWl1?= =?utf-8?B?OEZnalZnVW9odmxMWDJqaHlXVGF5Sk40NW9xMGo1UXdSYUJ4ZXI4ZzByYi9q?= =?utf-8?B?QzlZdDdTNld5bFFDWE9qaWZuUGhQVExpRm03UE5yUGtiSnQwVEtnRVhPTW1Q?= =?utf-8?B?N1ZQdVhMeXE4ZGtOTmNQa0I4YU1LTkdrbm1HSnBTb1F0V1pTNmFFSDljbTN6?= =?utf-8?B?VEphTkV1M3dhMlRXRGlyZU12Q1NVQ1hKOXUwdXE5Y3IvNk1KbFoxVTZQVE45?= =?utf-8?B?SmtqUCt6MSt6QmRKZDhIRHhJZU5lbjVudWFnMzdmS1ErakIrNm5CUUl0UnRW?= =?utf-8?B?ZHhDVE82eGFGK1ZpRGREbmY3dXlIK0Z4dVI4T0Y1Z1g1c0UreVdhV1A5RE9r?= =?utf-8?B?NFd5S01acUU5QkE4bDA2M1owdHY0K3NFc0JPSnZ4TmpMVFZLTksxa2dheldQ?= =?utf-8?B?N0xFMmJWUUUxZmdGU3E2OXdNczJ0UjJ5eUtGRUMvbC9tVFFDNGZHNTF4K29H?= =?utf-8?B?bVB1U2U5MHI3MiszbTRWTm84WWI5NUdmd2czOFprcytncUhuUGNjWG1PYVNJ?= =?utf-8?B?b1JKd09LazRyYjBDMmp4dXoweSt3c2hSOXlaNGtWRk1QWVFyd0p0Tk1aeXJn?= =?utf-8?B?MjV3N1IzVHZJcFY1NTRWN2tJajYrZ0cvd0pXbTBSOSs5UlJ1c0NJb0cxV3Nt?= =?utf-8?B?N1lqWTZGM0dNZVZRdm5ZbmlqZGpoZG4vbFVHek1IVnlBaThPU1dUa1hsektn?= =?utf-8?B?NE92ZHFvYW9VQTUwTTJrYkFLZFR4Q2FMZFJIYkR3eXhvUk9XTWlvditjUGVE?= =?utf-8?B?dGEwWk9rTVYzYXZ4U3BaTU85V1owcStVU0dKZUxQZGRjdStJdW95aGV4ZmZk?= =?utf-8?B?WW9iaW84d05nWE0xbjdLS2F0bjJzRWk5OVlTZzJHdHB1T2NxOHRrNHBUYmtD?= =?utf-8?B?a2VpM3pFc2xvZEMwSnRpVjF6dS9SVE54WDFITGtyalNvRlZUMnVNWDdLL29S?= =?utf-8?B?dEZxWi9XcW1CN0dNeWJVZkZ4TEpYajI5NnU0aXY4Yzd0ZVovSUZQelRUaFc3?= =?utf-8?B?aSthU1NBeUw0RXdYeEpGdm84VHVDZ05nK2x4dHNRL01lTDJhdGtsMmN2SmF4?= =?utf-8?B?MHo2OEJLR0NpY0lHa0NXeGNNdUV4eXZNaWNRRUZXOHNxbkx0cXpDT3Rwbkgr?= =?utf-8?B?Z2c9PQ==?= X-OriginatorOrg: moxa.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08e0b734-3958-4ddb-172d-08de32177ba7 X-MS-Exchange-CrossTenant-AuthSource: PUZPR01MB5405.apcprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2025 02:55:57.4611 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5571c7d4-286b-47f6-9dd5-0aa688773c8e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tLvBX7z047Ee7sK8Zm8NSd4OdcFc26i3MOm1ZuKO69N4KghZ6Jr3HQLvMvMDoqpod5e54Z2sGUbB7oTU3NtUK4ufy0VYPN6Wcy1HBkxBCJY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR01MB4417 On Mon, Dec 01, 2025 at 04:45:58AM +0200, Andy Shevchenko wrote: > On Sun, Nov 30, 2025 at 12:46 PM Crescent Hsieh > wrote: > > > > Moxa CP118E/CP138E/CP134EL/CP116E boards support a hardware "auto mode" > > in RS485-2W where the CPLD can automatically configure terminator and > > pull-state based on the selected baud rate and line condition. This mode > > is not meant to be kept enabled continuously — instead, it is triggered > > for a short period (about 2s) to let the hardware calibrate itself. > > > > This patch adds a write-only sysfs attribute that requests a one-shot > > hardware auto-adjust of terminator and pull-state. Writing a supported > > baud rate value (one of 9600, 19200, 38400, 57600, 115200, 230400, > > 460800, or 921600) into the attribute programs the CPLD baud code and > > runs a temporary AUTO mode cycle (about 2s) on RS485-2W ports of the > > supported boards. Invalid interfaces or devices are rejected. > > I'm not going to review this, the patch series is already quite big. I > suggest you to start from the small things in a different series E.g., > the first series is just converting MOXA from custom to 8250-based > (assuming all features are kept working while ABI is being broken, > which has to be explained in the commit message(s) / cover letter of > that series), the second one is about splitting 8250_pci to the other > Moxa case. When this is done, we may go forward with the additional > features. Hi Andy, Thanks a lot for spending so much time reviewing this large patch set. I appreciate the detailed feedback. I will split this big patch series into smaller and more focused series to make it easier to review. Thanks again for your guidance. Sincerely, Crescent Hsieh