From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBF45248F57 for ; Mon, 1 Dec 2025 21:00:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764622831; cv=none; b=nBvmrvu5HlsbJSSi43KvGCiQxYZfehllQTYnZL9neaZ27VdkbPuYTBNOMddAPH0SLbNKSSEzRlUdIzH4mPf0RP8k7/BcJH+Hkr3aNl4w0LDkNEqWZrO4GwkNrsgaM555csUviKscUNJesnl6GLek1rE91aXkydbfLwtI4NHhGkY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764622831; c=relaxed/simple; bh=Xy2vz55A+o3CveTMiFJdbYAYI2sYONWU+KCx3phl3gk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tfcAQKv/bY7JDosRMBSEp1FFY3Isq8GAjk144q0aIr2CZwRQ8i1Gm62o6F0s9zK++1e+Xdj7L/9fdi8knHafNATI4ycALr29T6igD6Z8JGbf4g5Qv73E6ucwPpmBED4V1AVWMxx7AZG1jg4zrDbpOl0JmdDNpodAzLsiyFzScus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YQtOn6OO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YQtOn6OO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7891AC4CEF1; Mon, 1 Dec 2025 21:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764622831; bh=Xy2vz55A+o3CveTMiFJdbYAYI2sYONWU+KCx3phl3gk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YQtOn6OO8IboU5l4MbXeNb2gGBLwlHN4YVKyOIOvyHBBm2Sz7S7Tm1FTHqd/DQl8t sN1jfMjfI1iH2+pFXs1+O3qTKHHieb8G09OkNHadNnAmnXPXVQzYM34Eh3pCDV/mVH tI0Veik+7FvDkXXXUenYr7rPuXYWrueEqTWX0P7qwIiDdFxr0YO5qmqLuILO0ov5sy 25OYF5Cg+NQOZ2LgBXny7jZX8DeL4BbiaQSqx0CzOK2AZeJO/6J7S+EIktvpE1JNaT Erg4iHfz3OANIP2kUA23JqxO2iSy1pPyuBDLigyJbBUv/WydNZ1kWKK/8D5fJaIT1m WlRC9okpfcTpQ== Date: Mon, 1 Dec 2025 22:00:26 +0100 From: Ingo Molnar To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH] x86/init: add kernel-doc comments to x86_init.h Message-ID: References: <20251129002524.1196500-1-rdunlap@infradead.org> <54feefff-084b-433d-a8b7-bc8c851c7636@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54feefff-084b-433d-a8b7-bc8c851c7636@infradead.org> * Randy Dunlap wrote: > > > On 12/1/25 12:56 PM, Ingo Molnar wrote: > > > > * Randy Dunlap wrote: > > > >> * @i8042: indicated if we expect the device to have i8042 controller > >> * present. > >> * @rtc: this device has a CMOS real-time clock present > >> + * @warm_reset: %1 if platform allows warm reset, else %0 > >> + * @no_vga: %1 if (FADT.boot_flags & ACPI_FADT_NO_VGA) is set, else %0 > >> * @reserve_bios_regions: boot code will search for the EBDA address and the > >> * start of the 640k - 1M BIOS region. If false, the platform must > >> * ensure that its memory map correctly reserves sub-1MB regions as needed. > > > > What is '%1' and '%0' - literal 1 and 0? > > Yes, kernel-doc notation. Yeah, so it's not a very widespread usage versus using the literals. I'd go with the plain text literals, especially since they don't cause comment-reading exceptions for the brain, which is always a plus. :) > > That's a really weird way to write them. > > OK, they can be removed. Do you want a v2? No need, I already edited it, just wanted to make sure I haven't missed anything. Thanks, Ingo