mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Xin Zhao <jackzxcui1989@163.com>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
	hch@infradead.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH v4] tty: tty_port: add workqueue to flip tty buffer
Date: Mon, 1 Dec 2025 19:42:55 -1000	[thread overview]
Message-ID: <aS58X-1-Izo237HY@slm.duckdns.org> (raw)
In-Reply-To: <20251128181048.429570-1-jackzxcui1989@163.com>

Hello,

On Sat, Nov 29, 2025 at 02:10:48AM +0800, Xin Zhao wrote:
> +	if (!(driver->flags & TTY_DRIVER_CUSTOM_WORKQUEUE)) {
> +		driver->flip_wq = alloc_workqueue("%s-flip-wq",
> +						WQ_UNBOUND | WQ_SYSFS,
> +						0, driver->name);
> +		if (!driver->flip_wq) {
> +			error = -ENOMEM;
> +			goto err_unreg_char;
> +		}
> +		for (i = 0; i < driver->num; i++) {
> +			if (driver->ports[i] && !driver->ports[i]->buf.flip_wq)
> +				tty_port_link_driver_wq(driver->ports[i], driver);
> +		}
> +	}

Maybe it's just me not understanding the requirement but does this need to
be this complicated? It was just using system_unbound_wq before. Can we
start with something very simple - ie. one custom workqueue which is shared
across devices? Wouldn't that work?

Thanks.

-- 
tejun

  reply	other threads:[~2025-12-02  5:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-28 18:10 Xin Zhao
2025-12-02  5:42 ` Tejun Heo [this message]
2025-12-04 19:01   ` Xin Zhao
2025-12-04  5:46 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aS58X-1-Izo237HY@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=jackzxcui1989@163.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®