From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E25B92C325A for ; Tue, 2 Dec 2025 18:17:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764699431; cv=none; b=kheN3exCCcijMoTciNQPm7kK0PAwge4ugdVMxnVLYqoe/MlBDq58+XRbPhYKoPUadGkvSBIDDxzGImgk0ndr6PIUUmgF8Q/OhGcwB+bl5BdxHn15RBMPun8V1Yg8DAapjjk2hY+8Zh4ra80NADJrKE/3xnom/c+O4yaBLyb0Cs8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764699431; c=relaxed/simple; bh=kIIxpDCzAiF+wx/yf+gGzLt+4Ot/8vUkQHd1YvCPew4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UDsohyGVQNHH72It/6aqfqrDFGFh1fBfdkAoRMbT0fQwkM1VWhviKng5Yakrr3rwevu9Qm+nTNKDV2D8FE+zdPs2MLazdDMLQ0YKjJgWBxYtQEfhUVvJUt+omcnPMJQ2FlmdMjPKr6ttkMN3iKNOd2SxoG7t5KhRYzD1NkCcmCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OxkbmKEO; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OxkbmKEO" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-42e2e77f519so2342551f8f.2 for ; Tue, 02 Dec 2025 10:17:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764699428; x=1765304228; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6b74+PpIp4g7MMqPdYt95ZSBDMLgOHp379BS/AlUf30=; b=OxkbmKEOMdfd70iV7tGDNb9WXTKw1sTd8BB1DOId+NBwS9j/1vy1iAKdt79//w3ZP3 yxERnDroP1lgnNwCj8PM39gkFhS8W1TIiJ7dDXVRLc7hDHbf6ERPFImXiDNuCL7V31fg 3ANBYk/gduGOMi/B/Vu/wgWq7Sx5XCCNS+mT7s2FuCCSvojFwGciaNjx0dP7nmINCny2 qesuMsrdpnyNGF6SdBUKwvoaJk6C1yuetzKv7NyQBHrc9DvjFs42DykJTjWhNHWqExFp C/KeVLN+Xr+LeLJMVaHfyVwbPDNk8p299gWM/EtSw+uDakgq8M0UtNW9jFexzqKtH34b 9g9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764699428; x=1765304228; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6b74+PpIp4g7MMqPdYt95ZSBDMLgOHp379BS/AlUf30=; b=k6eRmVIyaDYPlEk9vUZ6cJo9HMcqtwxqLwCSJJnYBEM2WOWmJkiYWglk7KSFZWGOR8 1wBoKZJs7emmIuSbgfEBxPeoHbw0gCoCAPXUN5Xg9DWjchz4gJoGF+gvn6yE3+ahFx0f 44JdarvWEda5fEzJudZlgHmyAEHxJpVGDfqX5BQ3GkBVUzna5h2rYRj8IOaBR49t/lMo WeZmMTEeTOCTZHSoYf82QqGsfWwR1ENTVTbfyYImAK1dkMOJScNLy7qj3eW1geRQXEgG 2vpxsvIB8i8LVHQCzosWb5uX01/jYj/MQDuhkPI5UU7nIVUgoBStTn6zF3kWcYT7MNMi eunQ== X-Forwarded-Encrypted: i=1; AJvYcCVAbJ6pBlQf09eDd2AbHgphLMb0/43oMnM6QdyRmTAhMoxHpFpgS46cUMnqNUiOvMtehq4U0bnV07G0jfQ=@vger.kernel.org X-Gm-Message-State: AOJu0YypYJm2saVwdJfTT7kWRYCWk0wts3A+0SiRALKpL4ZS/6EKKCcA Rl/L8FMBUDH1uDlaUzN2vdivQlYYNiyy8Tq/VIvShnWWolmqH0mfZGkfkq8lnoXy2Fn/nphTpLV TdO/o X-Gm-Gg: ASbGncu908963b4dLUHACpKjPPYZQfjmHY84bdLbpGLWv7OZWTGrPfsVxNg1XhGguCD oqtvhH8rOnVjIkc+E4QQbO3dpvfVVJHUXZSO5zKg8Z5RbZfGc0fqBiKIRB23xUHyzoHD9LgNTqF nnwoSzDx9bdymqzbSshcyrKJJ3b5Kn78HkTNV5VkWY+9r1x9uksh05LwdONIwYxI04aOs7//BR7 X3OrYkAhMCd5ZYrcoMbhFz95MzB0dHf/P6W97sBAwa+1bmk+KVr7pMb1GTn1odJ8xNhsL6e05jr kRgcGFIwtNy7g/Fbc9edO1q+qd0lNWifxlr+HCIAqCuZc8kOuh6YHJOFhtRY9JpNLThJcG/cV7H x/NbjYBf7GVPZChh5f9KzXOFrCroVFnH68/AHKcPCYt+mEo48ZffAHG9hSljGyElB18qLyxZKoL E0iC3m8ENklVqZsVzZ X-Google-Smtp-Source: AGHT+IGdPY6yqrBKJkkOOYWF6CM+7Jwdu1H0nVTCpwkcVSguUh9pxxkKdepb4CrjpvgK1/jyWOMffg== X-Received: by 2002:a5d:5f82:0:b0:42b:3220:9412 with SMTP id ffacd0b85a97d-42e0f3491e2mr34996565f8f.28.1764699428016; Tue, 02 Dec 2025 10:17:08 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42e1ca1a3f1sm34529299f8f.28.2025.12.02.10.17.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 10:17:07 -0800 (PST) Date: Tue, 2 Dec 2025 21:17:03 +0300 From: Dan Carpenter To: Frank Li Cc: Jan Petrous , s32@nxp.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-s32@linaro.org Subject: Re: [PATCH 1/4] net: stmmac: s32: use the syscon interface PHY_INTF_SEL_RGMII Message-ID: References: <6275e666a7ef78bd4c758d3f7f6fb6f30407393e.1764592300.git.dan.carpenter@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Dec 01, 2025 at 05:29:36PM -0500, Frank Li wrote: > On Mon, Dec 01, 2025 at 04:08:20PM +0300, Dan Carpenter wrote: > > On the s32 chipset the GMAC_0_CTRL_STS register is in GPR region. > > Originally, accessing this register was done in a sort of ad-hoc way, > > but we want to use the syscon interface to do it. > > What's benefit by use syscon interface here? syscon have not much > well consided funcitonal abstraction. > The GPR has a bunch of random registers that aren't really related. On these chips they're just regular MMIO registers, but in other configurations you can only access them using SCMI. It's better to group them together that's how they are in the hardware. Otherwise we'd end up randomly adding a register address to the ethernet device tree entry, but it's nicer to use a phandle to reference the GPR. The only register we're using now is the GMAC_0_CTRL_STS but here is the list of registers in the GPR. >From 0x4007C000 0 Software-Triggered Faults (SW_NCF) 4 GMAC Control (GMAC_0_CTRL_STS) 28 CMU Status 1 (CMU_STATUS_REG1) 2C CMUs Status 2 (CMU_STATUS_REG2) 30 FCCU EOUT Override Clear (FCCU_EOUT_OVERRIDE_CLEAR_REG) 38 SRC POR Control (SRC_POR_CTRL_REG) 54 GPR21 (GPR21) 5C GPR23 (GPR23) 60 GPR24 Register (GPR24) CC Debug Control (DEBUG_CONTROL) F0 Timestamp Control (TIMESTAMP_CONTROL_REGISTER) F4 FlexRay OS Tick Input Select (FLEXRAY_OS_TICK_INPUT_SELECT_REG) FC GPR63 Register (GPR63) Then from 0x4007CA00 0 Coherency Enable for PFE Ports (PFE_COH_EN) 4 PFE EMAC Interface Mode (PFE_EMACX_INTF_SEL) 20 PFE EMACX Power Control (PFE_PWR_CTRL) 28 Error Injection on Cortex-M7 AHB and AXI Pipe (CM7_TCM_AHB_SLICE) 2C Error Injection AHBP Gasket Cortex-M7 (ERROR_INJECTION_AHBP_GASKET_CM7) 40 LLCE Subsystem Status (LLCE_STAT) 44 LLCE Power Control (LLCE_CTRL) 48 DDR Urgent Control (DDR_URGENT_CTRL) 4C FTM Global Load Control (FLXTIM_CTRL) 50 FTM LDOK Status (FLXTIM_STAT) 54 Top CMU Status (CMU_STAT) 58 Accelerator NoC No Pending Trans Status (NOC_NOPEND_TRANS) 90 SerDes RD/WD Toggle Control (PCIE_TOGGLE) 94 SerDes Toggle Done Status (PCIE_TOGGLEDONE_STAT) E0 Generic Control 0 (GENCTRL0) E4 Generic Control 1 (GENCTRL1) F0 Generic Status 0 (GENSTAT0) FC Cortex-M7 AXI Parity Error and AHBP Gasket Error Alarm (CM7_AXI_AHBP_GASKET_ERROR_ALARM) >From 4007C800 4 GPR01 Register (GPR01) 30 GPR12 Register (GPR12) 58 GPR22 Register (GPR22) 70 GPR28 Register (GPR28) 74 GPR29 Register (GPR29) >From 4007CB00 4 WKUP Pad Pullup/Pulldown Select (WKUP_PUS) regards, dan carpenter