mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH] [RFC] mm/fadvise: introduce POSIX_FADV_MLOCK
Date: Fri, 21 Nov 2025 14:27:48 +0000	[thread overview]
Message-ID: <aSB25FFkLaJkbVfT@casper.infradead.org> (raw)
In-Reply-To: <aR_ultJzXh1rmOKs@google.com>

On Fri, Nov 21, 2025 at 04:46:14AM +0000, Jaegeuk Kim wrote:
> On 11/21, Matthew Wilcox wrote:
> > On Fri, Nov 21, 2025 at 03:27:18AM +0000, Jaegeuk Kim wrote:
> > > This patch introduces a new POSIX_FADV_MLOCK which 1) invalidates the range of
> > > cached pages, 2) sets the mapping as inaccessible, 3) POSIX_FADV_WILLNEED loads
> > > pages directly to the inaccessible mapping.
> > 
> > ... what?
> > 
> > This seems like something which is completely different from mlock().
> > So it needs a different name.
> > 
> > But I don't understand the point of this, whatever it's called.  Need
> > more information.
> 
> So, the sequence that I'd like to optimize is mmap(MAP_POPULATE) followed
> by  mlock(). For example, mmap() takes 1 second to load 4GB data, and mlock()
> takes 330ms additionally in order to migrate all the pages into inaccessible
> map, IIUC.

Oh, so the MLOCK part is right, but the inaccessible() part is wrong.
Inaccessible is special weird guest_memfd crap that has all kinds of
side-effects that you don't want.

Wouldn't you get the same effect by calling mlock2(MLOCK_ONFAULT) and
then calling readahead() for the desired range?


  reply	other threads:[~2025-11-21 14:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21  3:27 Jaegeuk Kim
2025-11-21  4:22 ` Matthew Wilcox
2025-11-21  4:46   ` Jaegeuk Kim
2025-11-21 14:27     ` Matthew Wilcox [this message]
2025-11-21 18:02       ` Jaegeuk Kim
2025-11-21 19:52         ` Jaegeuk Kim
2025-11-21 19:58           ` Matthew Wilcox
2025-11-21 21:32             ` Jaegeuk Kim
2025-11-22  2:47               ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aSB25FFkLaJkbVfT@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=brauner@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®