From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C14151ADC97 for ; Fri, 21 Nov 2025 12:22:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763727730; cv=none; b=H5Vt89m0iKk22gnH67kDua7W+krXsyqr+ojFHi/qHDMaaWDs+3iOpcH/+eu6q41jDP701VWIcc0dQ48oBK+4/GCs+N3ZRoY1VodpiTa2m5pDo+O5gsTKS4xCFHHkB3pWXxMhwInIXNaPohKm5WWbMF3d/lWSVWPIoR+nVPhqQ8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763727730; c=relaxed/simple; bh=a0og27g4FEXF5qVbJXNaqHgTmGNp/nva+ehekdAGa/A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gyJcmFw2w10JNRsdq3KEvHKtXaNWcR1SjxtE2DXYv6iGI2tHskzpoVAik0E9a1nFVGDzjcDvZG4e1EPiUCxsbKj7sfvIpYcYyZonxyS7hK9EcLDefZFwBF0F6OEN9wPBWD6OP39jDnPWQ5HXAeWklNVJEF26NY4OfosahRfme9c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bMgMLBiG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cxG5ncu+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bMgMLBiG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cxG5ncu+" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ALC8pVJ2756812 for ; Fri, 21 Nov 2025 12:22:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=QOIEJ6UPJQTAjE0lnDBx83Mc 3Buu9GbdeLLWEnEH4nU=; b=bMgMLBiG6TE8VU7bV0s3zcnva72tTZP5o5jByY2P hDsrlAJJZslq0/LSQMtd+ZE77MTzueZW7HZP0S9vMvuoYHqSWs/7qDDXPfcK9j/V sOBqQRgnm+yMJpmmuwxav7DABYBjVoV4i1wD4lZrN5eXCjlS/3OXqb7E3GApskiQ Hyn2gWZQcDRgucrM2r00tZbduoHtlOqs0wunxVIQ/9F3azclPiu5qVn742LhNrNO SiksynewmKLKI58QUE36Kwp8ed5YABuTdTPExzHA/aewbpSccAr87nRiCjypQcEf 2i/kJT2zn2/Yyq2eobild50f4hLltfEflEiMl1lgbnYvOA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ajhy61cpt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 21 Nov 2025 12:22:07 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-29846a9efa5so56732535ad.0 for ; Fri, 21 Nov 2025 04:22:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763727727; x=1764332527; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QOIEJ6UPJQTAjE0lnDBx83Mc3Buu9GbdeLLWEnEH4nU=; b=cxG5ncu+q8VbPW1xcuMMDWfDp5rO+Cubt39kQaU0svEAs4ST8RmbQ81sgensAeZOBu /+by+UdX2euNzioM09xOYiiHlQXEoWfS2rLsBcgMf0FPtB/UZlsV/oCiuG0CxkHYnf8M dSOGKcNjyEEBCNEjsXFagoBZGeEaXXEtKoazkHi3ekIKZSfJdaUGZdep8CT0xfPYNVrD q0NwQpLOEnSExECxo/wsJHP18z7MCpk2hvKxth9EL7k1Foi45QF+gXwYTROlACcLgQl8 UXWfql5k7HwEliStzdfpc5f5CoaIgni0ru86nG5VjqTMU2Ar1BA/tlfzMXPEAHgKGaI2 tifQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763727727; x=1764332527; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QOIEJ6UPJQTAjE0lnDBx83Mc3Buu9GbdeLLWEnEH4nU=; b=Jz8jVrc+3Sf+ZYkbyo3p7vQh1hwNB561HXtaLdWUUjYBfCv2to43JID9QZGOkH+Txz nx6SAsv6q+RWMOLdBaJ2kx/FN6CZGY4ZhyEAY8ayBG5LnMMvnQ6s9aAkNkvxy8YSuQbU 8MQqdDGgwIoillE5Y+vHQ/Po2jjgOP6RPNmqsMkZOJ7OiRxtUG9QRDu/8DFz07Ax249J 5jOkG4rJkGv3FXmyWvq4j5Zqt4yecb159ZYHS9SGxCZtjVhc8viHpkJnE03Qx/1axUjN i/Y9WTa61DpMjP1zrTG/TeblRqpdvE95BnYcL5XHziVE82ngyGpARg2w0LTBIzBn+IxW MknA== X-Forwarded-Encrypted: i=1; AJvYcCW3blH6H5H4JC71yKgIpTEJdtylTt0PTbEnkOiARMI6xDPgfBw+FZxTDKjP4tTTEYxIqMdXFd8VsrrmfXM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5uWWZRx86uJUw9fmM1Pb8y3wiCexOkob7EGYpj+z6eikECvMO /FCZMu/h6Rs20G58Afb7PAZOKqFNEfsS0JNd7q3NuQRloNIXrFCAIoVyvgJwSVCGsidmb/7H6/d zS0+5GMoIriUaPv3zS8aKnR46FNM9tn60W4tZm7TGtDZPkHQNU52UsB8SIy25Lep55g8= X-Gm-Gg: ASbGncv4UP1sr4ScV5mDCmEF45KZCYD2/TUDhDADC7EuFLNPt8q0z9aO/Z7gLf++vTj 57zRLoQzrPVWCTXc8damklL/H0OS8H5Xgo6PoaeM7L95Un0ZviO31up7VvGg4kZMAquGm8+GLZk 5ax8YPmOWSxKpuAaJkQJLg6sezgNjBIHNcMc9do7EPVFNtyDJFu1gTpkooaz/Ev7GmJ3ev52D48 osbIOgka5twyHiqnYLW6T5/lPIPCcBO5R8PBYAJ5IEHKqc/hSZw8j9PFtmm7xMiTOeMif2RrZYE WdscJ/1vXAv9xGygi0k9kOi2CQnN85tiXEQj+ozubBEdQiEA2XzuXNabPyy0c0bmDC4ZwcQAuBf iRjpnGeNdxUmpQYEDjTbeclBf3BuD/FMxh2DBoSGDNQ/RnbE= X-Received: by 2002:a17:902:ebca:b0:295:20b8:e104 with SMTP id d9443c01a7336-29b6bfb2dbfmr24170385ad.58.1763727727156; Fri, 21 Nov 2025 04:22:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IHvJoin87WK7edXgGLBHv6hcpFfAb7pDIOGdRzPQZ86Ke8psodEKElFccqt9If6oIGCW2Nm6g== X-Received: by 2002:a17:902:ebca:b0:295:20b8:e104 with SMTP id d9443c01a7336-29b6bfb2dbfmr24170135ad.58.1763727726625; Fri, 21 Nov 2025 04:22:06 -0800 (PST) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bd75e8b37f1sm5520188a12.14.2025.11.21.04.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 04:22:06 -0800 (PST) Date: Fri, 21 Nov 2025 17:52:02 +0530 From: Abhinaba Rakshit To: Bjorn Andersson Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: qcom: ice: Set ICE clk to turbo on probe Message-ID: References: <20251001-set-ice-clock-to-turbo-v1-1-7b802cf61dda@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Authority-Analysis: v=2.4 cv=Lb0xKzfi c=1 sm=1 tr=0 ts=6920596f cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ciROkYvXyXDSqN8Q_VUA:9 a=CjuIK1q_8ugA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: JpgN1xA62yNF4O_FigwX1ETfYjODdY4G X-Proofpoint-GUID: JpgN1xA62yNF4O_FigwX1ETfYjODdY4G X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIxMDA5MyBTYWx0ZWRfX76DIx9pI9Jj8 1bWItRRl5A6F6pQuQd0VuRBrrRKsbth9HPGs/xhsN5DA/LMy7b/a2eWC3NHC4BB3t/GwOWc4Vg5 7lGO5JFZ1XN28/5oZi9UhsDr5skcra497p0EGTzIuVp14UpBt5NOdCiG9tAl9oFxbE9gCf576PK CyMu6PWUCDLC7Kw/G4wL1TcjaZ5Nj0sfUNb9ENC5NMAP7Wx//KKlkjLJ6Qn8foWGKD6w530kPhD toOpiz9nVphiBTTe836NgEUUHtnzzQSSc64cNb2GO0e7/00gKHoJmnGHpsekGdPelKqvztlWeDJ sFTjUnZ8n1jgKnn/28R7RMHRtck/2uMp84Gq8XuvCwY8H5G0ACue4pApKJsAxt1e8v01SKg+kbe htu4Dd4+1PJTqeOGRJAKKOb/IZ8abw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-21_03,2025-11-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 impostorscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511210093 On Thu, Nov 20, 2025 at 07:42:24AM -0600, Bjorn Andersson wrote: > On Wed, Oct 01, 2025 at 05:44:32PM +0530, Abhinaba Rakshit wrote: > > Set ICE core clock to turbo (max freq) provided by dt > > entry at ice device probe. > > > > Signed-off-by: Abhinaba Rakshit > > Didn't realize until your two patch series ended up next to each other in > my inbox, but adding this support for UFS and for MMC are very much > related, so please include all three patches in the same v2. > Sure, that makes sense. Posted the patchset-v2 combined all three patches. https://lore.kernel.org/all/20251121-enable-ufs-ice-clock-scaling-v2-0-66cb72998041@oss.qualcomm.com/ > Thanks, > Bjorn > > > --- > > MMC controller lacks a clock scaling mechanism, unlike the UFS > > controller. By default, the MMC controller is set to TURBO mode > > during probe, but the ICE clock remains at XO frequency, > > leading to read/write performance degradation on eMMC. > > > > To address this, set the ICE clock to TURBO during probe to > > align it with the controller clock. This ensures consistent > > performance and avoids mismatches between the controller > > and ICE clock frequencies. > > --- > > drivers/soc/qcom/ice.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c > > index ec8d6bb9f426deee1038616282176bfc8e5b9ec1..eee06c499dc36a6bf380361f27e938331f1fcb10 100644 > > --- a/drivers/soc/qcom/ice.c > > +++ b/drivers/soc/qcom/ice.c > > @@ -535,6 +535,7 @@ static struct qcom_ice *qcom_ice_create(struct device *dev, > > struct qcom_ice *engine; > > const __be32 *prop; > > int len; > > + int err; > > > > if (!qcom_scm_is_available()) > > return ERR_PTR(-EPROBE_DEFER); > > @@ -577,6 +578,13 @@ static struct qcom_ice *qcom_ice_create(struct device *dev, > > if (!qcom_ice_check_supported(engine)) > > return ERR_PTR(-EOPNOTSUPP); > > > > + /* Set the ICE clk rate to TURBO */ > > + if (engine->core_clk && engine->max_freq) { > > + err = clk_set_rate(engine->core_clk, engine->max_freq); > > + if (err) > > + dev_err(dev, "Failed setting the clk to TURBO\n"); > > + } > > + > > dev_dbg(dev, "Registered Qualcomm Inline Crypto Engine\n"); > > > > return engine; > > > > --- > > base-commit: 3b9b1f8df454caa453c7fb07689064edb2eda90a > > change-id: 20251001-set-ice-clock-to-turbo-ecab9ea46a89 > > prerequisite-change-id: 20251001-enable-ufs-ice-clock-scaling-9c55598295f6:v1 > > prerequisite-patch-id: d66f521e5e625b295a1c408cdfce9bd9524ae3ba > > prerequisite-patch-id: 23934f3fee5aabe4a2324130ed02909352b5cf61 > > > > Best regards, > > -- > > Abhinaba Rakshit > >