From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F74CF513 for ; Fri, 21 Nov 2025 15:55:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763740515; cv=none; b=m3vgPf8cqftWcv6xG+z8bWHaXHQWYz/EDCVi1B5+t8/7/dqZgdULAYl3Dsv3kKTjW5Zm319iWIk4++7Jqta/ojjlqRsf5Kh0B5PpK6MYa5wdf0w52150DvClXPr23IlAxzDa30fm77fBmv4rfXIyxU7b5P6ew9y59aIcuxfJofY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763740515; c=relaxed/simple; bh=Xukn9UU4bf6JZCJTwEOGw4mVEHxrrRQNvskBeEVzXTE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jja7k+6V3h8kyOL/s8kQgjbjE8Sg7bpkl75cye5mRJp61QjMlE3T5mc9fQy5rmmiKeT45N8yFSv4nFW/ugGgCjS2eEgEQDpV3+jx7qhulieFE3aCz/xfAW8mCPJXmH3TRpoIPxUCM0UtTwadEJ81b9PyFvntY4fxLtu3mMfDX0Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=URvzCzCs; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="URvzCzCs" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-640c1fda178so3567405a12.1 for ; Fri, 21 Nov 2025 07:55:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763740511; x=1764345311; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AbvkO2Ji33fOmrEwQAOl1RMDl0kCqj2zTACZ96ytJPA=; b=URvzCzCsupCuZFoBj1g9rDxurvO9Uo6WpVshBCSjHPYnClVYdC9ODbFKuKTGqpMKfG oNCf1tJGbcDJQdPHeyC3FlykurOHWjXMNJknBZo2Yc4j7yaoW+qWV9DTrkLBbYAcA2mS A39dnqPPe2xWTRCk582lPQyspdwwumNP8/ULReuYL3ai+rXVY6fow7g5nCZN13b7D9YI ud132XQC5fis+O6iagLomB4MsadLWj2usjolRNxBVu0bY1vXabAD4FLxf1aPDGkZgNkk VQn+rXDhturK4Aoekrk6reMKvPwNlKY5d4FLGQdxPvv2CSsdyBRjBK0MXLx+UIfeK2SE pnJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763740511; x=1764345311; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AbvkO2Ji33fOmrEwQAOl1RMDl0kCqj2zTACZ96ytJPA=; b=G7epNlANxd2gm6Lx0oBxxK1oxtxNQqW/3NgVkKEx8qBh3Q3tAelHSCDS0VdyRfowXx ZRne6yINbDF37zFX66Peo0l0yqei/n6dpxJTvulIs5/YKQKC5CA16HFzFwPzOE237Fv9 rWKFDbBtifWSW5RlSg+r7SzClLtabdHH62MK6ZMTqmTQQXxjpgMV57fLmaKPruHUSi4B gmfsLNMoRRrp33B1GbBtoJOtPML6pdzU/rVYzq7RRFCoyxbKoE0ciXMZt8rbPQewRhd1 4DgpXYZvv3F4b82OLFHV8GO5yjPU7BAnBRFXyqwO8CYwgzRqWneq2vzLflToxEKl/nOU qmVg== X-Forwarded-Encrypted: i=1; AJvYcCVc/ygR8cUnBRpVgo5zTV5MpMrsnwK0etkuf/HXaAHijv3IAz4aIBk8pnSP9SHlnihue6tn+cMxow1NX0Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxtJdxXIaUX9K6+96Kp5mzNk8QG8bQL7WjoJwzILW1pBneeSsdQ K7340kr2YCr2ORt3SS9qpCj6jVlnJBgKQnmQHnkl4pWj0uPyNTMUumIIdzfZlTvYlMY= X-Gm-Gg: ASbGncsu9IGlHJMnkHpyLv92L2nGPCPoDQjwTlgraJS0hANO0CL6ozVFNh0enm7xp/t doM2mT+ZWkwVCWF6ny/6vjaQtyxCfONFBGK3cQqvs6bpRVkE71EXy/QNBeAuoEz2rVvwBkQAH1C dVJUcvBK8ks9yIVstWOA9LzNrYWafGKenxvxhx/nEtvKUGDRsfUef5Ul59CmpMmnabmlfWESJmw ZItfTpZNvEsZvyi61C94Xtws8hVwt+jpukQ7mqwaDa0PF4U1Go6pagx4hZ5ppgX6JQa+wq5k1Go ArZObDlnXwzo2c/odZyOw8OFNDAQlNXjLBKggaXUZzFwcK69q1ITpaFqnXIatXuoiTx2UI9es79 8hKvTRKd3cxzfzcJV0ITh1iFO3BbPfMmt12wESITcB8fbRf6vMLt2XGKhNoTf8W4c6rEmRTzbpv 9jSqSUdIsB1TFSppVcSMLn/Q1X X-Google-Smtp-Source: AGHT+IFvFt/676OatBaGGpEqLA1mKfGc2JE6aN/u6diRYgS1eqcL2tjqQrZqVUMCpAiL9G0QUXeJTA== X-Received: by 2002:a05:6402:1ecb:b0:641:1cd6:fee9 with SMTP id 4fb4d7f45d1cf-64555b86ce3mr2220556a12.1.1763740511642; Fri, 21 Nov 2025 07:55:11 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64536443a9csm4730062a12.29.2025.11.21.07.55.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 07:55:11 -0800 (PST) Date: Fri, 21 Nov 2025 16:55:09 +0100 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Sherry Sun , Jacky Bai , Jon Hunter , Thierry Reding , Derek Barbosa , linux-kernel@vger.kernel.org Subject: Re: [PATCH printk v1] printk: Avoid irq_work for printk_deferred() on suspend Message-ID: References: <20251121102010.359369-1-john.ogness@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251121102010.359369-1-john.ogness@linutronix.de> On Fri 2025-11-21 11:26:00, John Ogness wrote: > With commit ("printk: Avoid scheduling irq_work on suspend") the > implementation of printk_get_console_flush_type() was modified to > avoid offloading when irq_work should be blocked during suspend. > Since printk uses the returned flush type to determine what > flushing methods are used, this was thought to be sufficient for > avoiding irq_work usage during the suspend phase. > > However, vprintk_emit() implements a hack to support > printk_deferred(). In this hack, the returned flush type is > adjusted to make sure no legacy direct printing occurs when > printk_deferred() was used. > > Because of this hack, the legacy offloading flushing method can > still be used, causing irq_work to be queued when it should not > be. > > Adjust the vprintk_emit() hack to also consider > @console_irqwork_blocked so that legacy offloading will not be > chosen when irq_work should be blocked. > > Link: https://lore.kernel.org/lkml/87fra90xv4.fsf@jogness.linutronix.de > Signed-off-by: John Ogness Thanks for catching and fixing the problem: Reviewed-by: Petr Mladek Best Regards, Petr