From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CDACDDAB for ; Sat, 22 Nov 2025 14:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763821915; cv=none; b=glcP83j4zUbxT2ugDNvKE5DBr6/pdQJM8DcoYVIUSYUNpBau7PfL3A3dcwSl7HuvEWzt/B7fQYdZ+rSyuxxy4tf7Nn02pkctQbEfcSzytmuZFJvzsXXbUImg+lxvFUTAsQRbN6A1Ivv1j+vmkZeLlHVVwoTYC8Vz5qJmwW+ZvSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763821915; c=relaxed/simple; bh=nDuPLmyz+3673vsvsXJQGQUEAyGeLaFL5u20HMgyUlc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SmnpDggrG2Dzyf0TmP9IBbERyo46GXhtru/Ysq40rMGPXJKsSPMR5QxYMFPTU3Yh0pBHKls0XhCFTAzCnPBNtT90o7ljry2xUWA56ldXjeWAvRUweodsrgTUOlxhFBENx3TzdJOLD150vYqClmz6B2C030sRBEuFYREjyY1y39A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=la+zevWg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="la+zevWg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9617EC4CEF5; Sat, 22 Nov 2025 14:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763821914; bh=nDuPLmyz+3673vsvsXJQGQUEAyGeLaFL5u20HMgyUlc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=la+zevWg1R3Eq3VXmqYRd3od91egq4+/HYtGq+kqMoxjpmEfgNpUpiUcAr4OBTu6O lvS6RXEBYpcY81PjOrAMc/aG2UZl6WZ5ghE/sKBRwXMOWwVoNdoF2WtZNp1LcslyfG yNBPQ9Zh0NnngL23ifwwjgdnG3Se1+ZSourxeqI5SBNeHUOZUvnJKWhIjDAxHK33yo 5I0RuGwe1CxmcIfcjmNHKJvC/UaoT6X43I1gUOgCTS8qraf/cwtPNPDtAq5aGOXb0M UhyqoUVR6XlLIbZ+APZlsM8CDL3mNiRKRLHM1nTNgIQHIE7vV0kn9/Hn/eXI8Ni/U5 IKV/IORUgaaOA== Date: Sat, 22 Nov 2025 04:31:53 -1000 From: Tejun Heo To: Lai Jiangshan Cc: linux-kernel@vger.kernel.org, ying chen , Lai Jiangshan Subject: Re: [PATCH V3 7/7] workqueue: Process extra works in rescuer when there are no more to rescue Message-ID: References: <20251121145720.342467-1-jiangshanlai@gmail.com> <20251121145720.342467-8-jiangshanlai@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hello, On Sat, Nov 22, 2025 at 03:07:25PM +0800, Lai Jiangshan wrote: ... > But this patch does not really check if memory pressure is still on, > using (pool->flags & POOL_MANAGER_ACTIVE) can kind of > achieve it, though not precisely. There is never a precise way, > but the system has poured some resources to create the rescuer, > it is better to make the best use of it, like before patch 2/7. > > this patch: > if (!pwq->nr_active) > return false; > if (!need_to_create_worker(pool)) { > if (limited || !list_empty(&pwq->wq->maydays)) > return false; > } > > with memory pressure test via POOL_MANAGER_ACTIVE: > > if (!pwq->nr_active) > return false; > if (!need_to_create_worker(pool)) { > if (limited || !(pool->flags & POOL_MANAGER_ACTIVE) || > !list_empty(&pwq->wq->maydays)) > return false; > } > > What do you think? Yeah, POOL_MANAGER_ACTIVE seems like a more reliable condition to test. Let's do that. Thanks. -- tejun