From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0DEB26FDA8 for ; Mon, 24 Nov 2025 06:20:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763965226; cv=none; b=pz/Q1sSAUNyULY3GZ58D3dBm3de17d38a44lg4XioFewo/5rOb9nLBaYzGK1p9P46Z+VEMzMxEmEbmjChee1mu14Bj5NeLuLklpbGBE+iLy5KlrP+TkbwcnayLUoCiN/s8lVmqGuJLOtQv3DmNWILkiG9FuwIAtfXWbZNcesfA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763965226; c=relaxed/simple; bh=9vOp6QAlNYQyce2JUewamgiMt/YZ0C0xojMCKLqTtZE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LH0YmHp8h9Axr8b5Mds+XJm4nQS89zF6Ng5/RzhLCNU9vObmjzHTopU1pHe2PCd1HRSaVSy3VHHf7aX+W6Jhs5ZUoVc/4V8V3oDhCajpHXJpWOBjyr5KuNio/9gYJmendmEhWZd8mqOr+Hz7F1652Tyn2nvJ55I1fxCkZnWJRnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Tx6tIqXq; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tx6tIqXq" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-29555b384acso48288865ad.1 for ; Sun, 23 Nov 2025 22:20:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763965224; x=1764570024; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=EPAZIdyYVCYxtwDpqaoKTb52vleiQ/i4dqqg/wvgYNg=; b=Tx6tIqXq4y67pDCj3h2ULPIbbvzy1KlSsigx2mH9MlCBlrDw+Su9Ew+MTzvITnBEQR po2gCuouuMl2M2sIsH3bPunMHFiHHcKFvAB9IM+NzhEJ4CcLb2168gcyOCLHgdUCQHuE btInT0xeXsrK995dHvOVa2uCM3WDf3eVcl0sm63uerp76HN3eFV8MD+IG3eBuWMR/D7a JoRl1AllucjO0j+cHwRKzww7vKxTWtS8WFX7RBJtHLlZYRANF4vvPBwZQtTLYKU+dn7b qpEV2GhbTTUF+NUzs0suN96Z0aNUOfW9U7Sqg4/rLo5Q5rRcYkZrtBUBiLBP6war1UPf kSvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763965224; x=1764570024; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EPAZIdyYVCYxtwDpqaoKTb52vleiQ/i4dqqg/wvgYNg=; b=smTb0zhP5j5UawtF8IFR8TAviJ/iyeq80LQ94h0vqiLc5LrXxvsWXCccfytgLQnvR7 1uobfuZS98N9FQBh8ydxon58VUgFntxY4EKpPba/5JoSDZ9JgqrE2UEeIszlYulp7jTg GybqhSJotHS07Jn3vv2zcal4CwMpjXV+X9HYRz9/+tWhexfZ/xDwjBVeBItsVUupKvFD TiHD93wcC0DYP59WeEx+I13SmYmP9csOtQvWi8QJV+wObzT4TqM04yslYGEQZqRjPLHW /46Q+kG9vGVge4eeaj3ZD4bCC2kZbhGZwXfA0KGx/bRFWoCVkYTMSEaVPY3Ixo0uhgqS IiEw== X-Forwarded-Encrypted: i=1; AJvYcCXysUAZ5wAhT/50mPE97QhbaHv8p3NtVCkUAAayiFTQvM9g1ucM8qkTPLxhL5u9ALp0bwUaBZdZ53cwRzk=@vger.kernel.org X-Gm-Message-State: AOJu0YxQmGA7fHGHx+eRAFAXAjFIyrfMDsC48DWy3WSGvaeuaXX/w0Xg ydJksh9//JYjmXCyw+NBPGEPddG2fA0Q3GvuK65PdkFDmQ8hwiaAqhzlJicpjQ== X-Gm-Gg: ASbGncvdlEn5X+eLMygIqX5PhcxK3BbCjxVsO1JDAOSXY4Do2AWM6hcFIxvkJDyd+T3 0pHyD2u3DyhtcX03vacUSg91v9EqkPAt8KYNcjQ65oZ3H+2zM+Y/EZip1UBA2KGGdA8VchAFcWJ 0jblERex08p+M3wyIA6QfZPMOo6gmkcIHbkp8rhyMm0A2QjKxdhTFQwDKJYtyvc2A5AXLIyeN05 K8d5jNxerhc9UOf2tE+8hYVLZuV0uRS0zyimI1lpt9fy8cKD6opNKcvb3zQcRFGCoH9Udz2a9xQ rQnorwfTAeV5/XqXezUIFDlIBqgAvzZ8q6Y/u0wE5+RzhzfRQZuuDaNoiGDKrz6bR6eEp7Frtwl +Ro2XAEgtIeU0pfN5mU7l9MVrpGyIBOJaW8zfQyTNAYpIH0Fxw23RCkxEDUPzQhgo4mD7LItpJY g6e8/jq4Dm9ZRk7iUln2UeyuA7M3Yf X-Google-Smtp-Source: AGHT+IHJoDwILUcQXPwUe8P1tkXRtJWY2KzmfIUmyHGtav1GAcpdqT3BcrmL2fh/FT9Z0bJ8sWsLew== X-Received: by 2002:a17:902:d484:b0:297:c4b0:8d58 with SMTP id d9443c01a7336-29b6c6904b4mr114829205ad.46.1763965224148; Sun, 23 Nov 2025 22:20:24 -0800 (PST) Received: from JNA-L01.ad.analog.com ([59.9.235.253]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b111650sm120444025ad.8.2025.11.23.22.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Nov 2025 22:20:22 -0800 (PST) Date: Mon, 24 Nov 2025 15:20:17 +0900 From: Joan Na To: Rob Herring Cc: Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Joan Na Subject: Re: [PATCH v6 1/2] regulator: dt-bindings: Add MAX77675 regulator Message-ID: References: <20251120125449.26530-1-joan.na@analog.com> <20251120125449.26530-2-joan.na@analog.com> <20251120150343.GA1256330-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251120150343.GA1256330-robh@kernel.org> On Thu, Nov 20, 2025 at 09:03:43AM -0600, Rob Herring wrote: > On Thu, Nov 20, 2025 at 09:54:48PM +0900, Joan-Na-adi wrote: > > From: Joan Na > > > > Add device tree binding YAML schema for the Maxim MAX77675 PMIC regulator. > > > > Signed-off-by: Joan Na > > --- > > .../bindings/regulator/adi,max77675.yaml | 188 ++++++++++++++++++ > > 1 file changed, 188 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/regulator/adi,max77675.yaml > > > > diff --git a/Documentation/devicetree/bindings/regulator/adi,max77675.yaml b/Documentation/devicetree/bindings/regulator/adi,max77675.yaml > > new file mode 100644 > > index 000000000000..54cbbd59ff5b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/adi,max77675.yaml > > @@ -0,0 +1,188 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/regulator/adi,max77675.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Maxim MAX77675 PMIC Regulator > > + > > +maintainers: > > + - Joan Na > > + > > +description: > > + The MAX77675 is a Power Management IC providing four switching buck > > + regulators (SBB0–SBB3) accessible via I2C. It supports configuration > > + of output voltages and enable controls for each regulator. > > + > > +allOf: > > + - $ref: /schemas/input/input.yaml > > + - $ref: /schemas/pinctrl/pincfg-node.yaml > > + > > +properties: > > + compatible: > > + const: adi,max77675 > > + > > + reg: > > + maxItems: 1 > > + > > + reset-time-sec: > > + description: Manual reset time in seconds > > + enum: [4, 8, 12, 16] > > + default: 4 > > + > > + bias-disable: > > + type: boolean > > + description: Disable internal pull-up for EN pin > > + default: false > > 'default' does not make sense for boolean properties. default is how > should the s/w handle the property not being present. That's always > false for booleans and can't possibly be true as you have below. > > With those dropped everywhere, > > Reviewed-by: Rob Herring (Arm) Thank you for reviewing. I will drop all default: statements from boolean properties in the next patch. -- Best regards, Joan Na