From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 636BB2F7ABB for ; Mon, 24 Nov 2025 09:53:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763978028; cv=none; b=dVwmjxInNSs2Y3AVSYxlj5YOe5Qf6VoxA3FB2XgI2gIhOyjUnSOd9zK5fqHrKxoUe9azpx7l9LUnM8UfbvynUN9iy1URCAiGqJD9370RuMea2IrGdqRyIpfyBdFsLQMECvRLmZEZjIGqKdTx4dBF/lgol58dMX1ZbQaedtVrnrQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763978028; c=relaxed/simple; bh=wiljrihrTFWd3VE/1cDCgYhMxXMGfwVuactaVXvw534=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JeA1c0yO8BJo5MS7BVSjl0YovhIQXRXVsM98QkCSNKcrGERPWNWpzvlUcBPZ1+BZxlpxdimiXKFQF9eoOl8hWe1aX0Wg2RjkVgYQzlazZii1Uj9hG1aM/rBVxGJJrYiaFeWfxw0YuZr9AwV7QX21VfS0oG2fFFsOPZZnNik83Hg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=YuidMMKd; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="YuidMMKd" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4779ce2a624so36195355e9.2 for ; Mon, 24 Nov 2025 01:53:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763978025; x=1764582825; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:date:from:from:to:cc:subject:date :message-id:reply-to; bh=yEEvVNMGxH1RpDpApEF8jKXrYHO2JJ4qRnUSrmV+YwQ=; b=YuidMMKddCBCfSHdgoHci3AyM9Ao06LrHec/seSC68x7LNOy1slwhjR9za9hUznJkj +pnkr1D8WZEMFAev2p+S0ZowB6/X7UFZkeQnqz/WFfAgyJPL5C8Bv/qyRDIB7UBWHs3K nYwTFnlZEIRF/81W9UNyUMQvQzC6dw/+leV/TGsJXILqj1yxa+vlLvbivQkPrFfIfKJ1 u6kwLsZ6rQUk/pI7VLsUzY74ox70CqhADE0OJsLY20oIzkGuUtJ0b7vRzaJnZT6zVBln oZFtOUpb76ojbh7tulkwGXIa8I7k8gOW+IqzRiEqLtEyLpnbMJuzk/mDylrpmOoVxKhe /vjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763978025; x=1764582825; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yEEvVNMGxH1RpDpApEF8jKXrYHO2JJ4qRnUSrmV+YwQ=; b=d2JqwEZgIS++0e3vGR668wVHjelcP6mzpOIkjl2JwE3eRHMzyzVcybwzvslkWJU+/G x+CVYNONDIJPQ/awfScEGZumc4tE/Vam9bpKsoxSw8HgBQwVyr5cW6zgtSH6Io6uoC5I qGvwcOBCNH+Jh9HFAlT7ul9v+QFsrhhFwpor+SepIrWsloSLOkozINOGgWisrZ23yaBh XH0C4qut2xhaBJiGSY0llUKOxD25U7YUUzubyukbhYfTr7XFx00XMVCIMtAUTsfXBjeI p0f3x08luQOayhHK0qiRAtwUXiwKyeD5SLU21N85/Xri//HR4bPKYikGs05i6lR8r8Ty 23zQ== X-Forwarded-Encrypted: i=1; AJvYcCVaD6shXHPTaqKCusmaZz+DqTPlCdpjxkcuNTCCs8PEztfTcYSu51MecuCITRSJGZpSQw3g/hnZD9ZW7Es=@vger.kernel.org X-Gm-Message-State: AOJu0YzAUdhvgYYhABF+FkAoED5MpkpgqeaId6t9OxaNC8B2bzrAQ2wX dMe5Lek9Po7I0CElksmEur5kX0ij3ZpcBbTacEQIqPdIBrO+tbv7mcSyrH2Smat4DNRAIE/ikZY h/QBj8/hUnA== X-Gm-Gg: ASbGncufszET+XdPVHDFtY777CXMVJptrLcEOjfA0kNDBTXNv/kqAOHqL8pbo7Q6uTA QPxH24GNP2P5AMdhpJajoEb5zbIiSUE/yfHT3Q1rFMA7TcClqiS0WOf+FzFr1mQI60DyAINPpDX 7j7k+JnYQS0rYxtr//vcygMJuFh8mkW3cWMwE3QKflaGZ6xqikxQy36ZICjxdTA0Sh8dF3dUqeR EdJjEKl8JMjGIqS0+O4ctY6LFBMqq/qZDp2EPeEFJhmtwq3NYxYO52v/DCMsOAoP7h+u+zAGc3K sHD+W8twKtEIGMcRpjAE4/SJ5Vv0I+Ws4RMKlJ0Woy6aOyrzQehk1/cDFnBqJtqzdiGVTYXU99q O4V+1T1kl3aVIpRqGUpjgfDB8jQ2pG9+/rnt1rz+2hl3KYy3OFE8TIN+r0yJbVVxZA+ZQWBNC15 koecS493LhgixI9OfbP6nokY1nS6Yf/g/uTWLF0DFw X-Google-Smtp-Source: AGHT+IEPsM3DGKWYoDpxm2pkepfxTk3FEz1+Khe7iQyOX90yHBMaUDc+nhqgHMx9nNkbBY7QqEJgLQ== X-Received: by 2002:a05:600c:1f0f:b0:477:9aeb:6a8f with SMTP id 5b1f17b1804b1-477c017e20amr82946805e9.9.1763978024737; Mon, 24 Nov 2025 01:53:44 -0800 (PST) Received: from r1chard (220-129-146-231.dynamic-ip.hinet.net. [220.129.146.231]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f0b62e95sm14191368b3a.49.2025.11.24.01.53.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 01:53:44 -0800 (PST) From: Richard Lyu X-Google-Original-From: Richard Lyu Date: Mon, 24 Nov 2025 17:53:39 +0800 To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Kai Huang Subject: Re: [PATCH] KVM: VMX: Always reflect SGX EPCM #PFs back into the guest Message-ID: References: <20251121222018.348987-1-seanjc@google.com> <4311158801c41117a13afe0136c2807f6d9afbcd.camel@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4311158801c41117a13afe0136c2807f6d9afbcd.camel@intel.com> User-Agent: Mutt/2.2.13 (2024-03-09) Reviewed-by: Richard Lyu On 2025/11/24 00:28, Huang, Kai wrote: > On Fri, 2025-11-21 at 14:20 -0800, Sean Christopherson wrote: > > When handling intercepted #PFs, reflect EPCM (Enclave Page Cache Map) > > violations, i.e. #PFs with the SGX flag set, back into the guest. KVM > > doesn't shadow EPCM entries (the EPCM deals only with virtual/linear > > addresses), and so EPCM violation cannot be due to KVM interference, > > and more importantly can't be resolved by KVM. > > > > On pre-SGX2 hardware, EPCM violations are delivered as #GP(0) faults, but > > on SGX2+ hardware, they are delivered as #PF(SGX). Failure to account for > > the SGX2 behavior could put a vCPU into an infinite loop due to KVM not > > realizing the #PF is the guest's responsibility. > > > > Take care to deliver the EPCM violation as a #GP(0) if the _guest_ CPU > > model is only SGX1. > > > > Fixes: 72add915fbd5 ("KVM: VMX: Enable SGX virtualization for SGX1, SGX2 and LC") > > Cc: Kai Huang > > Signed-off-by: Sean Christopherson > > > > Reviewed-by: Kai Huang