From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 174D6296159 for ; Mon, 24 Nov 2025 15:08:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763996928; cv=none; b=iLedecWjyzYZyj51PwjkvvGa58/ESRWVkZSIsF5V8XNGHRwLSqJ6Dnz8FMrcXo7QeWDIp+fWXDEv3RITD7zKtsbw/SLRJmj3AUzoNhEoOlKV/NsSLzxh7hkv9yAyANpCiaQF0l2fkqAPrBasrJiKjU57/P/DdTyekQysiTMojL4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763996928; c=relaxed/simple; bh=8CdCb/4bJ8llpLAX9ZbnlZP3AsHFwPwiEDKuUzrhyCg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Rx/NRSvAj+iJSp6hRB2e/gmkhryKTXqZ4+05ebo11c6MXWT0QuV2WtmWj3C82BQF5oGHbLbCi2Abx72ihYRAikdNL9bNG82BZ8/jBKOpftjvxY+mLAlv2qrZliDPuXwUoWcHtjJ3WFiLAyDWaptBps/9xV1zg2oi1wB5Kmuofag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Ose8h3c7; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Ose8h3c7" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4777771ed1aso29315005e9.2 for ; Mon, 24 Nov 2025 07:08:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1763996924; x=1764601724; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FgVlxQtUZMPQwc8DBuwkrmC8F0Pqf+oVMs/NVzdQ+/4=; b=Ose8h3c7YG9jnsjEWdedZteEo6JaulzeBoPNBhl6wLMqBaDBZ26H4uxHwMlv/GiFBE 9X+zMuNW3dyH6ADacLDwud8KvD8ejS0UjKsqwVMV2uwXGsYaLV3SZmU/DLio5zOkse9N RepflLxfnsGMK2bE77bbsm4wouPJ6Fcb8efJzOUJf+s7VCrJq23t/49tIe3868C0SVjT +WRSGqZiekdFE6GJ+1c5drRAjbEY4lwIxH0mpCCxLAWK5f3SqUVzztJ6YUf/Az8b+Lht iPUUt+sTRtfB2MDeGS7WSP3Gu+7C0a4ENwflRT3cm6MWasy2LfqsTSQIry25rsMAlSJp Pljg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763996924; x=1764601724; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FgVlxQtUZMPQwc8DBuwkrmC8F0Pqf+oVMs/NVzdQ+/4=; b=qDYQet1wQmusH8jwMFkKF8joWuARwt8b4AZ8anDolxL7seNGUKaIgn8rYrj6YM4kEW l1vuHLL2k7iEOGN3pyVZk7O5eZtuaNFdMzBVmEziNPRp4yxuq95X88Y/mY5sWC5WDDma cgpSg2hUPY4tP6ZTG8ItXceYVuwKuHfdwEqmy7DWbWOVh+c5ZAp5fmiy+e0dSt9FF/1u G6UhNIuWh7+Okf6/iE6FbkyGZw1KnbUiNmjQN318I3XXKb8uIEmYlpYaem9dmyMDTD3L BeaVtXerTB2FhJP9D/jRWAdjv1bJTr4GnzcDXvZ9he/AaR3lM2+vk2JKbIh5T3xps/FK RXoA== X-Gm-Message-State: AOJu0Yxb9YA8rqTkwHnHm1oODRB3SZSjIhlDSWxp1Hz8bQPrilaa93iK sLh0CbA8pvaS40po9Gxyz3CdxMAjxpdNjwUsac+P+NV89h2XUvHyfT6ZsHpflEhX1gXdInkpCzb Ipawd X-Gm-Gg: ASbGnctyWJ2fImp0JI8arlN2ILvtESObAiXeQai7joVY4JjFjZKdogQeeX/WFi/mPt8 m4/d+Z+ET9ZnjGqqEADNMTOQ+WuFlToKfQcAJo8z8X9pp1AiKJ6LlMD8bJ50qg66I5YOKxbN1Zj +NwWqXmNwEONJfFttYkVucmz62zIhtpEkFwiX4LQmBGyMKO5in2Q0VmZ5W8+/HlNzhh8t042Wyf GMkMjhjyx6ptQFqYeN/6sB96PFqvm/XgwtaAHRQYNxFneDwFSp1HfRGXjczFJLU9URdOa0lR0O/ BqjFQpMWPpURJCrh9zDS2BPGPALEH5ry7jeEcSMCICSXAuE7LuB21VC6p8oFlaXfhaDwssSHvE+ BqKWQhNGLJlxyrSg7C8eV74QTjweLl6wVs+GkzmoV7ckAkzMQRU6B102m35P93JM0CW9GCxbc/c s2FPAXvW4/WySUFg== X-Google-Smtp-Source: AGHT+IGPK7jZnt85d+CjAAda8Qz3onLD2tiSbsiz7uEISYR+jvHvNJJmeVmDkH1ougIzKfnGE3f5Mg== X-Received: by 2002:a05:600c:354a:b0:477:97ca:b727 with SMTP id 5b1f17b1804b1-477c01b21bcmr104713045e9.19.1763996924396; Mon, 24 Nov 2025 07:08:44 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477bf355933sm207010345e9.2.2025.11.24.07.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Nov 2025 07:08:44 -0800 (PST) Date: Mon, 24 Nov 2025 16:08:41 +0100 From: Petr Mladek To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton Subject: Re: [PATCH v1 1/1] lib/vsprintf: Unify FORMAT_STATE_NUM handlers Message-ID: References: <20251120083140.3478507-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251120083140.3478507-1-andriy.shevchenko@linux.intel.com> On Thu 2025-11-20 09:31:40, Andy Shevchenko wrote: > We have two almost identical pieces that handle FORMAT_STATE_NUM case. > The differences are: > - redundant {} for one-line if-else conditional > - missing blank line after variable definitions > - inverted conditional > > Unify the style of two. > > Signed-off-by: Andy Shevchenko Looks good to me: Reviewed-by: Petr Mladek It is a trivial change. I am going to push it right away... Best Regards, Petr